Date:   Fri, 17 Mar 2023 13:33:21 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 05/27] drm/i915/gvt: Verify VFIO-pinned page is THP
 when shadowing 2M gtt entry
Message-ID: <ZBP7oZ1lkJhlSNpY@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-6-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-6-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?srCy7V9vLr126DuEA8ShqTcIVsXWBGX21oWAOa6KWOJAko3Lvganwl3qPf8k?=
 =?us-ascii?Q?mS49+yCj7YvBliUmrX7NEGzJ3q/BaTHjAhqY4DVg81x9zqV25f0gwCZRNWf5?=
 =?us-ascii?Q?P03BVlvVN62Zh8pcvmsS9HN+Iq3fSYCV+gpadStE4OVwITSG2K/hFsG4GVEQ?=
 =?us-ascii?Q?5lYIovMerjEVb2C4/mi+ReIBhcFXHXEc3DbzlcXmhC6xnA1md3zdiX0gQCok?=
 =?us-ascii?Q?dZT/Tsmm8OAPXQpQ5/OsopnjmV6xf7DMUzuSe4f06VXr2jCQw9Umcwp558k7?=
 =?us-ascii?Q?X6e+BBBLLoq+xbpUdYwo4i3SI6A030pO/jkLZE2pPlGeESbSUBuD3ByKu72i?=
 =?us-ascii?Q?NWM5Z4jTFHZPs1E7bHAhbCsh/rC4LIYtXXoz0LTktt1iqYfvlliXLXaRk4c1?=
 =?us-ascii?Q?wG4rnFm1EM8WxhlRhoHCdsI+mhxMIbFeQKKwPJ/9cT0RJ5Ye8LqvvOa36SHp?=
 =?us-ascii?Q?IY8YvCe8JnNi5/eaTsFDA3HOafF8tgfsR4gis8gWab/glT0C6nzyaQTDC7PI?=
 =?us-ascii?Q?UiWrZHxXGy8aqIwslI6OxD5CroyyVJRWs57mmzLvURaG4+XEGdJU8cGARCkV?=
 =?us-ascii?Q?ymUf5DXDkyhmhbScx30qepn7kQqN4m/ldhKDH4vw/STTxFCCfyWBPsUq7c44?=
 =?us-ascii?Q?sCgOZQ40Z+VCqtngpiDDZFdljnqvNcYHpYxD/50ZYOtkzRHMwpNdRCB/6tK0?=
 =?us-ascii?Q?Q2U9vPMdqcGp6gKtsoJI7DiP1WxEhejz0bR2mtiyJzc9q5xq3VSSJHJ/DIMy?=
 =?us-ascii?Q?N3XHc1r2xZ+bx36fzzJUQYQ0964rU0lkKOoyZuBeK4M2iUBmJ52fTz2TJtwg?=
 =?us-ascii?Q?QrGKcHu3EUvDZyrad/l/AO5omMXVlnLyvlWxpUdSVjaxONBRDZujNE4AztKN?=
 =?us-ascii?Q?hRFg0reT/wMPntkmvtKk3KuDj0NzWahT/fOQA6blxRbCF6Y6rU6YynjsViYN?=
 =?us-ascii?Q?E6mD61y2rgMtHFa5iYjPWTGxzCT+V4g48Eyl3dKobBvGSFEWLjctnz6vm5LY?=
 =?us-ascii?Q?QUMCrkI5hwa1BCuRAhVsGkElIdZBQwtl4+jfO4v0iCLbvNV7b3/UqhIxtcRq?=
 =?us-ascii?Q?WV224tPwl1CuqSPWQzQH63WcMiaHpK5CekFJezeitP5aWGA0YCyvQKonaiWb?=
 =?us-ascii?Q?PypBmD0RKD9R6dJV21yMu5OPoTcwqnkf8fTijfNBx0yTXe9ZhnELDMQRWmUN?=
 =?us-ascii?Q?AXvvhW3pAG8qICUHoiDeWOkbDYQIAi05yZ51NMJQkpUHZZmIEVvVIRdDWp50?=
 =?us-ascii?Q?ZT6YXHn1AMrxxI9IIkxM5ZXY6O3BO7ulPFNO0AWHc8tunvK2eFixw6Br3vSV?=
 =?us-ascii?Q?sbBG52jX9hT4LqKfi72oMKN9NiS9h+066Zu/kgfLcdZhInIo8eApgdDhuA9x?=
 =?us-ascii?Q?VGn5HR9hbHGKNM3JCkTBJMVRLu40NOW3+++Nt3neguYmOQw6NHPvVOiFc+U3?=
 =?us-ascii?Q?x7wDr9/OnXKPjFd/5sO0l0VMqeAqmu1PajyzCRMx52vIwbYXUoqjS8Xe5R5S?=
 =?us-ascii?Q?SLf96bX/wZqio7koOYHpDtf0y4IUvCXyfiM99npC1UjFlF9h8yNtYiMktb8D?=
 =?us-ascii?Q?tF7RDSksALQGg0E9Zq27RP2nBq1t0oZ4TdBVJfxcH0AvxL1/8egZ9wdnLeJ8?=
 =?us-ascii?Q?0A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c910c856-a15e-42c7-7b17-08db26ac90c1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 05:58:01.0542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oDOfq7hbY4c3M0Z+3f7HE1dYD2W2zxThWOIek3+vhfeczvWwVUdgF2MGYmDe4mbWyrdF/UfoamAM8dcGIC4KWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7499
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 04:22:36PM -0800, Sean Christopherson wrote:
> When shadowing a GTT entry with a 2M page, explicitly verify that the
> first page pinned by VFIO is a transparent hugepage instead of assuming
> that page observed by is_2MB_gtt_possible() is the same page pinned by
> vfio_pin_pages().  E.g. if userspace is doing something funky with the
> guest's memslots, or if the page is demoted between is_2MB_gtt_possible()
> and vfio_pin_pages().
> 
> This is more of a performance optimization than a bug fix as the check
> for contiguous struct pages should guard against incorrect mapping (even
> though assuming struct pages are virtually contiguous is wrong).
> 
> The real motivation for explicitly checking for a transparent hugepage
> after pinning is that it will reduce the risk of introducing a bug in a
> future fix for a page refcount leak (KVMGT doesn't put the reference
> acquired by gfn_to_pfn()), and eventually will allow KVMGT to stop using
> KVM's gfn_to_pfn() altogether.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 8ae7039b3683..90997cc385b4 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -159,11 +159,25 @@ static int gvt_pin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
>  			goto err;
>  		}
>  
> -		if (npage == 0)
> -			base_page = cur_page;
> +		if (npage == 0) {
> +			/*
> +			 * Bail immediately to avoid unnecessary pinning when
> +			 * trying to shadow a 2M page and the host page isn't
> +			 * a transparent hugepage.
> +			 *
> +			 * TODO: support other type hugepages, e.g. HugeTLB.
> +			 */
> +			if (size == I915_GTT_PAGE_SIZE_2M &&
> +			    !PageTransHuge(cur_page))
Maybe the checking of PageTransHuge(cur_page) and bailing out is not necessary.
If a page is not transparent huge, but there are 512 contigous 4K
pages, I think it's still good to map them in IOMMU in 2M.
See vfio_pin_map_dma() who does similar things.

> +				ret = -EIO;
> +			else
> +				base_page = cur_page;
> +		}
>  		else if (base_page + npage != cur_page) {
>  			gvt_vgpu_err("The pages are not continuous\n");
>  			ret = -EINVAL;
> +		}
> +		if (ret < 0) {
>  			npage++;
>  			goto err;
>  		}
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>