Date:   Thu, 16 Mar 2023 22:59:51 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
        "dave.jiang@intel.com" <dave.jiang@intel.com>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvdimm: nvdimm_bus_register: Avoid adding device to the
 unregistered bus
Message-ID: <641401d75d039_1dee294a1@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <1678955931-2-1-git-send-email-lizhijian@fujitsu.com>
 <64133bcbbe368_269929415@dwillia2-xfh.jf.intel.com.notmuch>
 <ca55bea9-d2a8-ccce-010e-a26f6003a059@fujitsu.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ca55bea9-d2a8-ccce-010e-a26f6003a059@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y0OvtS/R6doldoSfmnV57robbWuOfXoBso23dyFcAaxMWfud0BJNvrf/YrUm?=
 =?us-ascii?Q?danDYUX+KoQ3bOmYYQoYKi9ti/uZ10yMLzY60YYo8JzoqFvl/QeAOKyPs8Jd?=
 =?us-ascii?Q?fDJ/jDoLISIMglbO1ykKtHpX8dEyw/R+LYEHNT4+J4tfzB+uIW6AHybs5wYr?=
 =?us-ascii?Q?x+Udtoz0KwHivAZ+wj3pe+5SPAhotTooEU5zNwsH6vM2469aI8raoTOPNHZF?=
 =?us-ascii?Q?+zvQCT1dvVkg+tjGZ76SrO7b6+UDbU5mGbaRyCfsq7A/x029Nmd+gW8jnnk7?=
 =?us-ascii?Q?7lOdxnC4CL3UVcW8Grsx8ncS5qOrK2EI3ZLiwx+iZtEWSZwi7S5pc5p6gAEj?=
 =?us-ascii?Q?RKPdf3dzjPsfeBYlU8ZD/ZBgrcFmTKOTpg9vKhD2/V6wKAsem8ZQyG8KkB6o?=
 =?us-ascii?Q?dINcQFe8xX57CdqtLsjegGPb2rdkzyEi+dkiTCwEe/lQUEa0z0FEI4TCzAKT?=
 =?us-ascii?Q?rTyo8K1UWmv8oEBAycQbMirqkKH6WJ/0Rxuo4kwKXhNoDAkr2H7r0dUOFvLq?=
 =?us-ascii?Q?7neksNQTt9PSuSruZU7/looMyw+0z+o4coiOj5gF0kQefR5IEGGoWnxzaGdv?=
 =?us-ascii?Q?dxHtwKsHMPdJtXMIjtCWl04RwdX8K175hb+UPBnNLuyapsIwmcxvHIBQny6/?=
 =?us-ascii?Q?IBGMI6Br4hr/4x8OdJoDrJfJeN+H7vsDyymKpPhmTUjksXAab2PNvgruRGI2?=
 =?us-ascii?Q?2pcSAtb201inaUExbJXjFoV3YIdvOjJkLT4zEhFjonsA9vOQIoUSGXZkv+6m?=
 =?us-ascii?Q?dasInURb7S69z3S9WQXPKwb8fNesK8sWT5jq41NPZYEmh+Yz1Fx73lg9zGa6?=
 =?us-ascii?Q?0VET041o1sm8Gl5dkzEUC/XTUOFYQoEPjl+JgPuKSz0ZaHwySuKFdMzc2SLK?=
 =?us-ascii?Q?QUV+YuFHk0yP80Ei0lTh9cmm+pjlvYlgis04UJx1vEISKtgPLAZwDb8oThEE?=
 =?us-ascii?Q?B1QwJlmhqiYcoOp6eeM/ek0oGUr8yiafC/QVPdpPNURUpI7iATmEPEAshnUj?=
 =?us-ascii?Q?YpeDtECumxUVu1ovQqNw/GCoIFipKi2+yrXOID9BYAyZBz8H74ajXI+L1ZL7?=
 =?us-ascii?Q?Bf4JQIhuRHNlWOIkWExIA+ZO1oSMNwaogT3b9kyPBfiBSHeNZvUC1FVFQk+q?=
 =?us-ascii?Q?yTZpSlUNHzyNcs3YVWTkwyc4lNxEUIz9kmcPGyHIoh0gdlSjNQRYHSVbgnJf?=
 =?us-ascii?Q?r0BIu9LcDjzzYYasjjdGbXOe//RMSCSPpyQH4J2+lRIFL/4oufiOH0j5v8i6?=
 =?us-ascii?Q?wwzcUeuE0tnD4THRhCkAGZagxY2pyRAT0BBBdn95VmNWZ2S3K/4yngc7Og3U?=
 =?us-ascii?Q?BViLSXsSPEA3sflb3jBGKbGQ5tZlnb6GcXAVaofyhu3PxrF5bjSz4aVt4w7q?=
 =?us-ascii?Q?q2OKEk/m1l/Fu27TbuuZt8RIEpslCTGGCRwxN9oTmw8WgxIeyjZz3etVWv4s?=
 =?us-ascii?Q?j6m+h1XAvwtq4NGxifhg7HLzNVFbzYTYR6YY6cqTgX5xlV+6KWxw1Rl5SR34?=
 =?us-ascii?Q?W5kv+Dzf81JiBBmdhKVZFzQ7G8gyTh6qtSzGpSM6dEyoGTLBxdQ/OyOGfYjg?=
 =?us-ascii?Q?oW+Ff7DrKpoGyYDcfCL2y7eyKthxd8Vd9d8FuNWo6BKvBHmcxirQq0Vqkyjr?=
 =?us-ascii?Q?kA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56e1aed4-5abd-4a87-514b-08db26acd452
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 05:59:54.3483
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xi9JUGgn8W7t0MA3kg24K7K9XzVZTSffNX3UxQZAxrOJTKSHY0S/P0/gZhUHJo6GarEJvCIiaaCq51vNZYcDaVTm4XuEXvpB3DJ4gXetOnw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7989
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

lizhijian@fujitsu.com wrote:
> 
> 
> On 16/03/2023 23:54, Dan Williams wrote:
> > Li Zhijian wrote:
> >> nvdimm_bus_register() could be called from other modules, such as nfit,
> >> but it can only be called after the nvdimm_bus_type is registered.
> >>
> >>   BUG: kernel NULL pointer dereference, address: 0000000000000098
> >>   #PF: supervisor read access in kernel mode
> >>   #PF: error_code(0x0000) - not-present page
> >>   PGD 0 P4D 0
> >>   Oops: 0000 [#1] PREEMPT SMP PTI
> >>   CPU: 0 PID: 117 Comm: systemd-udevd Not tainted 6.2.0-rc6-pmem+ #97
> >>   Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
> >>   RIP: 0010:bus_add_device+0x58/0x150
> >>   Call Trace:
> >>    <TASK>
> >>    device_add+0x3ac/0x980
> >>    nvdimm_bus_register+0x16d/0x1d0
> >>    acpi_nfit_init+0xb72/0x1f90 [nfit]
> >>    acpi_nfit_add+0x1d5/0x200 [nfit]
> >>    acpi_device_probe+0x45/0x160
> > 
> > Can you explain a bit more how to hit this crash? This has not been a
> > problem historically and the explanation above makes it sound like this
> > is a theoretical issue.
> > 
> 
> Dan,
> 
> Configure the kconfig with ACPI_NFIT [=m] && LIBNVDIMM [=y], and add extra kernel booting parameter
> 'initcall_blacklist=libnvdimm_init'. Then kernel panic!

That's expected though, you can't block libnvdimm_init and then expect
modules that link to libnvdimm to work. You would also need to block all
modules / initcalls that depend on libnvdimm_init having run. I'll
respond to the other thread with some ideas.