Date:   Fri, 17 Mar 2023 07:03:08 +0100 (CET)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     Sumitra Sharma <sumitraartsy@gmail.com>
cc:     drv@mailo.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        outreachy@lists.linux.dev
Subject: Re: [PATCH v4] Staging: octeon: Fix line ending with '('
In-Reply-To: <20230317052455.GA83442@sumitra.com>
Message-ID: <alpine.DEB.2.22.394.2303170700270.3105@hadrien>
References: <20230317052455.GA83442@sumitra.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Thu, 16 Mar 2023, Sumitra Sharma wrote:

> Since the coding style limited the code to 80 columns per line which caused
> splitting the function header into two lines resulted in the first line
> ending with a '('. This caused the checkpatch error.

The first sentence is still not really grammatical.  Something like:

The coding style used to limit lines to 80 characters, which led to
splitting this function header into multiple lines, and ending thie first
line with a (.

For checkpatch, is it an error or a warning?

julia

>
> Place the function parameters immediately after '(' in a single
> line to align the function header.
>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
> ---
> v2: Change patch subject and description
>
> v3: Change patch description, noted by Deepak R Varma
> <drv@mailo.com>
>
> v4: Correct grammartical mistakes, noted by Julia Lawall
> <julia.lawall@inria.fr>
>
>
>
>  drivers/staging/octeon/octeon-stubs.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 7a02e59e283f..3e7b92cd2e35 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1372,9 +1372,7 @@ static inline void cvmx_fau_async_fetch_and_add32(uint64_t scraddr,
>  						  int32_t value)
>  { }
>
> -static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(
> -	int interface,
> -	int port)
> +static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi4000_check_speed(int interface, int port)
>  {
>  	union cvmx_gmxx_rxx_rx_inbnd r;
>
> --
> 2.25.1
>
>
>