From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     Frank.Li@nxp.com, devicetree@vger.kernel.org, festevam@gmail.com,
        imx@lists.linux.dev, kernel@pengutronix.de,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        s.hauer@pengutronix.de, Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: imx8qxp: add cadence usb3 support
Date:   Fri, 17 Mar 2023 07:39:09 +0100
Message-ID: <3810738.Icojqenx9y@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20230316212712.2426542-3-Frank.Li@nxp.com>
References: <20230316212712.2426542-1-Frank.Li@nxp.com> <20230316212712.2426542-3-Frank.Li@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Am Donnerstag, 16. M=E4rz 2023, 22:27:10 CET schrieb Frank Li:
> There are cadence usb3.0 controller in 8qxp and 8qm.
> Add usb3 node at common connect subsystem.
>=20
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../boot/dts/freescale/imx8-ss-conn.dtsi      | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi index
> 4852760adeee..389f52f16a5c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> @@ -138,6 +138,56 @@ fec2: ethernet@5b050000 {
>  		status =3D "disabled";
>  	};
>=20
> +	usbotg3: usb@5b110000 {
> +		compatible =3D "fsl,imx8qm-usb3";

Mh, is imx8qm considered a subset of imx8qxp or vice versa?
Maybe it's worth adding a dedicated compatible for imx8qxp as well.

Best regards,
Alexander

> +		#address-cells =3D <1>;
> +		#size-cells =3D <1>;
> +		ranges;
> +		reg =3D <0x5b110000 0x10000>;
> +		clocks =3D <&usb3_lpcg IMX_LPCG_CLK_1>,
> +			 <&usb3_lpcg IMX_LPCG_CLK_0>,
> +			 <&usb3_lpcg IMX_LPCG_CLK_7>,
> +			 <&usb3_lpcg IMX_LPCG_CLK_4>,
> +			 <&usb3_lpcg IMX_LPCG_CLK_5>;
> +		clock-names =3D "usb3_lpm_clk", "usb3_bus_clk", "usb3_aclk",
> +			      "usb3_ipg_clk", "usb3_core_pclk";
> +		assigned-clocks =3D <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_PER>,
> +				  <&clk IMX_SC_R_USB_2=20
IMX_SC_PM_CLK_MISC>,
> +				  <&clk IMX_SC_R_USB_2=20
IMX_SC_PM_CLK_MST_BUS>;
> +		assigned-clock-rates =3D <125000000>, <12000000>,=20
<250000000>;
> +		power-domains =3D <&pd IMX_SC_R_USB_2>;
> +		status =3D "disabled";
> +
> +		usbotg3_cdns3: usb@5b120000 {
> +			compatible =3D "cdns,usb3";
> +			#address-cells =3D <1>;
> +			#size-cells =3D <1>;
> +			interrupt-parent =3D <&gic>;
> +			interrupts =3D <GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 271=20
IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 271=20
IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 271=20
IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names =3D "host", "peripheral", "otg",=20
"wakeup";
> +			reg =3D <0x5b130000 0x10000>,     /* memory area=20
for HOST registers */
> +			      <0x5b140000 0x10000>,   /* memory area for=20
DEVICE registers */
> +			      <0x5b120000 0x10000>;   /* memory area for=20
OTG/DRD registers */
> +			reg-names =3D "xhci", "dev", "otg";
> +			phys =3D <&usb3_phy>;
> +			phy-names =3D "cdns3,usb3-phy";
> +			status =3D "disabled";
> +		};
> +	};
> +
> +	usb3_phy: usb-phy@5b160000 {
> +		compatible =3D "nxp,salvo-phy";
> +		reg =3D <0x5b160000 0x40000>;
> +		clocks =3D <&usb3_lpcg IMX_LPCG_CLK_6>;
> +		clock-names =3D "salvo_phy_clk";
> +		power-domains =3D <&pd IMX_SC_R_USB_2_PHY>;
> +		#phy-cells =3D <0>;
> +		status =3D "disabled";
> +	};
> +
>  	/* LPCG clocks */
>  	sdhc0_lpcg: clock-controller@5b200000 {
>  		compatible =3D "fsl,imx8qxp-lpcg";
> @@ -234,4 +284,26 @@ usb2_lpcg: clock-controller@5b270000 {
>  		clock-output-names =3D "usboh3_ahb_clk",=20
"usboh3_phy_ipg_clk";
>  		power-domains =3D <&pd IMX_SC_R_USB_0_PHY>;
>  	};
> +
> +	usb3_lpcg: clock-controller@5b280000 {
> +		compatible =3D "fsl,imx8qxp-lpcg";
> +		reg =3D <0x5b280000 0x10000>;
> +		#clock-cells =3D <1>;
> +		clock-indices =3D <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_1>,
> +				<IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>,
> +				<IMX_LPCG_CLK_6>, <IMX_LPCG_CLK_7>;
> +		clocks =3D <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_PER>,
> +			 <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MISC>,
> +			 <&conn_ipg_clk>,
> +			 <&conn_ipg_clk>,
> +			 <&conn_ipg_clk>,
> +			 <&clk IMX_SC_R_USB_2 IMX_SC_PM_CLK_MST_BUS>;
> +		clock-output-names =3D "usb3_app_clk",
> +				     "usb3_lpm_clk",
> +				     "usb3_ipg_clk",
> +				     "usb3_core_pclk",
> +				     "usb3_phy_clk",
> +				     "usb3_aclk";
> +		power-domains =3D <&pd IMX_SC_R_USB_2_PHY>;
> +	};
>  };


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/