Date:   Fri, 17 Mar 2023 14:19:36 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 08/27] drm/i915/gvt: Use an "unsigned long" to iterate
 over memslot gfns
Message-ID: <ZBQGeJiNosyes2DM@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-9-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-9-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d4kDCdlJOEFgaBpoN7hJUKDD9BvqZoDcwneJIjmBv3a7C79IAhzQ4Riv9ULP?=
 =?us-ascii?Q?VXgujwQBkaeCBo7FSb9ELpdAsyOzZPUnTiIPx8vv0JGr6uSwcPChb/rJR5Pl?=
 =?us-ascii?Q?IWTKr2zGsS+HC3NzBzi+ROfKtdDC9eZj4O71D+EedCqaG5cWI3FGMytgysv5?=
 =?us-ascii?Q?bs6JqesfC7YB2nPUv34+aFPoBV775a8V07yY6sUW6oMELrvmiajNAZPsmq00?=
 =?us-ascii?Q?6zKfQZip1WM+G+J8bSvcktq3TdWw1T5iqJAjlSXkmiBESrioR5cHlJkQUVkB?=
 =?us-ascii?Q?N4eAT1I0d9GoDVTRc36TEQlsr4yIBNhFjzlTcdGOMPP0Nw4s8kY+t81JLWhM?=
 =?us-ascii?Q?x/RcDgC+ae+dl+6godbB8/XcjdLk6old1zkbqcKdU78ksBiXfsWA3NYHR9XQ?=
 =?us-ascii?Q?B4yIoAXrQGDjbQk1kj377m95JN9ieL4s2AdF96HyuVsOSbXqXFsRAycVHgWl?=
 =?us-ascii?Q?Wc57M3C4Hy/H1rAkawiQsSa2zWTM6uC14a8WYXaAhjyuZBQSDFvsA/OOGAr3?=
 =?us-ascii?Q?ftLoRTH+GlFZqNeCfIsCDGPccfnADRHCIr8NxzphfSt6dpIGU2argIiIVAgN?=
 =?us-ascii?Q?t7iZzXCq+s4djk9cFigvdl472XTd31Qro9Vt55cJfyBpkBimOdH3JO7bzUjb?=
 =?us-ascii?Q?ihSsHqqnChqgcN2ckBkmZTDaremDshRMEYpIuMoR8zz4W55u/VmTeWS+Iosz?=
 =?us-ascii?Q?T1RDZ9lh0tCOBjYRLhZfZEiA28lOU0qz81stqipX+nA3cksmN3A7tDqZPEjL?=
 =?us-ascii?Q?FC12N0uQQkW2G/UwsM9oLeU21OZk0mxswYWbWU7l4dq67qKb4XKTPbnZB22k?=
 =?us-ascii?Q?qsg00TJo4VwGoG/rLmlIlcUO0ERmCQyzUfnpF0oXgLv+v4PG9HWRMT8AS+hq?=
 =?us-ascii?Q?8fGPYGnxW7NoQiLedpZWscEYIWakfxECLRvqEmDzPED6+0yl3gl8q7yWqpZw?=
 =?us-ascii?Q?c06KdDBvJVtEgpNhyZpP4eC/P+xjPCSKrhnGPWSPEvbXtHPr+rbU4fdQi945?=
 =?us-ascii?Q?2wCRfbH6TXj7/Gn+7Divi3QubrMMcCmr4X+fuuhTbhm98JdMzD32An/xq6IT?=
 =?us-ascii?Q?DdVZ+l7g7V99coKAJ6Ak1q8aiZXQTW8Z2K9HxodOMY5+P5KsBqka8tLMIfms?=
 =?us-ascii?Q?PMrGhw3jsoYqB6SkZ33MixRegwzQleNFARlNQ9r/X1mcr2Pcbd4T9+2Iq3Pq?=
 =?us-ascii?Q?3Lo+42xMTxWfmnPAHzc0mi0rNg0IdeS5NctLMAv6M4evaA974vJS3zrZZA8Z?=
 =?us-ascii?Q?tBVv7LUSuLvA7hvSh7nMHqnsuh0mZ49tYxMFffzRW7PHBEBtz2H0MIx296YS?=
 =?us-ascii?Q?xEefSXpxYaUy50RkGmr1zP/ToCXTjQXkm/h7UraBfMGDq+pxnYBUHhMTmr/X?=
 =?us-ascii?Q?SCY654ZQlpFJ5SmXi4Agt82MUmUkA61qXTwARCasUq5bWpN4tN0chJEMQrUy?=
 =?us-ascii?Q?yDqfFZZ9MIr3/Ai0Gn80KT/wCojZZj5vOokuIyP7fAA/wiKc8bkCRgK/TiG/?=
 =?us-ascii?Q?+TNPmipuncc0t5KXcbApPmSjbN4D3qTHlmD7jm8/6DDBd4/tpLqr2JlGHbtK?=
 =?us-ascii?Q?YeQXn+aO7uZ6bAZZhQmalY0KxRDxHWjStg6vuWMW0VcFPWqyJOCsHol45Ric?=
 =?us-ascii?Q?OA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b758b9bd-e9e9-40ad-b6ca-08db26b305a7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 06:44:14.0510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yJdFSRXzJ1yhXt6TLCfixcFeTG5GpoNNR+m2SjELed4bVRRFa1LWDDCm5guSydRJ58+hUHCVuD/RvYRxsIp5Dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6759
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>

On Fri, Mar 10, 2023 at 04:22:39PM -0800, Sean Christopherson wrote:
> Use an "unsigned long" instead of an "int" when iterating over the gfns
> in a memslot.  The number of pages in the memslot is tracked as an
> "unsigned long", e.g. KVMGT could theoretically break if a KVM memslot
> larger than 16TiB were deleted (2^32 * 4KiB).
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 90997cc385b4..68be66395598 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1634,7 +1634,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm,
>  		struct kvm_memory_slot *slot,
>  		struct kvm_page_track_notifier_node *node)
>  {
> -	int i;
> +	unsigned long i;
>  	gfn_t gfn;
>  	struct intel_vgpu *info =
>  		container_of(node, struct intel_vgpu, track_node);
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>