Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7337C6FD1D for ; Fri, 17 Mar 2023 07:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230238AbjCQHdp (ORCPT ); Fri, 17 Mar 2023 03:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjCQHdm (ORCPT ); Fri, 17 Mar 2023 03:33:42 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED7501F922; Fri, 17 Mar 2023 00:33:38 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id DD55D68AA6; Fri, 17 Mar 2023 08:33:33 +0100 (CET) Date: Fri, 17 Mar 2023 08:33:33 +0100 From: Christoph Hellwig To: Saeed Mirzamohammadi Cc: Christoph Hellwig , "# v4 . 16+" , Keith Busch , Jens Axboe , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Message-ID: <20230317073333.GA14827@lst.de> References: <20230315223436.2857712-1-saeed.mirzamohammadi@oracle.com> <20230316051508.GA8520@lst.de> <930CF361-37C2-4625-B5FA-245248544F92@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <930CF361-37C2-4625-B5FA-245248544F92@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote: > > eui64 values are not unique. Here is an example: > namespace1 > nguid : 36554630529000710025384500000001 > eui64 : 002538191100104a > namespace2 > nguid : 36554630529000710025384500000002 > eui64 : 002538191100104a > namespace3 > nguid : 36554630529000710025384500000003 > eui64 : 002538191100104a > namespace4 > nguid : 36554630529000710025384500000004 > eui64 : 002538191100104a Eww, that's really a grave bug. Interestingly enough the nguid works, so I wonder if we should just quirk the EUI so that we have a least some uniqueue identifier. > I haven’t yet contacted Samsung. Do you recommend any one to reach out to? We have plenty of Samsung folks here on the list, maybe someone can reply?