Date:   Fri, 17 Mar 2023 15:28:09 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 13/27] KVM: drm/i915/gvt: Drop @vcpu from KVM's
 ->track_write() hook
Message-ID: <ZBQWifhj6lZxRlMa@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-14-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-14-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2I+cPsCzIPon0iY84JtdqWFtdVfr5yIuYhlt921+Ma/+5tuzL8W2qynrXwu6?=
 =?us-ascii?Q?WYjfQf7I2U+bh0r1Ro63Nb8ylq5FbeK60iYfckpM6XWPiVMDtmPPkfxdPfA7?=
 =?us-ascii?Q?xAIARLNbml1283UR5P7jnRx1MCnBgoAmUzmDibcrtQcUYmVo0MVU3sgwb3eo?=
 =?us-ascii?Q?tpxhcB+tt6ZHrgE0pTvV+4PYUog73Zy5OU3uF2Ezb+NnWDZyeT6GrA+/v9Cs?=
 =?us-ascii?Q?BwcEVUHMaiEujaX+/YQSonKIA14U3z/6QK1nsVh7p+RUZsFxWELGqwWDkxZN?=
 =?us-ascii?Q?xLWUlEAC9MN3W9vsLkGYNNP+A6yRFJ+jqlgO8L9LwZI0NnscPGu1k/Ta1P6j?=
 =?us-ascii?Q?raBr4y4Wqvx8J7NDg9DIckzxnD/O2nTT4Rj6ghcXjWL20bMu3wAXA42a4jvs?=
 =?us-ascii?Q?JPI2LcAWSSmT+wwUo7dJgXDVW7txthsazHp4F1itgINv7PGWHCyxwiRKUljr?=
 =?us-ascii?Q?grh/Pyyt8yFty3DCpbyOolbSmhO5nAH4mewfGl+O+p/XCoURJWKjqAF9W+ix?=
 =?us-ascii?Q?FKidSLuiqg6uIqJdyMJVqVi2iDCEAWLWWrwpxV30fIbznT5BiHyn78eO1ETJ?=
 =?us-ascii?Q?U853gb1o1Hyj7zON3z2gl3NoJqHUk10K6ZxpG8OCpvMu7w+EGsMSRx8v7msZ?=
 =?us-ascii?Q?9mfzp2rSG+wzxpF/i/0M3HZE0J6VqaMH/zKluSvpwzb9dfjMLLlSOpeIqcbm?=
 =?us-ascii?Q?18TWsQBemhHes9NfgSOTv8SD/SNXFF9GhHpsktWdzjVyT7ZNigCJOv3kKCDN?=
 =?us-ascii?Q?qjFlgND0fPXv1R34OOg6iWqxn/iqW5Hn5ms78AdsjFxOwYBj1d7EwJmYbj/K?=
 =?us-ascii?Q?1qrhqEXgU1M/4wg5aUYl+xitgPi/K82gFHNEby9VN6byy6nCofddsQv3wPOM?=
 =?us-ascii?Q?1hWE81FiBvQ05lQnCesjtwrm3GA93d2F9cmp+0CB2m0t5grG2/FFBFADhKoS?=
 =?us-ascii?Q?nErriCiIurjs0APa4ZJL32knNvov/It++bih4XrGrLsMAiG7Jy8pcL9ZMerg?=
 =?us-ascii?Q?tACJ6Diqlb70iMr+aWIMkOMn1frd7TdngCGco7W5COwtu8da4epw3g1j5DxY?=
 =?us-ascii?Q?VHLWYODCpixmrVq01eagXqCqpncgkeLgnUFc8RaQ4i/GTdX3Y9cPqCvLV3NO?=
 =?us-ascii?Q?z75gvAFaWrwVXiz9vovCKJ1DVRzPwcLFZMOHhrzoyo4WSvLIuD7GzKEdK1c6?=
 =?us-ascii?Q?sY3+iiSmAACANFbr0RLqq/rlkw8OqzIY/Opt11VTMZ87fBQ4DmDWZ900OPl1?=
 =?us-ascii?Q?G6LNmKGKBWGEng/zUzzNA5XZqUHTiVk8xPHXs3a8RAsU8cjUnAxAl24aZn39?=
 =?us-ascii?Q?MNdYSsCSS07dqh22wihI2fVCWnuVaYfft6wqPU3kVnA78ReJ0LG20RdBUrs+?=
 =?us-ascii?Q?tNaVHYm6DoDjJtbcLmkFNQE1/P5jojfVfbrvq1WkgFLPCsnA0WYwr4Kv2kjK?=
 =?us-ascii?Q?8lejhR+luiv7bj8G5O8uLWfTVhntGyN3D2N7WUkqxY4VOJXse62yH0lco+ub?=
 =?us-ascii?Q?lGsCSrc9cPBQ+RwAg0hkpg9K65GFqJohm855E1VZ/1v5esGatPvLddvoio8n?=
 =?us-ascii?Q?Updz0Ln4VPSPd8DDE5dND1BzYNB0KiVCYl7l6TJzlUG7SlQD4jiHcqVJROdL?=
 =?us-ascii?Q?Zw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83efed58-988f-4a60-ae86-08db26bc99b6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 07:52:47.9681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QKJe98bwQD2F5w+e27jjEPAJZ6yXrjbE9KRwW6vfmiNPubSZ74OWAA46K3yu6Z4soZD0/+8v6H1Jo9+t764PEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6272
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>

On Fri, Mar 10, 2023 at 04:22:44PM -0800, Sean Christopherson wrote:
> Drop @vcpu from KVM's ->track_write() hook provided for external users of
> the page-track APIs now that KVM itself doesn't use the page-track
> mechanism.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  arch/x86/include/asm/kvm_page_track.h |  5 ++---
>  arch/x86/kvm/mmu/page_track.c         |  2 +-
>  drivers/gpu/drm/i915/gvt/kvmgt.c      | 10 ++++------
>  3 files changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h
> index 3f72c7a172fc..0d65ae203fd6 100644
> --- a/arch/x86/include/asm/kvm_page_track.h
> +++ b/arch/x86/include/asm/kvm_page_track.h
> @@ -26,14 +26,13 @@ struct kvm_page_track_notifier_node {
>  	 * It is called when guest is writing the write-tracked page
>  	 * and write emulation is finished at that time.
>  	 *
> -	 * @vcpu: the vcpu where the write access happened.
>  	 * @gpa: the physical address written by guest.
>  	 * @new: the data was written to the address.
>  	 * @bytes: the written length.
>  	 * @node: this node
>  	 */
> -	void (*track_write)(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new,
> -			    int bytes, struct kvm_page_track_notifier_node *node);
> +	void (*track_write)(gpa_t gpa, const u8 *new, int bytes,
> +			    struct kvm_page_track_notifier_node *node);
>  	/*
>  	 * It is called when memory slot is being moved or removed
>  	 * users can drop write-protection for the pages in that memory slot
> diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c
> index f39f190ad4ae..39a0863af8b4 100644
> --- a/arch/x86/kvm/mmu/page_track.c
> +++ b/arch/x86/kvm/mmu/page_track.c
> @@ -272,7 +272,7 @@ void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new,
>  	hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
>  				srcu_read_lock_held(&head->track_srcu))
>  		if (n->track_write)
> -			n->track_write(vcpu, gpa, new, bytes, n);
> +			n->track_write(gpa, new, bytes, n);
>  	srcu_read_unlock(&head->track_srcu, idx);
>  
>  	kvm_mmu_track_write(vcpu, gpa, new, bytes);
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 9824d075562e..292750dc819f 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -106,9 +106,8 @@ struct gvt_dma {
>  #define vfio_dev_to_vgpu(vfio_dev) \
>  	container_of((vfio_dev), struct intel_vgpu, vfio_device)
>  
> -static void kvmgt_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> -		const u8 *val, int len,
> -		struct kvm_page_track_notifier_node *node);
> +static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
> +				   struct kvm_page_track_notifier_node *node);
>  static void kvmgt_page_track_flush_slot(struct kvm *kvm,
>  		struct kvm_memory_slot *slot,
>  		struct kvm_page_track_notifier_node *node);
> @@ -1617,9 +1616,8 @@ int intel_gvt_page_track_remove(struct intel_vgpu *info, u64 gfn)
>  	return 0;
>  }
>  
> -static void kvmgt_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> -		const u8 *val, int len,
> -		struct kvm_page_track_notifier_node *node)
> +static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
> +				   struct kvm_page_track_notifier_node *node)
>  {
>  	struct intel_vgpu *info =
>  		container_of(node, struct intel_vgpu, track_node);
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>