From:   Kang Chen <void0red@gmail.com>
To:     horatiu.vultur@microchip.com
Cc:     borisp@nvidia.com, davem@davemloft.net,
        dirk.vandermerwe@netronome.com, edumazet@google.com,
        john.fastabend@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        pabeni@redhat.com, void0red@gmail.com
Subject: [PATCH net v2] net/tls: refine the branch condition in tls_dev_event
Date:   Fri, 17 Mar 2023 16:33:38 +0800
Message-Id: <20230317083338.1085194-1-void0red@gmail.com>
In-Reply-To: <20230317081513.ktllct3rqaisummm@soft-dev3-1>
References: <20230317081513.ktllct3rqaisummm@soft-dev3-1>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

dev->tlsdev_ops may be null and cause null pointer dereference later.

Fixes: eeb2efaf36c7 ("net/tls: generalize the resync callback")
Signed-off-by: Kang Chen <void0red@gmail.com>
---
v2 -> v1: simplify the condition

 net/tls/tls_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index a7cc4f9faac2..45b07162d062 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -1449,7 +1449,8 @@ static int tls_dev_event(struct notifier_block *this, unsigned long event,
 		if (netif_is_bond_master(dev))
 			return NOTIFY_DONE;
 		if ((dev->features & NETIF_F_HW_TLS_RX) &&
-		    !dev->tlsdev_ops->tls_dev_resync)
+		   (!dev->tlsdev_ops ||
+		    !dev->tlsdev_ops->tls_dev_resync))
 			return NOTIFY_BAD;
 
 		if  (dev->tlsdev_ops &&
-- 
2.34.1