Message-ID: <5077782b-334f-c292-2e06-450c203b8fdc@gmail.com>
Date:   Fri, 17 Mar 2023 10:44:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v4] mtd: spi-nor: fix memory leak when using
 debugfs_lookup()
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org
References: <20230208160230.2179905-1-gregkh@linuxfoundation.org>
 <f60870dee13900252e0b13fb2f5f05b5@walle.cc> <ZAWNtv0g6vmADGnb@kroah.com>
 <20230306093336.523832b0@xps-13> <ZAWuvRHVVV3hTm0e@kroah.com>
 <20230306120558.00f614fb@xps-13>
From:   Tudor Ambarus <tudor.ambarus@gmail.com>
In-Reply-To: <20230306120558.00f614fb@xps-13>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 06.03.2023 13:05, Miquel Raynal wrote:
> Hi Greg,
> 
> gregkh@linuxfoundation.org wrote on Mon, 6 Mar 2023 10:13:33 +0100:
> 
>> On Mon, Mar 06, 2023 at 09:33:36AM +0100, Miquel Raynal wrote:
>>> Hi Greg,
>>>
>>> gregkh@linuxfoundation.org wrote on Mon, 6 Mar 2023 07:52:38 +0100:
>>>   
>>>> On Wed, Feb 08, 2023 at 05:15:41PM +0100, Michael Walle wrote:  
>>>>> Am 2023-02-08 17:02, schrieb Greg Kroah-Hartman:    
>>>>>> When calling debugfs_lookup() the result must have dput() called on it,
>>>>>> otherwise the memory will leak over time.  To solve this, remove the
>>>>>> lookup and create the directory on the first device found, and then
>>>>>> remove it when the module is unloaded.
>>>>>>
>>>>>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>>>> Cc: Pratyush Yadav <pratyush@kernel.org>
>>>>>> Cc: Michael Walle <michael@walle.cc>
>>>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>>>> Cc: Richard Weinberger <richard@nod.at>
>>>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>>>> Cc: linux-mtd@lists.infradead.org
>>>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>    
>>>>>
>>>>> Reviewed-by: Michael Walle <michael@walle.cc>
>>>>>
>>>>> one nit below I didn't notice earlier, no need to send a new
>>>>> patch version just for that.
>>>>>
>>>>> ..
>>>>>     
>>>>>> +void spi_nor_debugfs_shutdown(void)
>>>>>> +{
>>>>>> +	if (rootdir)
>>>>>> +		debugfs_remove(rootdir);    
>>>>>
>>>>> debugfs_remove() already has a check for NULL.
>>>>>     
>>>>
>>>> Ah, good catch, I merged this in when I applied it to my tree, thanks!  
>>>
>>> Any reasons why you did apply this patch to your tree? It is a spi-nor
>>> fix, I would have expected it to go through mtd.  
>>
>> It's been sitting around for a month, I assumed it was lost, so I picked
>> it up.
> 
> Sorry if it took too long, the merge window also happened during that
> time, we are collecting patches now that 6.3-rc1 has been released.
> Next time don't hesitate to ping first ;-)
> 
>> I can revert it if you don't want me to take it for 6.3-final
>> through my driver core tree.
>

It's fine, I don't expect other changes on these chunks of code. Anyway,
if there will be merge conflicts I'll solve them locally by merging the
-rc containing the fix.

BTW, you forgot to cc stable and add a fixes tag :).

> I'll let spi-nor maintainers decide what they prefer.
> 

If it'll be a next time, a ping would be better.

Cheers,
ta