Date:   Fri, 17 Mar 2023 16:28:56 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>,
        <intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v2 25/27] KVM: x86/mmu: Drop @slot param from
 exported/external page-track APIs
Message-ID: <ZBQkyB3KJP34D9/h@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-26-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-26-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JiCRr08+1cSg4OpSxevUy5JEYeK/+NH6tbNqcKV+dijaaaUJ83hw4/nX0lhq?=
 =?us-ascii?Q?vl5FAIvveVeo3gnIESX2IreMF33iRDDH4OuHNEWGgw9Qp2WfEqL6Y4o7VBjG?=
 =?us-ascii?Q?1ERogJGhmE2mkn1bmYwWfv+240H9ciXYkoej907Uk+CWMHeUxXTCe481FJDc?=
 =?us-ascii?Q?xDNtYSdmXZkmTvZeOUmkMYyCPf/5oWQBb9WPULREwI8JKXV9R0Au+SsOFMFI?=
 =?us-ascii?Q?KRit9zRb6biDfJQ8iUX8C18uZAtEsX1NJDudu91jccSvM/hH4+RxKA5SU+ER?=
 =?us-ascii?Q?1ztONVVytV+hGmJVyeolc8y+4+ADvy4s0EXF65idieJDlMMAOuMoLRqU+7zQ?=
 =?us-ascii?Q?1rSRrGY9em+7R0ZzQ4axaLrj/zD9eMieycvcNzc3pR1PiHSB5R3WTLr7ZXhL?=
 =?us-ascii?Q?Ru81k3LoccB4sJrSFzAMhdxyPujMrqNLR5ZaZySm9s2Izq+AkiBGib+msw3U?=
 =?us-ascii?Q?/oddWqM1J7SiHLHVXG2H5TaHnWgd3Lk0dtvFc4n5bPOeLvXfibuwTST86Fms?=
 =?us-ascii?Q?iFjKjJ9HE+l6Bptw6IMmxajLKIvwzGsHJqVviuaT4hDJzqRH3hpxwdyJ24eL?=
 =?us-ascii?Q?Hymbvbp9aUmACx646YxiiYpSvi4PYeE2c0hhjCg12NWhwOtVTBLA6DceRbma?=
 =?us-ascii?Q?2KtLSalse9GS7LsVwg2Uhx14je9CRUnaaEota7EVkQEMeGr3W6xE+Elz5FQJ?=
 =?us-ascii?Q?B3ekN5lVrlfxhOckrfN1Q6Pml5fyWdkp9FskMukfZntzeNGoqHiFlkk7vLXi?=
 =?us-ascii?Q?SIAtDWoOm1YAZck1o2Kcq8uDgpoI1Xu+DIb0JanCehBv5Y7OcZ8xAx2+UvZD?=
 =?us-ascii?Q?CN6guln6Gm+nf8gTeVV07WnymmJEu3/k6JYp71tKgrQ/XgAhqqA4kA+0Yk0X?=
 =?us-ascii?Q?V2SMDgwJdT29uUoptgZq6dBAw9EpCHDTnSMFTrLls+McReeokRZgk6Lgb7z+?=
 =?us-ascii?Q?YsZ7S6Zk7GBAez6CS0g2P9EP8sVXFxrFvoKaA9RUjJKBX3fxt37pANdYfB10?=
 =?us-ascii?Q?lyIOmr/7K7U1uUjP1PnqgAGRlyJsJWnFwQUy3S072AZvXbDtY+ctlAnvI7/u?=
 =?us-ascii?Q?Xk81/fbqw0xZ0CXxk1Dao0Gcre/ke92eG0o5Xm1CRCSfJnIO3UFVezWhqJa1?=
 =?us-ascii?Q?hWKII5U0yoCY+RVWHt/y9Ij1aqsDgodhDfEkdTm4zeX+/TlWN7sCZmFkaWoN?=
 =?us-ascii?Q?caHU7A0jbtJkyujSRg9c/AzgB+tCvzscA12r2tOxWrYBV+reZRLNyYfWcyql?=
 =?us-ascii?Q?nGsMjynfE/NOlpyDHPkEzOPWUwzcgLuqqH+jzSRAj7076uWl03jNShIX/ieJ?=
 =?us-ascii?Q?pkT/iL4FgW7DfzPKvyvLYMNJXcbz1c0yPHDNQu19mE7PwkSu+G0p4Ie68Tbg?=
 =?us-ascii?Q?LxrhMNTzQt6CYE1XQhAbSP0b89T+B+ZeyVoV40PUbyFHulUIORrFrh/0xOfO?=
 =?us-ascii?Q?LdswcRB4u6pNjOiV8M2Bss3TRSs4SC7wU/POJNzJI7jbtcmpOcjYRd+TC+o0?=
 =?us-ascii?Q?urMZkolzOQ783S5WoaGIDGrT6d/6XI9kHtP+JD4O2Mio+QKz3Je5ANdHyyjl?=
 =?us-ascii?Q?f7PVL8MZRtSkViQAIYZBsFdtxtvFM/0ptQeijt3hhytyum3Bf/WsdKwWn09R?=
 =?us-ascii?Q?lg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c47aeaaa-055a-421e-c381-08db26c5173e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 08:53:34.5178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O9WqyYVZFt9dm9+dSMpzmG/sO6h29dVQl3dMjqrnWHHExQnCPRL4+43bkNwOeobXhpHWMyL+l7rnblc2r848vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7179
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 10, 2023 at 04:22:56PM -0800, Sean Christopherson wrote:
...
> +int kvm_write_track_add_gfn(struct kvm *kvm, gfn_t gfn)
> +{
> +	struct kvm_memory_slot *slot;
> +	int idx;
> +
> +	idx = srcu_read_lock(&kvm->srcu);
> +
> +	slot = gfn_to_memslot(kvm, gfn);
> +	if (!slot) {
> +		srcu_read_unlock(&kvm->srcu, idx);
> +		return -EINVAL;
> +	}
> +
Also fail if slot->flags & KVM_MEMSLOT_INVALID is true?
There should exist a window for external users to see an invalid slot
when a slot is about to get deleted/moved.
(It happens before MOVE is rejected in kvm_arch_prepare_memory_region()).

> +	write_lock(&kvm->mmu_lock);
> +	__kvm_write_track_add_gfn(kvm, slot, gfn);
> +	write_unlock(&kvm->mmu_lock);
> +
> +	srcu_read_unlock(&kvm->srcu, idx);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(kvm_write_track_add_gfn);
> +
> +/*
> + * remove the guest page from the tracking pool which stops the interception
> + * of corresponding access on that page.
> + *
> + * @kvm: the guest instance we are interested in.
> + * @gfn: the guest page.
> + */
> +int kvm_write_track_remove_gfn(struct kvm *kvm, gfn_t gfn)
> +{
> +	struct kvm_memory_slot *slot;
> +	int idx;
> +
> +	idx = srcu_read_lock(&kvm->srcu);
> +
> +	slot = gfn_to_memslot(kvm, gfn);
> +	if (!slot) {
> +		srcu_read_unlock(&kvm->srcu, idx);
> +		return -EINVAL;
> +	}
> +
Ditto.

> +	write_lock(&kvm->mmu_lock);
> +	__kvm_write_track_remove_gfn(kvm, slot, gfn);
> +	write_unlock(&kvm->mmu_lock);
> +
> +	srcu_read_unlock(&kvm->srcu, idx);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(kvm_write_track_remove_gfn);