Message-ID: <4f4dd491-e7f6-a963-c185-68521b262b22@ti.com>
Date:   Fri, 17 Mar 2023 14:25:14 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc:
 ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR
Content-Language: en-US
To:     Roger Quadros <rogerq@kernel.org>,
        MD Danish Anwar <danishanwar@ti.com>,
        "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Nishanth Menon <nm@ti.com>
CC:     <linux-remoteproc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        <srk@ti.com>, <devicetree@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <20230313111127.1229187-1-danishanwar@ti.com>
 <20230313111127.1229187-5-danishanwar@ti.com>
 <d168e7dd-42a0-b728-5c4c-e97209c13871@kernel.org>
 <b1409f34-86b5-14e8-f352-5032aa57ca46@ti.com>
 <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org>
 <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com>
 <e49b9a78-5e35-209e-7ecc-2333478b98b0@kernel.org>
 <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com>
 <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org>
 <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com>
 <d8776be3-75a2-02fd-3702-79169675e4f6@kernel.org>
From:   Md Danish Anwar <a0501179@ti.com>
Organization: Texas Instruments
In-Reply-To: <d8776be3-75a2-02fd-3702-79169675e4f6@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/03/23 14:01, Roger Quadros wrote:
> 
> 
> On 17/03/2023 07:02, Md Danish Anwar wrote:
>>
>>
>> On 16/03/23 19:34, Roger Quadros wrote:
>>>
>>> Hi,
>>>
>>> On 16/03/2023 15:11, Md Danish Anwar wrote:
>>>>
>>>>
>>>> On 16/03/23 17:49, Roger Quadros wrote:
>>>>>
>>>>>
>>>>> On 16/03/2023 13:44, Md Danish Anwar wrote:
>>>>>>
>>>>>> On 16/03/23 17:06, Roger Quadros wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 16/03/2023 13:05, Md Danish Anwar wrote:
>>>>>>>> Hi Roger,
>>>>>>>>
>>>>>>>> On 15/03/23 17:52, Roger Quadros wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote:
>>>>>>>>>> From: Suman Anna <s-anna@ti.com>
>>>
>>
>> [..]
>>
>>>> Sure, then I will use the existing enum pru_type.
>>>>
>>>> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this
>>>> enum definition from there to include/linux/remoteproc/pruss.h
>>>
>>> There are 2 public pruss.h files.
>>> 	include/linux/remoteproc/pruss.h
>>> and
>>> 	include/linux/pruss_driver.h
>>>
>>> Why is that and when to use what?
>>>
>>
>> The include/linux/remoteproc/pruss.h file was introduced in series [1] as a
>> public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c)
>>
>> The second header file include/linux/pruss_driver.h was introduced much earlier
>> as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs".
>>
>> As far as I can see, seems like pruss_driver.h was added as a public header
>> file for PRUSS platform driver (drivers/soc/ti/pruss.c)
>>
>> [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/
>> [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/
> 
> Thanks. "include/linux/remoteproc/pruss.h" seems appropriate for enum pru_type.
> 
> cheers,
> -roger

Yes, enum pru_type is located in pru_rproc.c, I will move enum pru_type to
include/linux/remoteproc/pruss.h and then include
include/linux/remoteproc/pruss.h" in pru_rproc.c and any other file that needs
this enum.

-- 
Thanks and Regards,
Danish.