Date:   Fri, 17 Mar 2023 16:58:52 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>, <kvm@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH v2 27/27] drm/i915/gvt: Drop final dependencies on KVM
 internal details
Message-ID: <ZBQrzFlsjTWylzGf@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230311002258.852397-1-seanjc@google.com>
 <20230311002258.852397-28-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230311002258.852397-28-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E8RVpR+BC0o4hm0PWzhcJqpEzK4Pf/7e5C7dAOUXSMRVsFO3uLWy3hfFNS4Z?=
 =?us-ascii?Q?nv3PZG7OIJh/MCVoJ3kBnuO8EpeBwfWCD8AyzFxb8EA3Ctd7KSv3dkhSe8Iv?=
 =?us-ascii?Q?Wj847D529v5oLXZ3J2qKRYcHX+RtDC81L9wOZBZhoF3nB/3SS1KgZzZuBJC/?=
 =?us-ascii?Q?QXU5FMs59OWJRNNG9EH3TCOoknFEUHcvIwaBiwKip4HeAFXxqov1iY8svJJV?=
 =?us-ascii?Q?PIu8DLp8ewE0CMqJMEGAirKhMC62GWe7JOQqsTLv5kgPfScsw4OPZ5FN2Oq1?=
 =?us-ascii?Q?6gg3Oephlo8pgu5zmjfh3DeG1INd5/eGRNzYUsZcDO40alwR33hG2XFw/UVU?=
 =?us-ascii?Q?ulnL1vZfy2gs9HcBT46Im8lJ5FCvTbIZJrBfnxK4ybOhQZ440ChiNafGMyyy?=
 =?us-ascii?Q?9Bc9wdK1dhhcNYWNqPaagpwZzBdRTRCu7tSGLiVKwBtuRzLEWeUw6OwbSq9E?=
 =?us-ascii?Q?E9Yw/qrzCZMAC7QGTqSTv3sCZMsWzqaRhrkeunAJth6u9xEDNbpE5iXSmvTO?=
 =?us-ascii?Q?pP72UA/nIjI607oxMJOjqNXyq0y2/TA4oxZCGoBdsPAO8K1njpp6qG0QJft8?=
 =?us-ascii?Q?SzWp5YNm2/ozBCb6z4E/sy1Ox5hbQyQoasuOUEOpShJHtpipVmOHrrnN3CP2?=
 =?us-ascii?Q?6SGZ7jKhZmwCYaxeIpA7p4vU6NYxLGjU0LkrU7XvXnbYeATvGRKtOWJDaquk?=
 =?us-ascii?Q?29tWsqQUB5IQk5uljMyimCCtvc6NwxmmMLVDMObXNYsvpfUlMDnlfdWGupD0?=
 =?us-ascii?Q?7VI9IqwYlVP89a1EqBUl37i9+DmeURusm9G6BtsEygt3XzSJURFTyaKsBZza?=
 =?us-ascii?Q?NWt0A4t2/ILyRYJT9f3IziRLX2Y1p9WqD0ybAeDzFP8/f5VkEeG4gBEbnLnQ?=
 =?us-ascii?Q?FzDy3CU6+7v09Pb06ToY/rJ9ShmSpRXV10rkFE8A2Dy7aKD2mx2HMoGfMHeB?=
 =?us-ascii?Q?2cJzBgOsRkLxlX1zH/umNHsCBjmx76p7x+ThZl2nGQCGKDyMa1WDYxM2D+Y2?=
 =?us-ascii?Q?jzQ5SrQ9dhemSDZ2Pv/XfeQQq5ooTYzALLr4eHDuyehNbBOZ8I99yvO7rNQz?=
 =?us-ascii?Q?sTbxqGc4wKypzDdvKC25GrG6XwXGzjE3dZBp33tQBoRcpChwI9lhpzA7vsAc?=
 =?us-ascii?Q?CYlmDBCwHNXh6w4JoSzH4pX53XNMT76mKpm/bKOs3tKrZyqi4bFvpWVPHEOs?=
 =?us-ascii?Q?jRrt9vLxVA9AWt3ENKLRL8XBeFOMjHOZJvOZofvk0OCI4jat0PLdSW1MCHX2?=
 =?us-ascii?Q?k5cBC12TUPcJHiSa6Zx3eQpaUpHAH3VOqHCPs6Ef8GMUDDArcriZQB/0c+Zz?=
 =?us-ascii?Q?B1Mpxagd3xlksCwg+7PgY3O0StfqvtPhNsCMnxP0ZUq8LUiI1xM0c1unYhBW?=
 =?us-ascii?Q?2WA3TfV9q4k53OE6eCYOecXMqBvReBijUMwTY0RmbUtMMk/K1q61wgILvToI?=
 =?us-ascii?Q?obRdXQfHQ386wlT18iZcJKa3ApXcJpgL+5n8WINtxoYH6Z8HzFdXeOCsHE31?=
 =?us-ascii?Q?ZmoTFE3JaqN/Of547SBEe/o4uIOsb7v/JopBkmvfNuuV8sGMVKDI9RqdHonU?=
 =?us-ascii?Q?INS72eGKAcyjDYTyaRSTAdfnoIEU6E8+zen0cdCexjPJ99Ynolva3PN7r+q3?=
 =?us-ascii?Q?tA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a029227-dfcc-4ee3-7fc5-08db26c94597
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 09:23:30.2926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KB1R4GiY69cPwyeh+j7quyirWoe6hnMslNKWbZkRiGV2FDByAoNO23UNsbVKpmL4YbykQUuREmM/SRe+IO9YBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6020
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>

On Fri, Mar 10, 2023 at 04:22:58PM -0800, Sean Christopherson wrote:
> Open code gpa_to_gfn() in kvmgt_page_track_write() and drop KVMGT's
> dependency on kvm_host.h, i.e. include only kvm_page_track.h.  KVMGT
> assumes "gfn == gpa >> PAGE_SHIFT" all over the place, including a few
> lines below in the same function with the same gpa, i.e. there's no
> reason to use KVM's helper for this one case.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  drivers/gpu/drm/i915/gvt/gvt.h   | 3 ++-
>  drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h
> index 2d65800d8e93..53a0a42a50db 100644
> --- a/drivers/gpu/drm/i915/gvt/gvt.h
> +++ b/drivers/gpu/drm/i915/gvt/gvt.h
> @@ -34,10 +34,11 @@
>  #define _GVT_H_
>  
>  #include <uapi/linux/pci_regs.h>
> -#include <linux/kvm_host.h>
>  #include <linux/vfio.h>
>  #include <linux/mdev.h>
>  
> +#include <asm/kvm_page_track.h>
> +
>  #include "i915_drv.h"
>  #include "intel_gvt.h"
>  
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index d16aced134b4..798d04481f03 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1599,7 +1599,7 @@ static void kvmgt_page_track_write(gpa_t gpa, const u8 *val, int len,
>  
>  	mutex_lock(&info->vgpu_lock);
>  
> -	if (kvmgt_gfn_is_write_protected(info, gpa_to_gfn(gpa)))
> +	if (kvmgt_gfn_is_write_protected(info, gpa >> PAGE_SHIFT))
>  		intel_vgpu_page_track_handler(info, gpa,
>  						     (void *)val, len);
>  
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>