Message-ID: <fc8b6ec1f05c1514b6ed5535e16c9c2d21efea86.camel@nxp.com>
Subject: Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper
 from appearing in 2 separate modules
From:   Liu Ying <victor.liu@nxp.com>
To:     Lee Jones <lee@kernel.org>, dri-devel@lists.freedesktop.org
Cc:     linux-kernel@vger.kernel.org,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org
Date:   Fri, 17 Mar 2023 17:42:21 +0800
In-Reply-To: <20230317081718.2650744-38-lee@kernel.org>
References: <20230317081718.2650744-1-lee@kernel.org>
         <20230317081718.2650744-38-lee@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clNqQzVHWGg1RXFCMG1YMnZEa3JDREM0V2NRQ2F6ckJqWm1vVjIzN0dpUUxI?=
 =?utf-8?B?Nk5VV1NGK044RExsaFlIcE9kTU0zVW4xZGJKcGZZaW85ZmZiNDBWaGNGRTZN?=
 =?utf-8?B?LzRnY3h0Y1I5OFZZNW1iUCt3V0VjNmZzbG55b2xuZVM1R3hIMGxTZnFITFhu?=
 =?utf-8?B?c0l1TFExVkU3WmpTanJNbFM5VVFUNGR5N0JsRitDQ2UrL2ViQkVMWGIreUNv?=
 =?utf-8?B?YmpHMG4wUVFVcmFTdC9aQWNVZ3JnK0syWkdlRUoxY2MxVUZWMzdYS2haMEpu?=
 =?utf-8?B?MWo3SjZtRWlyWnZlSytoZGdTQUJrU2dTY1BSaFdCa3ZvY3ZtZ00yS0x6eG1Z?=
 =?utf-8?B?RXBPQWg1STJ0cHlUbGVpZnZxaGVPc1JpRFdXcm9TakVQZzU5WDR6N0MrZFpS?=
 =?utf-8?B?ZnVvd2swRDhmRFBJSlNRMVZyMHhYVzRWRm9LbEEyWlBHY3NuTlZ3YjdxbTUy?=
 =?utf-8?B?N21KRUFYREc5Tmw3eVdRTXRGQnpJSS9FZHA1SVUvUWRNa3pDNlNSMkp6eVF1?=
 =?utf-8?B?aXVoUWorYmwyK05oM2lhZ1VvdnphYy9mcFhMK2JvaC9lMXEwWHV4MW9UMmF1?=
 =?utf-8?B?amZZTU1oOXEvRnZhNHZCbjBDRFROWVhnVzJyYWJKTDFQSndlMEVLU2x3aTZ6?=
 =?utf-8?B?cUp4T2FjR3RkQWFsNEZCLzhXbFhkRjdJUW1jdEd3RmJNMkFFczNpazFoMWdy?=
 =?utf-8?B?M3VzbXpILzh5T21qWHVPQ096aS9hSFExUVNicVkwMS9RT25zcmpLRW12VWQy?=
 =?utf-8?B?dERUOWJHK1RpY0JtRGcvZjFLZVdJV3RXUyt2VGRPeFpYeEs0Y3ZWNEVPdUkw?=
 =?utf-8?B?cnFVYlYxRFBKcTVPSFRDdC91RnU5cW42L04ya3ZobE5xT0tFcGN0U2hiczJN?=
 =?utf-8?B?ek9JSlRhdFhVN2JyL3FaeDhtREFMeGVDNStJYzE3Vk1zbTJjWTBiVThPSWpm?=
 =?utf-8?B?ck5xZU5CQWdFRkJUVDVkQklobnM0bjZmenY5MlkrN2xwWEt2VDc5LzErOWs0?=
 =?utf-8?B?N3hwZnNUK1ErdCt6MTg5NnNwM3JKUWhBSVJqQUNBUVVuSTJ6MzhZZmNiT1Qx?=
 =?utf-8?B?Z0pzejhyRFl4aFRwZ3J0ZVhwYnIwUmZObzJhbUxGR1laeHhYK3RnbGtoaVI2?=
 =?utf-8?B?U0pzY2RINE1aRTNEYzIvelFhcEpPa2dkdGJ2ZnkwVzlzM3VGWFBwSVJReURE?=
 =?utf-8?B?YnY0QkxoSEJwaG1tbXRqejE2T210eVNSYmNuSVpLMGgwYVRZWHVRME4vNlZi?=
 =?utf-8?B?cjVjQVM4RkV1Z0Mwem9PSGdSaG00b3YveGZMTW9MOEdpWWp3MGxxbG5idG1t?=
 =?utf-8?B?dDh2ZjVxSjNJeVVoL1M4ZkhMcUd3cDkzRVFHNWxrV0xMR1E5TVBzSjVMVlNl?=
 =?utf-8?B?RjF1Q2FmNnRFUDlZcWpPT0Rha0Y4ZzF0Z3lOWVIrZlV1T0xkZEFaUk9xSEoy?=
 =?utf-8?B?Tis4MCs2blFxUUdXNmdtdDdFcWxnemozblpoRTl5RmdQL2ppWnJHUjNEaEp1?=
 =?utf-8?B?Wk4yR3RpTGc4bGNpb3IxaDdlTmhrNXVNeTEvMzZZcEVud1g0amhCZmRPQ1E4?=
 =?utf-8?B?MlN1SU1xVTNRcVphQVNHcDdtOXFic29WUDA4NjBqNjd6elcvSUY1WU5oUXVF?=
 =?utf-8?B?eGRPSXRNTmkzZGNTcEpHY0NrU3R2QkJuUkk2WXhSbXNYRUxVcjNma1NYa3dH?=
 =?utf-8?B?L2pFRlJ2R1VacmVRclZmbURsL3hqMldmN3RaRktiUUsycHY1cEJnRE00Q0Y4?=
 =?utf-8?B?aDNnTi9QTUF3alh3NlRmWUlBRkNDLzhOQk0wOXdONnVMdUc4TS9TQlRCbTFB?=
 =?utf-8?B?Wlh2bVl2U0JVT0VwWkJNcTlyN0JSZ2JMU0RYWmRIZkhIQnRlVHRiUlNTTitP?=
 =?utf-8?B?a3hzZzh6Uk04cFEvWUd1cFdaQ3pFMEEvNVFUMDZQQzljUzd6eGtsR2xrdUFi?=
 =?utf-8?B?SFB2REJTdW92Mm9BdGwxTzgwRlUvaEFwODlZck5GRys4Y3NTYk9sM09xSUJE?=
 =?utf-8?B?N3lxTGhjYU9TMUFZV2JsaDFSdzZxSk1FMEZrelJWTVZQQnBlbTBYYXl0aHFS?=
 =?utf-8?B?bDg4M0FtcFg5YVhzSkMvaFNJcVBvZGJjVlRaeC96OE9XTGZXeFp3NnFGTE9T?=
 =?utf-8?Q?qohJseMb24gl3u2fQvckNSOmH?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e5d2bb-9154-4253-f38f-08db26cc0132
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 09:43:03.9607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /A81ZEzQkSrQfRBVG6OkNvzgzgMigZliM6K3JLV7Kj0O+gQU30eEpWdiGi6soVtNmG+1Qf6o0rA81TMr7PjFZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9136
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On Fri, 2023-03-17 at 08:17 +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb
> 
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee@kernel.org>

Thank you for the patch.

> ---
>  drivers/gpu/drm/bridge/imx/Kconfig          |  7 +++++++
>  drivers/gpu/drm/bridge/imx/Makefile         |  7 +++++--
>  drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 +++++++++++++
>  3 files changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig
> index 608f47f41bcd1..97018dcd078d0 100644
> --- a/drivers/gpu/drm/bridge/imx/Kconfig
> +++ b/drivers/gpu/drm/bridge/imx/Kconfig
> @@ -1,10 +1,16 @@
>  if ARCH_MXC || COMPILE_TEST
>  
> +config DRM_IMX8_LIB

I would limit this to i.MX LVDS Display Bridge(LDB) library, so I
suggest to use DRM_IMX_LDB_LIB.

> +	tristate
> +	help
> +	  Common helper functions used by some of the drivers below.

Considering to use DRM_IMX_LDB_LIB, help message can be a bit more
specific to LDB drivers, like:

Common helper functions used by i.MX LVDS display bridge drivers below.

Regards,
Liu Ying