Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EEBC76195 for ; Fri, 17 Mar 2023 10:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbjCQK3Q (ORCPT ); Fri, 17 Mar 2023 06:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229697AbjCQK3N (ORCPT ); Fri, 17 Mar 2023 06:29:13 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1F8A3253F; Fri, 17 Mar 2023 03:29:10 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id CE24924E1E4; Fri, 17 Mar 2023 18:29:07 +0800 (CST) Received: from EXMBX071.cuchost.com (172.16.6.81) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 17 Mar 2023 18:29:07 +0800 Received: from [192.168.125.108] (113.72.145.194) by EXMBX071.cuchost.com (172.16.6.81) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 17 Mar 2023 18:29:06 +0800 Message-ID: Date: Fri, 17 Mar 2023 18:29:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/5] dt-bindings: phy: Add StarFive JH7110 USB/PCIe document Content-Language: en-US To: Krzysztof Kozlowski , Emil Renner Berthing , Conor Dooley , "Vinod Koul" , Kishon Vijay Abraham I , "Rob Herring" , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel CC: , , , , , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20230315104411.73614-1-minda.chen@starfivetech.com> <20230315104411.73614-2-minda.chen@starfivetech.com> From: Minda Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.145.194] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX071.cuchost.com (172.16.6.81) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/17 16:39, Krzysztof Kozlowski wrote: > On 15/03/2023 11:44, Minda Chen wrote: >> Add StarFive JH7110 SoC USB 2.0/3.0 and PCIe 2.0 PHY dt-binding. >> PCIe 2.0 phy can use as USB 3.0 PHY. >> >> Signed-off-by: Minda Chen >> --- >> .../phy/starfive,jh7110-usb-pcie-phy.yaml | 62 +++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml >> new file mode 100644 >> index 000000000000..aa1c3fe93100 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml >> @@ -0,0 +1,62 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-usb-pcie-phy.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive USB 2.0 and PCIe 2.0 PHY >> + >> +maintainers: >> + - Minda Chen >> + >> +properties: >> + compatible: >> + enum: >> + - starfive,jh7110-usb-phy >> + - starfive,jh7110-pcie-phy >> + >> + reg: >> + maxItems: 1 >> + >> + "#phy-cells": >> + const: 0 >> + >> + clocks: >> + items: >> + - description: usb 125m clock >> + - description: app 125m clock >> + >> + clock-names: >> + items: >> + - const: 125m >> + - const: app_125 >> + >> +required: >> + - compatible >> + - reg >> + - "#phy-cells" >> + > > It seems pci phy does not take these clocks, thus you should have > allOf:if:then which will customize it per variant. Otherwise binding is > incorrect for the pci. > ok >> +additionalProperties: false >> + >> +examples: >> + - | >> + phy@10200000 { >> + compatible = "starfive,jh7110-usb-phy"; >> + reg = <0x10200000 0x10000>; >> + clocks = <&syscrg 95>, >> + <&stgcrg 6>; >> + clock-names = "125m", "app_125"; >> + #phy-cells = <0>; >> + }; >> + >> + phy@10210000 { >> + compatible = "starfive,jh7110-pcie-phy"; >> + reg = <0x10210000 0x10000>; >> + #phy-cells = <0>; >> + }; >> + >> + phy@10220000 { >> + compatible = "starfive,jh7110-pcie-phy"; >> + reg = <0x10220000 0x10000>; >> + #phy-cells = <0>; >> + }; > > Drop duplicated examples. Keep usb and maybe one phy. > ok, thanks > Best regards, > Krzysztof >