Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <2e80d283-b1ff-3648-9cae-47037cfe799d@roeck-us.net>
Date:   Fri, 17 Mar 2023 05:18:25 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions
Content-Language: en-US
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Yu Zhe <yuzhe@nfschina.com>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, liqiong@nfschina.com
References: <20230316082338.18388-1-yuzhe@nfschina.com>
 <ZBRPDz4vn0x8hzd0@kuha.fi.intel.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <ZBRPDz4vn0x8hzd0@kuha.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/17/23 04:29, Heikki Krogerus wrote:
> On Thu, Mar 16, 2023 at 04:23:38PM +0800, Yu Zhe wrote:
>> Pointer variables of void * type do not require type cast.
>>
>> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> 
> I would have prefered that both drivers are patched separately in
> their own patch, but that's minor. If Guenter is OK with this then:
> 
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 

I seem to have missed the original patch. Anyway, lgtm

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

And, yes, those should really have been separate patches, one per driver.

Guenter

>> ---
>>   drivers/usb/typec/tcpm/fusb302.c | 2 +-
>>   drivers/usb/typec/tcpm/tcpm.c    | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
>> index 1ffce00d94b4..4b7b8f6af3ca 100644
>> --- a/drivers/usb/typec/tcpm/fusb302.c
>> +++ b/drivers/usb/typec/tcpm/fusb302.c
>> @@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>>   
>>   static int fusb302_debug_show(struct seq_file *s, void *v)
>>   {
>> -	struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
>> +	struct fusb302_chip *chip = s->private;
>>   	int tail;
>>   
>>   	mutex_lock(&chip->logbuffer_lock);
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
>> index a0d943d78580..e8bfe3f57ab4 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
>>   
>>   static int tcpm_debug_show(struct seq_file *s, void *v)
>>   {
>> -	struct tcpm_port *port = (struct tcpm_port *)s->private;
>> +	struct tcpm_port *port = s->private;
>>   	int tail;
>>   
>>   	mutex_lock(&port->logbuffer_lock);
>> -- 
>> 2.11.0
>