Date:   Fri, 17 Mar 2023 13:32:53 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Jochen Henneberg <jh@henneberg-systemdesign.com>
CC:     <netdev@vger.kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "Ong Boon Leong" <boon.leong.ong@intel.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net V2 1/2] net: stmmac: Premature loop termination check
 was ignored on rx
Message-ID: <ZBRd9Wi1I8KQCpYZ@nimitz>
References: <20230316075940.695583-1-jh@henneberg-systemdesign.com>
 <20230316075940.695583-2-jh@henneberg-systemdesign.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230316075940.695583-2-jh@henneberg-systemdesign.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uZOk8ZdbFXjnL9hD8bgrT+76XLRFAp4Vpy9K6niaRvZBB1LLotrq+n8/COxA?=
 =?us-ascii?Q?8kg1qV4PmH76KSJFOJyXzp8opQBJ6mubnjunhUh8S+Qlj7uw153WootdrPOo?=
 =?us-ascii?Q?S1O3sOWpdcQcaxH02WDzA9Y84vU3lnZ3AuA063+kmugGziynZxWcBaDdiUSO?=
 =?us-ascii?Q?Bu9EsXX6P2n8x7OIQGsm8duyMtDNy/c6+wbAfcBLpMzIiAW5ADszdIrj4rJY?=
 =?us-ascii?Q?Kck/Z8QA02vFJ7p1YBBtqr4NEbnr3Se1Tf3+DsRnCelnXEkwBZyfXzYEL1fK?=
 =?us-ascii?Q?8A57MmW4EV0d3GI4lrjbt/wimQuLIB1m/GNiyWpeYSJVHVHH98zaxyIp/pQo?=
 =?us-ascii?Q?92otx+wPrBNDplqwG5B9kaTtW1o0pVT2UFp+FhRbFBSI+npTnJOzgNsD262G?=
 =?us-ascii?Q?ot0OIiyzw/VMRwAf09hUJ6kolmzOWoj9ndGV7YWVxFDQ3CGjr4kE/xkgqqkK?=
 =?us-ascii?Q?dGfi4ttuI+funNg7p1usgGF6vbfqMJQf9Wp8g/lyUyC++quWpErook6UgJCr?=
 =?us-ascii?Q?/KJFSnAhD7lV7O0v91rv13wE9MFw5uosxDWLfDsxPEkUPCw8xV9OpKNTH8vg?=
 =?us-ascii?Q?nDRiujMFBBjYhUrbwiTtwTL4RuTHilnBPaP1Zm5hrHlDExvLI/TgZn/bqMnc?=
 =?us-ascii?Q?5c8v5vv010gOpKAhlRLg0FK7PyrWEzd5/mAbKuaXmHFVmrtq7o755U2P3qFc?=
 =?us-ascii?Q?QEWIultM5p7EowIHpVYjSf5RanTVXEbRUnqgR2r0na1klZlviAs3nw+EguK+?=
 =?us-ascii?Q?MCz6mLtzwmcFWu18TPZONVAvE/UeoboLJSl6wfrgJakcveZOuTUsMy/cYJja?=
 =?us-ascii?Q?CcTxUUbGgqdUI5ODK3CzGPALAUZkyyNwJRYFRcBATAlKtlXY0+zf7Dkfutsj?=
 =?us-ascii?Q?zXH6bhHr39IPEuLwfZBiDBsqxUhuhrWC+FlM/du/94/fdcl0yxKbH4T9bxqm?=
 =?us-ascii?Q?j7r3oppP4ZejmxnbOR1wAB38O6hqTZ3fGbI5Q3r3Kixh5r4ZLjcaBUIu2cP4?=
 =?us-ascii?Q?zqxouKCO5Z8dN3x3INLDbjF2SqrWsUy1y+DJhseI+gd4/NWvzIW4P2ERYhAB?=
 =?us-ascii?Q?VQ20EfsAsTOWJGvxCfcaXx+evud6XomdcAo8mHdoEXhoa6eSWyMLg8UxGeqy?=
 =?us-ascii?Q?nMN0rnZE8TcGPu9GCbys32/BhN/eU0VEvCZaylDgGyyx1r/cEp/TTsLR9TOC?=
 =?us-ascii?Q?QmR9Gp6JRCDX5caX2Ezz/S8Hsl+xfkxYwTuiZ61jOyMX24sSNrMo1Lx5HJix?=
 =?us-ascii?Q?1dRlJfbYbLpSzcikM5HNKY8CxIu2J4GTYXYu0MXVwWumjHKGBpn6CJ6VMjBb?=
 =?us-ascii?Q?euyixLSs9KV2QN8iLTg97jfCKrWAwKOsJ63CbQiMpSxeUo+6+UOa4JEZIdwg?=
 =?us-ascii?Q?1er24ayF6R4SLd/PmXsXWEjX7Qso1rrU6hb9oIzC0gLZunZ8/qLSB8qt2Yh8?=
 =?us-ascii?Q?hoeB180lmTU0soxniuxF6fNWm1QV/VzZoJHsgBBvgeCz0AWt/GhjKhDvW0B0?=
 =?us-ascii?Q?j/1qkPQRVR9exEGnIwPkuP19JnSyMdCGeKHLYVCzkdN2vf66QbhfkIurftCz?=
 =?us-ascii?Q?rlDF4wTy5eSEthaDffsAEezo5H9NMT+ufD0U+cA/sRoxQN0MPNrXsHghrH0e?=
 =?us-ascii?Q?Yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e80997d1-7874-4108-9450-08db26e3bba5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 12:32:55.2554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q1+nLFRQZdinJ+y68+7NsScYMoVv2/xdXCD/hd9zAKO2TLTck7xeu+gqSG07DJGOj4CQ3dp0LX3O/9QJsZhpClPidRIuFcLyTdV/tAnYPWI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7086
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 16, 2023 at 08:59:39AM +0100, Jochen Henneberg wrote:
> The premature loop termination check makes sense only in case of the
> jump to read_again where the count may have been updated. But
> read_again did not include the check.
> 
> Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support")
> Signed-off-by: Jochen Henneberg <jh@henneberg-systemdesign.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e4902a7bb61e..ea51c7c93101 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
>  			len = 0;
>  		}
>  
> +read_again:
>  		if (count >= limit)
>  			break;
>  
> -read_again:
>  		buf1_len = 0;
>  		buf2_len = 0;
>  		entry = next_entry;
> -- 
> 2.39.2
> 
LGTM, thanks.
Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>