From:   Nathan Lynch <nathanl@linux.ibm.com>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     cocci@inria.fr, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Paul Moore <paul@paul-moore.com>
Subject: Re: [PATCH] powerpc/pseries: Fix exception handling in
 pSeries_reconfig_add_node()
In-Reply-To: <0981dc33-95d0-4a1b-51d9-168907da99e6@web.de>
References: <f9303bdc-b1a7-be5e-56c6-dfa8232b8b55@web.de>
 <0981dc33-95d0-4a1b-51d9-168907da99e6@web.de>
Date:   Fri, 17 Mar 2023 08:11:35 -0500
Message-ID: <871qln8quw.fsf@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Markus Elfring <Markus.Elfring@web.de> writes:
>
> The label =E2=80=9Cout_err=E2=80=9D was used to jump to another pointer c=
heck despite of
> the detail in the implementation of the function =E2=80=9CpSeries_reconfi=
g_add_node=E2=80=9D
> that it was determined already that the corresponding variable contained
> a null pointer (because of a failed function call in two cases).
>
> 1. Thus return directly after a call of the function =E2=80=9Ckzalloc=E2=
=80=9D failed.
>
> 2. Use more appropriate labels instead.
>
> 3. Delete a redundant check.
>
> 4. Omit an explicit initialisation for the local variable =E2=80=9Cerr=E2=
=80=9D.
>
> This issue was detected by using the Coccinelle software.

Is there a correctness or safety issue here? The subject uses the word
"fix" but the commit message doesn't seem to identify one.

Can you share how Coccinelle is being invoked and its output?