Date:   Fri, 17 Mar 2023 14:34:35 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Michal Kubiak <michal.kubiak@intel.com>
Cc:     Christian Marangi <ansuelsmth@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, Lee Jones <lee@kernel.org>,
        linux-leds@vger.kernel.org
Subject: Re: [net-next PATCH v4 02/14] net: dsa: qca8k: add LEDs basic support
Message-ID: <1c84a42a-2691-4ee9-bbe3-dc8e65fc31b1@lunn.ch>
References: <20230317023125.486-1-ansuelsmth@gmail.com>
 <20230317023125.486-3-ansuelsmth@gmail.com>
 <ZBRN563Zw9Z28aET@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBRN563Zw9Z28aET@localhost.localdomain>
Precedence: bulk

> (I guess the LED configuration i only makes sense for non-CPU ports? It
> seems you want to configure up to 15 LEDs in total for 5 ports).

Hi Michal

In the general case, there is no reason that i can think that stops
the CPU port having LEDs. For many switch designs, there is no
specific CPU port, any can be used. And all ports are likely to have
an LED controller.

What becomes tricky with Linux is offloading blinking to CPU ports.
There is no netdev to represent it, hence no netdev based software
blinking. And without software blinking, you have nothing to offload
to hardware. But you could still use the LEDs for other things.

Having said all that, i don't think i have ever seen a box with LEDs
for the CPU port.

    Andrew