Feedback-ID: ibe194615:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-221-gec32977366-fm-20230306.001-gec329773
Mime-Version: 1.0
Message-Id: <d4fcab71-1381-4f71-90c6-8a51b0284d3b@app.fastmail.com>
In-Reply-To: <ce7d4c80-a0cb-0f50-f0b4-1dd2a89fe096@redhat.com>
References: <20230312-think-lmi-status-v1-1-4e9f36322cc4@weissschuh.net>
 <ce7d4c80-a0cb-0f50-f0b4-1dd2a89fe096@redhat.com>
Date:   Fri, 17 Mar 2023 09:33:41 -0400
From:   "Mark Pearson" <mpearson-lenovo@squebb.ca>
To:     "Hans de Goede" <hdegoede@redhat.com>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        "Mark Pearson" <markpearson@lenovo.com>,
        "markgross@kernel.org" <markgross@kernel.org>
Cc:     "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: think-lmi: Properly interpret return value of
 tlmi_setting
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Tested on a couple of my platforms - all looked good.

Tested-by: mpearson-lenovo@squebb.ca

Mark

On Thu, Mar 16, 2023, at 10:44 AM, Hans de Goede wrote:
> Hi,
>
> On 3/12/23 04:47, Thomas Wei=C3=9Fschuh wrote:
>> The return value of tlmi_settings() is an errorcode, not an acpi_stat=
us.
>>=20
>> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
>
> Thank you for your patch, I've applied this patch to my review-hans=20
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers=
-x86.git/log/?h=3Dreview-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
>
> Regards,
>
> Hans
>
>
>> ---
>>=20
>> Note: This is only compile-tested.
>> ---
>>  drivers/platform/x86/think-lmi.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>=20
>> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/=
think-lmi.c
>> index 86b33b74519b..c924e9e4a6a5 100644
>> --- a/drivers/platform/x86/think-lmi.c
>> +++ b/drivers/platform/x86/think-lmi.c
>> @@ -1353,7 +1353,6 @@ static struct tlmi_pwd_setting *tlmi_create_aut=
h(const char *pwd_type,
>> =20
>>  static int tlmi_analyze(void)
>>  {
>> -	acpi_status status;
>>  	int i, ret;
>> =20
>>  	if (wmi_has_guid(LENOVO_SET_BIOS_SETTINGS_GUID) &&
>> @@ -1390,8 +1389,8 @@ static int tlmi_analyze(void)
>>  		char *p;
>> =20
>>  		tlmi_priv.setting[i] =3D NULL;
>> -		status =3D tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);
>> -		if (ACPI_FAILURE(status))
>> +		ret =3D tlmi_setting(i, &item, LENOVO_BIOS_SETTING_GUID);
>> +		if (ret)
>>  			break;
>>  		if (!item)
>>  			break;
>>=20
>> ---
>> base-commit: 81ff855485a366a391dc3aed3942715e676ed132
>> change-id: 20230312-think-lmi-status-0d76cbe1b7d9
>>=20
>> Best regards,