Message-ID: <244270ae-c976-599d-6c72-f19e008ba5b4@intel.com>
Date:   Fri, 17 Mar 2023 14:36:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH bpf-next v3 3/4] xdp: recycle Page Pool backed skbs built
 from XDP frames
Content-Language: en-US
To:     Jesper Dangaard Brouer <jbrouer@redhat.com>
CC:     <brouer@redhat.com>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Menglong Dong <imagedong@tencent.com>,
        "Mykola Lysenko" <mykolal@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Freysteinn Alfredsson <Freysteinn.Alfredsson@kau.se>
References: <20230313215553.1045175-1-aleksander.lobakin@intel.com>
 <20230313215553.1045175-4-aleksander.lobakin@intel.com>
 <11e480dd-7969-7b58-440e-3207b98d0ac5@redhat.com>
 <85d803a2-a315-809a-5eff-13892aff5401@intel.com>
 <0377c85c-5d59-49e5-017f-212821849a18@redhat.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <0377c85c-5d59-49e5-017f-212821849a18@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDhSdnpDd1lGNWs4RDdOdXAyekxucG54ckJ4UHJYaG9taVIwbUhldUZsYTd1?=
 =?utf-8?B?OHpjSjJMNjFWRmZoV3NCdEd3TGRmc2hsQUtWN2tYZk5PRmxCYnhOaytWcGdp?=
 =?utf-8?B?RGFKQjlNa2NEQWIyUHhGZjRIU0xhTU41QjgxM0RqVnBxeHFRMnpoNytNS0ZI?=
 =?utf-8?B?LzQzcUtMdm11Mm16a0RsamNpZUx4SGs4RU9zRTBVS3YyZTkxd3c3RXBRVDNh?=
 =?utf-8?B?WVdTVnVQTDEyeWhseEJ3R1ZzaGVEbHcwSzdpVmdXZkJGSDRUcVIrQlZXR3U4?=
 =?utf-8?B?TElkUllhcU5UMERHeXEvakRaNmJYM0RvRzhCTWNNV3N5RFdtMjZ2RUk0dkRz?=
 =?utf-8?B?eEt4N1dRdXZ1S2hES2RWNEFEb0xVWHhBa3RUZ2FVemlQalNXR1VHRmVuZEpZ?=
 =?utf-8?B?ZUsrUVJGSjlqMHVqZ3BhNElqTmF1RFo1V0Z2NXE4L3lkalBLTEtyR0trd1d3?=
 =?utf-8?B?TGRkNXk1aWhKQkJMV05wUm4xVEVzd3o4RFJyUiszSWxUWEZDZlJwQWhjWlRn?=
 =?utf-8?B?OHYydHlyNDhvYjRLdWtUT3FnNjh6eHNjOHAvaGVBdW80ZzRPNUtzcFFUT3BC?=
 =?utf-8?B?T3h4cEVEMU9iLzdXYXlNSk1lZWRlemU2eU9EM1hIeGt5clpCbndCK2R6M081?=
 =?utf-8?B?Q2ZNQ005RnBETE44Zy9pNTllUEgwM1A0QlFyOVZzcEtURTluejlYRWdoN21r?=
 =?utf-8?B?NG1GZUZFWXFHRkRVM1NlK3Z4bVpaWHFsdDhHZTErTFpmVE9LQ29wcGxWNXdW?=
 =?utf-8?B?b0VIQ3o1N05XdmhlelF0bmJuWVRJSkxWeUlCSS93WFBEeVR4RktVMGRhSDZV?=
 =?utf-8?B?RTl5UEZKK290K1JWZ09aaVdURkw4SjJjS2ZzeXNtV0RkRjRDbzhtVXVIbWxt?=
 =?utf-8?B?NmgyMmRmR3dQOW53d1Rxd01DdkhmZjJ4ODdZSEJ0Q20wdTVsbkdtVmZjQmd6?=
 =?utf-8?B?bUZTLzFOTWt6YnBqOVQ0TkViaW1iWFlkcXpNVUVhNWRqOE9wYmx1V2RNRTRh?=
 =?utf-8?B?U0lpZUszU3hiN2tOcXYwUXIxSE9vUFgwNGVranlmanNWTERuR0hVc0RINkx4?=
 =?utf-8?B?QkVHTnd4dFQ0ZHpvZjlqQnZGQndweE9rak00ZTExeFFKTjcwREdnT2JRYkxC?=
 =?utf-8?B?NmpGcTYyUEpKRTdpNFNVeUlHMkZTeDFwS2h6TXEwbTM5OFFGUUpwM0FlSnZk?=
 =?utf-8?B?ODdldkZFOVBkblprMVNPbDhhSDA2SGxzaEhvQmdnRnZpVGZmQ1BIWVJEUDRE?=
 =?utf-8?B?VS9JUUR3VEhIZjBTdUpzQTRGWURnSFdRQnArWTBUYnEyeldVaXF6cER5L1lC?=
 =?utf-8?B?bzg0UWNzc0oxY1lldlkxSU1VdGZwVCthSGJneEJtZmJTUk01bzB1UTV4YjhE?=
 =?utf-8?B?bTBmSXR1WEVGWVlNNCtYdlBFUFJEVzB1cWt2SVdha2VwWEtMYk9zcitDMWYr?=
 =?utf-8?B?MHkzdUpIVjhOS0VLL09HWjVLK0hFMnJXZERTbjR2RmpwSDJQbDIxdlI3b1NK?=
 =?utf-8?B?eHdyV3FiVXZQYTlKekN3TTNzeHZ3cVJOazBJRzgrdzIzYWZsSnBiWDRYM2tj?=
 =?utf-8?B?K2VjMjRMTXFielhjWFZjWGxEbjdqeThlRGs0V21yd251bENKeGdPc0w4UDk0?=
 =?utf-8?B?dlJ4TWI2T0t2ZE1OcU1QcENONkNQSm80ZHBZYzdMQWlqeDB4WW9wN3BGejJx?=
 =?utf-8?B?UmJObGF5VGhhR09EMWNYckVMelRuVjFmWGhPcTFCZzdrNzBMbVlZUjFYRVFV?=
 =?utf-8?B?eWM4RWFta25oelJUQUxSa1hsU3o2dEZreWRramxPYXpWaURTVXZQeGFYTVBu?=
 =?utf-8?B?QlE1c05WdVpCL095eS9uK0t2bFZXSnVONVZPekVHK1lWRWxQdTMwaVp4YzlZ?=
 =?utf-8?B?T2ZENnN4dU13dERGdTVBMDlJeWVIb241RCt6eThWZEpSdVQ0NndtQjVUdlRj?=
 =?utf-8?B?RkUvQkJVR0JhZXI2V1k2aGNSOERqZEdSL2x0VUR6eXdCQWEvTTI1S2RxY2l5?=
 =?utf-8?B?VW9VblRIdGJJcWg4cnVON1BhZVF0NTlUZ3h1MlBBVUhDVXFYdDFXbzBTN0E1?=
 =?utf-8?B?TDZlYk0zZ2EvaWpHVDRVVjJObDdramU1L01PSXpSS2x1NklNdnA3WXpMOE9Z?=
 =?utf-8?B?YkdxZE1CUHcyTXU1NnRoRURCZjVSSXZ1UXRUTlhSQTNnL0d3bDYvdTZFUFNE?=
 =?utf-8?Q?Dw5eBD3YPNhhFRCStTaL4lA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0842a30-2e0c-437b-d530-08db26ecc478
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 13:37:35.6572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7r6ZvEX2t8ZFWe3nc2F5+wRRCBXwqgP+fVabNow7xtAg8QDfqyGnifmxH+ltvn1Hg4XrewD1bvb+mUyZQ8HT0etR4e5Ng8kWdRdvW0zxL1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7182
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jesper Dangaard Brouer <jbrouer@redhat.com>
Date: Thu, 16 Mar 2023 18:10:26 +0100

> 
> On 15/03/2023 15.58, Alexander Lobakin wrote:
>> From: Jesper Dangaard Brouer <jbrouer@redhat.com>
>> Date: Wed, 15 Mar 2023 15:55:44 +0100

[...]

> Thanks for signing up for fixing these issues down-the-road :-)

At some point, I wasn't sure which commit tags to put to Fixes:. Like,
from one PoV, it's not my patch which introduced them. From the other
side, there was no chance to have 0x42 overwritten in the metadata
during the selftest before that switch and no one could even predict it
(I didn't expect XDP_PASS frames from the test_run to reach neigh xmit
at all), so the original code is not buggy itself as well ._.

> 
> For what is it worth, I've rebased to include this patchset on my
> testlab.
> 
> For now, I've tested mlx5 with cpumap redirect and net stack processing,
> everything seems to be working nicely. When disabling GRO/GRO, then the
> cpumap get same and sometimes better TCP throughput performance,
> even-though checksum have to be done in software. (Hopefully we can soon
> close the missing HW checksum gap with XDP-hints).

Yeah I'm also looking forward to having some hints being passed to
cpumap/veth, so that __xdp_build_skb_from_frame() could consume it. So
that I could pick a bunch of patches from my RFC back to switch cpumap
to GRO finally :D

> 
> --Jesper
> 

Thanks,
Olek