Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D97AC7618E for ; Fri, 17 Mar 2023 13:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjCQNoK (ORCPT ); Fri, 17 Mar 2023 09:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbjCQNoG (ORCPT ); Fri, 17 Mar 2023 09:44:06 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FDEB26B1; Fri, 17 Mar 2023 06:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679060645; x=1710596645; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YnswIAVSAKSWgRwAObgdrkxFmz81bo8K0xCi5ASID54=; b=eglB+EvjOmy3hyWEaA9GTGixTHo1qjw1IteoZgku6Obh8k/h65v0kyr1 VaZbW0cw17gkwrnhbJlFEy9TON77QQzDzpG9socn+Z7+IxRO5ui07HwrA NGlTdsV2s8TUyjcVUhPmy2pvCHN9M8FFyTw7INS9hNcs/8qPlIooSLQxK g8DaYS7z5iB50MaALKSwekNpqd4WqPOP7hVrMEmx9K+cifX+wfppYcX4E jh489ajAGhT9/eXgfS2N3Ys7NtTOyLg10ZT2hCEcCa9tdFwnKmOGCqi7k nXaoacfTuYHj8NtxNbbOie0ialvzUQgH3Oh+ovC0mYptK9vzGHlEe7U+w w==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="318659214" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="318659214" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 06:44:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="680291092" X-IronPort-AV: E=Sophos;i="5.98,268,1673942400"; d="scan'208";a="680291092" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 17 Mar 2023 06:43:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pdAN9-0053qv-2j; Fri, 17 Mar 2023 15:43:55 +0200 Date: Fri, 17 Mar 2023 15:43:55 +0200 From: Andy Shevchenko To: Tomi Valkeinen Cc: Luca Ceresoli , Wolfram Sang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Matti Vaittinen , Laurent Pinchart , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut , Satish Nagireddy , Luca Ceresoli Subject: Re: [PATCH v10 1/8] i2c: add I2C Address Translator (ATR) support Message-ID: References: <20230222132907.594690-1-tomi.valkeinen@ideasonboard.com> <20230222132907.594690-2-tomi.valkeinen@ideasonboard.com> <20230317101606.69602bba@booty> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2023 at 02:36:25PM +0200, Tomi Valkeinen wrote: > On 17/03/2023 11:16, Luca Ceresoli wrote: > > On Wed, 22 Feb 2023 15:29:00 +0200 > > Tomi Valkeinen wrote: ... > > > + /* lock for the I2C bus segment (see struct i2c_lock_operations) */ > > > > This comment is identical to the one in the kerneldoc comments just > > above, I'd just remove it. > > checkpatch wants an explicit comment for each lock. Checkpatch is a recommendation tool and not obligation. What it does correctly is sending message that lock should be described. The kernel doc is good format for that, checkpatch has to gain support for this type of lock descriptions. > > > + struct mutex lock; -- With Best Regards, Andy Shevchenko