Date:   Fri, 17 Mar 2023 15:01:00 +0100
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Christian Marangi <ansuelsmth@gmail.com>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        John Crispin <john@phrozen.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>, "Lee Jones" <lee@kernel.org>,
        <linux-leds@vger.kernel.org>
Subject: Re: [net-next PATCH v4 05/14] net: phy: phy_device: Call into the
 PHY driver to set LED brightness
Message-ID: <ZBRynEEAefKZcVgS@localhost.localdomain>
References: <20230317023125.486-1-ansuelsmth@gmail.com>
 <20230317023125.486-6-ansuelsmth@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230317023125.486-6-ansuelsmth@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CDsOTAHe/8J6Dsyum4sur2QNyYUEhUfR+G54mvwn/7mIyRrv8rwrPb7Hl9un?=
 =?us-ascii?Q?dgFo1tMbyl5TiC4/A0DqCOG0yCpZ2FKi8GI7HEQqKEaqQ3Voln+tdZhHbZ3T?=
 =?us-ascii?Q?zT7KSD9/04oWSVdAp1Kp3Wq90YBFVrPTWKABfRwjKBe6UirZZgT+XJIqNBjv?=
 =?us-ascii?Q?lV0K2fJ8kzDYYqHLrfUQ28J21o791U2EnDvDNj+7dVaMcavXonHIrcnoUFnl?=
 =?us-ascii?Q?14bpGVcK07d3ke/ey/ECcQFaYODTTqNbhLi0k9NQNS6rIFgtFZDMupqPMzwR?=
 =?us-ascii?Q?NXj6M+QW++w8iz8QCkHR93Ig7B6bADG+NY50iDnJIMXccqo1FM8zc3nFl0Ss?=
 =?us-ascii?Q?ejfyNXKG/26GHNO9QpuPFTun0hHGH6NBf/C6qDoslfKjkZCQdFJSRXSBJyfk?=
 =?us-ascii?Q?+aHP6qjGZye0++WjcpVyr+qlP2mqHMQerIFIRqoPHleXjPsJQOT+Hq9Sipov?=
 =?us-ascii?Q?rKJqL8uJ25ratzqOncjF0sqtSLhNLT5ZUCJdNSZiCU/nY3yv6leg3xRWlAkJ?=
 =?us-ascii?Q?4EhMDrolypC/PNRZ3BVlt0jeVE4bF+AwROOlfBHU8j2IPTlCET+IQE7wvbNx?=
 =?us-ascii?Q?C1VCiSrOguD0x+uKSMsUvv9gPQSK1BA2Lu8XQx+kOGOEFhJEu+BGtwfiKqAa?=
 =?us-ascii?Q?hmkMizZqz4y6h5QuMLkerq2mAaxYR23bG3Ikj/KXdq1W+4WghrqnM+7/eRBe?=
 =?us-ascii?Q?02N2TD2OHNw0214sQDKZdgXcU3/BXSUEwvx7PKsQZN8nK9+3gOtbey1SoD8V?=
 =?us-ascii?Q?MnuYrVhDU/qP37wj8rCpLBIVFgpz2Po9Un8G4WBWA3qIRuT4O4Y49Aqp7Fpz?=
 =?us-ascii?Q?4FQKegjflK2FiqaTVndA2WeGkxkDaEsnXWjYcnaoGZmAa943dYJK4dwH26dK?=
 =?us-ascii?Q?JaYefCXhcwKKvRAGUSBo+TJCvsfLAwxGAMTFL/TuPZFPZjJV9jpVxLP5RAQH?=
 =?us-ascii?Q?bPIsOZry9plEHgFKq2cBjz44B/Gm5TA+BST6h58sgeWNaLPrNKzU1B16YZYu?=
 =?us-ascii?Q?WRqepMIWjgUkMnk7X6tKQTxoKjBOr/9oCFhKypA+Mgc18TllCWB1OVO+2mZw?=
 =?us-ascii?Q?6x2f6LvjCWUtkwRVsDQAuam/7vIWA2dq3GSJGyg8uBpvL30EvtBHbs/gFMOL?=
 =?us-ascii?Q?j5ZVt+Iyzq8c0P5Z4wTZ6eWIHTv5bB/TM41WlLsibf6wn9ekGtLfHUjOv4wh?=
 =?us-ascii?Q?iXYP0MMD/mOVLmGJeEV12magRs3Hd7AKCWAiKrC9dZxQ3NJBJRC0fy26axuX?=
 =?us-ascii?Q?1yPsGdvh2zk9xODXi4IRMCtWY9uvfecHMz6RCOTjmxg8SMsER7bYNBPptCIw?=
 =?us-ascii?Q?UClLRrWybaNpKH0R6riZ6dm27GmBTiige0uWQGZqPdNvakDswIlEpxb3/2Wk?=
 =?us-ascii?Q?b1GtKT3vtdwQbCBBUwDp4Py+9W0DTeMsvaT5GCCo4D1K9bnVh9swrLO76z5r?=
 =?us-ascii?Q?9fHh80+THLrdwDIG7geRTirkVO7n0sgMbRLtH3oMJt6Kl8BnE9//LIgJ4hZL?=
 =?us-ascii?Q?/r3qsOSfgJzBS663mJYigOBI8HYr6kPIDnarqIbFbEWytzNZ+LTY1Ighlc49?=
 =?us-ascii?Q?Vdr3S9uGlAAVm3Yx/7ULqhc4DzkyBdlyVVP6t4PwbUV9d1FkRpQ1UO16OgHd?=
 =?us-ascii?Q?Wg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ece2cf97-f55c-419e-c8b2-08db26f00eea
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 14:01:08.9675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X94XrkkUejram/1xnF5lkrgtge8wkv7Na9/Eax5msbWX86yYiV2B054Y341MVCLARukyad8Elf5GTRAwn7/ibg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6717
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 17, 2023 at 03:31:16AM +0100, Christian Marangi wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> 
> Linux LEDs can be software controlled via the brightness file in /sys.
> LED drivers need to implement a brightness_set function which the core
> will call. Implement an intermediary in phy_device, which will call
> into the phy driver if it implements the necessary function.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---

As I have already mentioned in my comments for the patch 4, the final
version of "phy_led_set_brightness()" can appear here (without
an intermediate step with a dummy implementation).

Thanks,
Michal

>  drivers/net/phy/phy_device.c | 15 ++++++++++++---
>  include/linux/phy.h          | 11 +++++++++++
>  2 files changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index ee800f93c8c3..c7312a9e820d 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -2967,11 +2967,18 @@ static bool phy_drv_supports_irq(struct phy_driver *phydrv)
>  	return phydrv->config_intr && phydrv->handle_interrupt;
>  }
>  
> -/* Dummy implementation until calls into PHY driver are added */
>  static int phy_led_set_brightness(struct led_classdev *led_cdev,
>  				  enum led_brightness value)
>  {
> -	return 0;
> +	struct phy_led *phyled = to_phy_led(led_cdev);
> +	struct phy_device *phydev = phyled->phydev;
> +	int err;
> +
> +	mutex_lock(&phydev->lock);
> +	err = phydev->drv->led_brightness_set(phydev, phyled->index, value);
> +	mutex_unlock(&phydev->lock);
> +
> +	return err;
>  }
>  
>  static int of_phy_led(struct phy_device *phydev,
> @@ -2988,12 +2995,14 @@ static int of_phy_led(struct phy_device *phydev,
>  		return -ENOMEM;
>  
>  	cdev = &phyled->led_cdev;
> +	phyled->phydev = phydev;
>  
>  	err = of_property_read_u32(led, "reg", &phyled->index);
>  	if (err)
>  		return err;
>  
> -	cdev->brightness_set_blocking = phy_led_set_brightness;
> +	if (phydev->drv->led_brightness_set)
> +		cdev->brightness_set_blocking = phy_led_set_brightness;
>  	cdev->max_brightness = 1;
>  	init_data.devicename = dev_name(&phydev->mdio.dev);
>  	init_data.fwnode = of_fwnode_handle(led);
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 88a77ff60be9..94fd21d5e145 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -832,15 +832,19 @@ struct phy_plca_status {
>   * struct phy_led: An LED driven by the PHY
>   *
>   * @list: List of LEDs
> + * @phydev: PHY this LED is attached to
>   * @led_cdev: Standard LED class structure
>   * @index: Number of the LED
>   */
>  struct phy_led {
>  	struct list_head list;
> +	struct phy_device *phydev;
>  	struct led_classdev led_cdev;
>  	u32 index;
>  };
>  
> +#define to_phy_led(d) container_of(d, struct phy_led, led_cdev)
> +
>  /**
>   * struct phy_driver - Driver structure for a particular PHY type
>   *
> @@ -1063,6 +1067,13 @@ struct phy_driver {
>  	/** @get_plca_status: Return the current PLCA status info */
>  	int (*get_plca_status)(struct phy_device *dev,
>  			       struct phy_plca_status *plca_st);
> +
> +	/* Set a PHY LED brightness. Index indicates which of the PHYs
> +	 * led should be set. Value follows the standard LED class meaning,
> +	 * e.g. LED_OFF, LED_HALF, LED_FULL.
> +	 */
> +	int (*led_brightness_set)(struct phy_device *dev,
> +				  u32 index, enum led_brightness value);
>  };
>  #define to_phy_driver(d) container_of(to_mdio_common_driver(d),		\
>  				      struct phy_driver, mdiodrv)
> -- 
> 2.39.2
>