Message-ID: <3a625bc5-80ed-925d-2e16-bc3535320963@microchip.com>
Date:   Fri, 17 Mar 2023 15:02:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] net: macb: Set MDIO clock divisor for pclk higher than
 160MHz
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>,
        Bartosz Wawrzyniak <bwawrzyn@cisco.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <claudiu.beznea@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <xe-linux-external@cisco.com>, <danielwa@cisco.com>,
        <olicht@cisco.com>, <mawierzb@cisco.com>
References: <20230316100339.1302212-1-bwawrzyn@cisco.com>
 <7f3d0f2c-8bf9-41aa-8a7f-79407753df3b@lunn.ch>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <7f3d0f2c-8bf9-41aa-8a7f-79407753df3b@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Andrew,

On 16/03/2023 at 20:34, Andrew Lunn wrote:
> On Thu, Mar 16, 2023 at 10:03:39AM +0000, Bartosz Wawrzyniak wrote:
>> Currently macb sets clock divisor for pclk up to 160 MHz.
>> Function gem_mdc_clk_div was updated to enable divisor
>> for higher values of pclk.
>>
>> Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@cisco.com>
>> ---
>>   drivers/net/ethernet/cadence/macb.h      | 2 ++
>>   drivers/net/ethernet/cadence/macb_main.c | 6 +++++-
>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
>> index 14dfec4db8f9..c1fc91c97cee 100644
>> --- a/drivers/net/ethernet/cadence/macb.h
>> +++ b/drivers/net/ethernet/cadence/macb.h
>> @@ -692,6 +692,8 @@
>>   #define GEM_CLK_DIV48                                3
>>   #define GEM_CLK_DIV64                                4
>>   #define GEM_CLK_DIV96                                5
>> +#define GEM_CLK_DIV128                               6
>> +#define GEM_CLK_DIV224                               7
> 
> Do these divisors exist for all variants? I'm just wondering why these
> are being added now, rather than back in 2011-03-09.

I see them existing in all variants of "GEM" controller and the older 
"MACB" uses a different path so I think that we are save enabling these 
values.

The values were not added back in the days because the SoC where the 
controller was used didn't reach the frequencies that we are observing 
today for pclk. Divisors weren't needed and field even not completely 
described in Microchip datasheets.

Hope that this sheds some light. Best regards,
   Nicolas

-- 
Nicolas Ferre