Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath12k: Add missing unwind goto in
 ath12k_pci_probe()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230307104706.240119-1-harshit.m.mogalapalli@oracle.com>
References: <20230307104706.240119-1-harshit.m.mogalapalli@oracle.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     unlisted-recipients:; (no To-header on input) error27@gmail.com,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        P Praneesh <quic_ppranees@quicinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
        Jeff Johnson <quic_jjohnson@quicinc.com>,
        Bhagavathi Perumal S <quic_bperumal@quicinc.com>,
        Wen Gong <quic_wgong@quicinc.com>, ath12k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Illegal-Object: Syntax error in Cc: address found on vger.kernel.org:
        Cc:     unlisted-recipients:; (no To-header on input)error27@gmail.com
                                                                     ^-missing end of address
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167887550837.27926.11659991726085359589.kvalo@kernel.org>
Date:   Wed, 15 Mar 2023 10:18:33 +0000 (UTC)
Precedence: bulk

Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:

> Smatch Warns:
>         drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
>         warn: missing unwind goto?
> 
> Store the error value in ret and use correct label with a goto.
> 
> Only Compile tested, found with Smatch.
> 
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

488d9a484f96 wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230307104706.240119-1-harshit.m.mogalapalli@oracle.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches