From:   Frank Li <frank.li@nxp.com>
To:     Shunsuke Mie <mie@igel.co.jp>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>
CC:     Vinod Koul <vkoul@kernel.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: RE: [EXT] [RFC PATCH 06/11] misc: pci_endpoint_test: Use a common
 header file between endpoint driver
Thread-Topic: [EXT] [RFC PATCH 06/11] misc: pci_endpoint_test: Use a common
 header file between endpoint driver
Thread-Index: AQHZWMRAZpxSPgbE9kOzF/3xKVztPK7/DA2A
Date:   Fri, 17 Mar 2023 14:47:08 +0000
Message-ID: <AM6PR04MB4838D8F8AF23C61048BDFB9788BD9@AM6PR04MB4838.eurprd04.prod.outlook.com>
References: <20230317113238.142970-1-mie@igel.co.jp>
 <20230317113238.142970-7-mie@igel.co.jp>
In-Reply-To: <20230317113238.142970-7-mie@igel.co.jp>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?EEZgENb/aATAfDkMr4Odv/nHkWfzTJtHLfmEWqVDIV4SfC5NeJLILUrMhu?=
 =?iso-8859-2?Q?BLzS4FW4Ps3x2SjYZ5P//+JlRwKbAiKxY7T57DbP8Ot1BYGwBn8mOA7KJw?=
 =?iso-8859-2?Q?0m7SuR+7ekw0g4KTqQRcHVy7dwU2rS7vsx+HaKxiv4M0hiD/ZRi7G+qb73?=
 =?iso-8859-2?Q?yJ14vmj2CdWElVHga0YYceUBuPPSTRhf0/u4mKgbQ3dSNLRr+esuk53EM/?=
 =?iso-8859-2?Q?TL/uK/ke96mVuwjoFHIrh7ncR3BdGRrZDzW0EwS5jd2zVoqktH8fsKhsg/?=
 =?iso-8859-2?Q?ylbgZm1JBG9p4UE9ZRAK7LiQCa6qdFg9f+6ZxgVECngtiMzmcyK46hfGET?=
 =?iso-8859-2?Q?5LphcdV5J400BfGvmaJjoAvC5Wc+lrSdl273IuulL/2xj1X8hj9oVMFv5k?=
 =?iso-8859-2?Q?3Ps6nyUcFXbkY8bRCurIvn8/7Wo7l9t7uaQRyTOvqU9NZQt/4/SzMkYnJy?=
 =?iso-8859-2?Q?cNiGMJ6UjCRfgUMlA618Nqz4CsTA0vH8+0t5F7ZlVrD2AWpeooFMDM5GRl?=
 =?iso-8859-2?Q?c1duCcjtbps9d5zfV5hhpuqRxxppdX7uGv4HL++zHE2WW7y4CRMFXzsJxy?=
 =?iso-8859-2?Q?c2K2O+933gEX2neZjwgsxZxXbFgaPliES7tH5NqjLTsfxyp/SrYEePTu0K?=
 =?iso-8859-2?Q?7cawTSLNOhe7YYw7YP8HgUJbwtBiz4uYkN4X4hEuxi15HJafOSrVUgCqOq?=
 =?iso-8859-2?Q?VRD5kPgqiRImf7xZkG24q36ywz2PzMX2U87UUUKHpa75kc1KKKcOdy4RFQ?=
 =?iso-8859-2?Q?7+QVXDQXTLGdf9kIwnBFZ1xV0aUyQr5jUdssKXFmHy263yMNq4DHwH5/tN?=
 =?iso-8859-2?Q?3f//n6Ualn1pKI0z3pltihuHra3Mz4QrwfSWQ2Wtv5qkXuUTm7m7b82UMf?=
 =?iso-8859-2?Q?B97CEs4kFeHkAn0pYLlAE3y5Ub/ZEfO2SCsSKWhjaGcD5THQZrdfAc5EZz?=
 =?iso-8859-2?Q?l8eGe7pPVjWkdFAnPczm6y8ZtiAm7hTi+BJnU2vUus2fbkuwGN9f8cab0s?=
 =?iso-8859-2?Q?Tr9Gs7YYuMf6qHjIqTEaAXxJ+jONccWILiMcBcPuV0jiymPekJCp3qJHfB?=
 =?iso-8859-2?Q?J1YA6AgHibwqsGZ44JHp08nge6KL86u66jvFclQK7MD/CCZssAIO4vgMxK?=
 =?iso-8859-2?Q?2XabNaGwV+5IIiDkogQkSLPnLcoqThji4hcuFek2+cjENkPG8ukJQOIIxq?=
 =?iso-8859-2?Q?zEX52bODNH/SpjqpB8UPxJNPAa6q9jkkSh+9n14Yb7HerNPn2SkaQ9vdhX?=
 =?iso-8859-2?Q?zqZp+aoIZJd2eOp0gL5ad1ULm0984QUdlBVAXpwMHygiFJd3e8b3N8aQ2v?=
 =?iso-8859-2?Q?YERlDcWYjXjlWyje4ouoRI+67R588Ay/RA5Bcp27xUfDZhBqBz5CDjFk0z?=
 =?iso-8859-2?Q?1E+cvVT16WCQ5kpQXlKBFk0mkWYcCkL4ay/9ZXvMqTnS61pT+WsdEuAb70?=
 =?iso-8859-2?Q?zh29OGBFZnyxCFyQ/e/K2WY0eQ/UxqoEv4w3FSYS8hfz6I3p5wACpk5fcs?=
 =?iso-8859-2?Q?J+7r/fB5ZskPmaC8qdYnhTHkj2820dioitb63wgMxzCkVBy/vmjEqDkNtW?=
 =?iso-8859-2?Q?9BWr9QOGpjhoILzwH4j5+1xG9458WsjmeWEoM4SHHzHjyNuatMMmhPRMNm?=
 =?iso-8859-2?Q?IldlSo8rGP0II=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f340fd95-2706-4690-fc44-08db26f67c18
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2023 14:47:08.8723
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7vJop6dMfZaQ0UOXi2o9qxVWm/mrrBgWCs7fc1nnaxi+51hLjzOAncSOZb2tO6IOBUHo8tblUFYs2+7nVudQPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7786
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> pci@vger.kernel.org
> Subject: [EXT] [RFC PATCH 06/11] misc: pci_endpoint_test: Use a common
> header file between endpoint driver
>=20
> Caution: EXT Email
>=20
> Duplicated definitions between pci-epf-test and pci_endpoint_test are
> already moved to a header file. Remove the common definitions and include
> the header file. In addition, the separate register address writes were
> combined into a single write.
>=20
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> ---
>  drivers/misc/pci_endpoint_test.c | 42 +-------------------------------
>  1 file changed, 1 insertion(+), 41 deletions(-)
>=20
> diff --git a/drivers/misc/pci_endpoint_test.c
> b/drivers/misc/pci_endpoint_test.c
> index 55733dee95ad..d4a42e9ab86a 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -22,52 +22,12 @@
>  #include <linux/pci_ids.h>
>=20
>  #include <linux/pci_regs.h>
> +#include <linux/pci-epf-test.h>

Pci-epf-test.h was only used by these two files.

Actually, I think move  drivers/misc/pci_endpoint_test.c to under drivers/p=
ci/endpoint/functions/
And shared one private header is more reasonable.=20
These two files should be stay together because tight coupling. =20


>=20
>  #include <uapi/linux/pcitest.h>
>=20
>  #define DRV_MODULE_NAME                                "pci-endpoint-tes=
t"
>=20
> -#define IRQ_TYPE_UNDEFINED                     -1
> -#define IRQ_TYPE_LEGACY                                0
> -#define IRQ_TYPE_MSI                           1
> -#define IRQ_TYPE_MSIX                          2
> -
> -#define PCI_ENDPOINT_TEST_MAGIC                        0x0
> -
> -#define PCI_ENDPOINT_TEST_COMMAND              0x4
> -#define COMMAND_RAISE_LEGACY_IRQ               BIT(0)
> -#define COMMAND_RAISE_MSI_IRQ                  BIT(1)
> -#define COMMAND_RAISE_MSIX_IRQ                 BIT(2)
> -#define COMMAND_READ                           BIT(3)
> -#define COMMAND_WRITE                          BIT(4)
> -#define COMMAND_COPY                           BIT(5)
> -
> -#define PCI_ENDPOINT_TEST_STATUS               0x8
> -#define STATUS_READ_SUCCESS                    BIT(0)
> -#define STATUS_READ_FAIL                       BIT(1)
> -#define STATUS_WRITE_SUCCESS                   BIT(2)
> -#define STATUS_WRITE_FAIL                      BIT(3)
> -#define STATUS_COPY_SUCCESS                    BIT(4)
> -#define STATUS_COPY_FAIL                       BIT(5)
> -#define STATUS_IRQ_RAISED                      BIT(6)
> -#define STATUS_SRC_ADDR_INVALID                        BIT(7)
> -#define STATUS_DST_ADDR_INVALID                        BIT(8)
> -
> -#define PCI_ENDPOINT_TEST_LOWER_SRC_ADDR       0x0c
> -#define PCI_ENDPOINT_TEST_UPPER_SRC_ADDR       0x10
> -
> -#define PCI_ENDPOINT_TEST_LOWER_DST_ADDR       0x14
> -#define PCI_ENDPOINT_TEST_UPPER_DST_ADDR       0x18
> -
> -#define PCI_ENDPOINT_TEST_SIZE                 0x1c
> -#define PCI_ENDPOINT_TEST_CHECKSUM             0x20
> -
> -#define PCI_ENDPOINT_TEST_IRQ_TYPE             0x24
> -#define PCI_ENDPOINT_TEST_IRQ_NUMBER           0x28
> -
> -#define PCI_ENDPOINT_TEST_FLAGS                        0x2c
> -#define FLAG_USE_DMA                           BIT(0)
> -
>  #define PCI_DEVICE_ID_TI_AM654                 0xb00c
>  #define PCI_DEVICE_ID_TI_J7200                 0xb00f
>  #define PCI_DEVICE_ID_TI_AM64                  0xb010
> --
> 2.25.1