From:   Frank Li <frank.li@nxp.com>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: RE: [EXT] Re: [PATCH v2 2/3] arm64: dts: imx8qxp: add cadence usb3
 support
Thread-Topic: [EXT] Re: [PATCH v2 2/3] arm64: dts: imx8qxp: add cadence usb3
 support
Thread-Index: AQHZWE4gY8I1HVGK8EKXaSGyCYF/Mq7+hb6AgACL7xA=
Date:   Fri, 17 Mar 2023 15:05:44 +0000
Message-ID: <AM6PR04MB4838F13033FCB62B2519C42088BD9@AM6PR04MB4838.eurprd04.prod.outlook.com>
References: <20230316212712.2426542-1-Frank.Li@nxp.com>
 <20230316212712.2426542-3-Frank.Li@nxp.com> <3810738.Icojqenx9y@steina-w>
In-Reply-To: <3810738.Icojqenx9y@steina-w>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?1tUGZ4Swl+I8S/JGcCQSqIHKH0I8THnSbUg4ZqVsN4XFniHfLBYFEZB/VQ?=
 =?iso-8859-1?Q?1dngZHyfvM+rD7bTo4E6+uOke8YHsL3E1cyF0Vo1eN0idrO8wmacTJDB77?=
 =?iso-8859-1?Q?1GrN+Fh5UvhTS9mP1xE8vAi8XAOeHwXsL8a0KQvX6aR4qOKAEbd+V7WXZl?=
 =?iso-8859-1?Q?ANgB/waXR77Rwo+UL9r4eYCFumGCHvmqI9e6n7bp0fJPzxYtLcDxvI8vSK?=
 =?iso-8859-1?Q?sKuPnLt+GwZStSFvZaEJWHZYf6qy85CUuGQEIp6vwYK9xkbJHFw2sHI29J?=
 =?iso-8859-1?Q?n67aLdISu39OFSPYRlS1pBKzy82bVPAGPmAUQKvFv215vuKXaAouAu5Sc7?=
 =?iso-8859-1?Q?GziUTA2y9TfHmhJb3PNn3G9RovZ4LfMnDiBIwIuiwRAlNuLooi38etDr/O?=
 =?iso-8859-1?Q?tc9H4Mq2o/FG3srzhBGsBDcE9anUojfsogwwaLS7IgIRUmwPqChkW9j8Yi?=
 =?iso-8859-1?Q?9CbDGD6r28+yHqopOB9FBoJd+lSS0qvEQQ9mazvIUEwJVlF6IgyLuqwplQ?=
 =?iso-8859-1?Q?SJfieolPzwr7vLMAMmGIOn6mOZzPhlI134QYDFxJb3GBpirOj46pu8vTa0?=
 =?iso-8859-1?Q?YALQFaCEgaLpE9lrGfxgddBVNV4dgEJNrg0To8qf6suHir5C7bkhieZXrQ?=
 =?iso-8859-1?Q?CSraugPwIDBJQ/kl92AAK0Ul1ZQ7ktAVff1IBAM7jvfVFFoRiDLKh27XGJ?=
 =?iso-8859-1?Q?7bpE8OUvftTsAsN/DMDsJMLbGEms9gNW2ggp4Ahbzfs+fE1/i2KPXhyswK?=
 =?iso-8859-1?Q?HwAfJG65wUdvv4tXsAGkpaecI0OuwQ170m930MGfSleGhSObOz5EF2WajO?=
 =?iso-8859-1?Q?erXQRwUcOR+TzMl1uEk8cxDgnxj9znGqXK+c20o4gvOrrqNfKgiGyd5CEk?=
 =?iso-8859-1?Q?eIQnGo4yfzuJFPyWXHOHikk7oWSwqC+dNwt1cDVQUARRxCr2WxKbXgq18M?=
 =?iso-8859-1?Q?MEud0MAwz4F+JaSlbp3vFV4Vid7QBWcd0g2hXUm8N7IaP9BXGMhHvoUEro?=
 =?iso-8859-1?Q?SDz7lFeS8FhX/sf3jt7png8L+/fKMA50zzwwJsC3ZOi+B4QplF/kXD2lGy?=
 =?iso-8859-1?Q?+F43dSyX5fAwDJzDRJr/+Zx2/+T7vlQ5O4Hbiic39AGxGnS5nUj78xvVrF?=
 =?iso-8859-1?Q?YpZRKTSXHgkw/sOOcT14vTMZdZgJ2pFngTrYw/UAaRB5JUWa5av7Zkl3rh?=
 =?iso-8859-1?Q?emu4UAIJvZ6J82VLc5zGgDa3ZQwF8jXvV0F3gS2NvRzTfNt/ZT0trhFV4U?=
 =?iso-8859-1?Q?MuJdh6nAyAzwshiAGqK0vNlGqPIa2L/EaiRt6FVjz58Wu5KDFLKrqi3WZI?=
 =?iso-8859-1?Q?ClBwDasfVzDEv1xq9pvd0uim/3bvAk9Xn1FIyhc9+q2qj7E7hwTxmKAQCx?=
 =?iso-8859-1?Q?sV4PS7hXNTBT3Q63zBaKo2yg//B31fsMzoSzcx2etOll4sY9m+QGsxM0uO?=
 =?iso-8859-1?Q?snSErGKArafrJol/H45Byw+cCATGoxk8NkwcpXQNmHS80oU98S7z1WUAzi?=
 =?iso-8859-1?Q?POIn3O7XsFGhnqN+Ftv+nJ3y3pHAwItwtSovtngVKHgfp2Rd6jRfBXio8D?=
 =?iso-8859-1?Q?YOVjIlylfYXwuZYkYYOa16OWpINBykS+ZiBmDD6jbTP/GLEdMAS+04YOJC?=
 =?iso-8859-1?Q?q/Zg6xvavpI9/DweX4v/Q/LHcG3sDUyRr4?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f0ceb4d-5b53-4aaa-fc99-08db26f91539
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2023 15:05:44.7422
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QyIZi8gFWcP4/fR0nh1wAKK9yENI/V6gN241yqwd37gVj9ubOURlgv492wLV856xk9XFAsyAE1TWErdDnqBo4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9363
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Caution: EXT Email
>=20
> Am Donnerstag, 16. M=E4rz 2023, 22:27:10 CET schrieb Frank Li:
> > There are cadence usb3.0 controller in 8qxp and 8qm.
> > Add usb3 node at common connect subsystem.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../boot/dts/freescale/imx8-ss-conn.dtsi      | 72 +++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi index
> > 4852760adeee..389f52f16a5c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > @@ -138,6 +138,56 @@ fec2: ethernet@5b050000 {
> >               status =3D "disabled";
> >       };
> >
> > +     usbotg3: usb@5b110000 {
> > +             compatible =3D "fsl,imx8qm-usb3";
>=20
> Mh, is imx8qm considered a subset of imx8qxp or vice versa?
> Maybe it's worth adding a dedicated compatible for imx8qxp as well.

Imx8qxp is subset of imx8qm.
This part is the same between qxp and qm.=20
If exact same,  I think not necessary to add compatible string.=20

>=20
> Best regards,
> Alexander
>=20
> > +             #address-cells =3D <1>;
> > +             #size-cells =3D <1>;
> > +             ranges;
> > +             reg =3D <0x5b110000 0x10000>;
> > +             clocks =3D <&usb3_lpcg IMX_LPCG_CLK_1>,
> > +                      <&usb3_lpcg IMX_LPCG_CLK_0>,
> > +                      <&usb3_lpcg IMX_LPCG_CLK_7>,
>=20