Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB4EC7618E for ; Fri, 17 Mar 2023 15:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbjCQPcJ (ORCPT ); Fri, 17 Mar 2023 11:32:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbjCQPb6 (ORCPT ); Fri, 17 Mar 2023 11:31:58 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878D9925F; Fri, 17 Mar 2023 08:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ojT5RV7IuxtmiG8XmC3PkiAz0l5iLYwDs/bmvH+qy3Q=; b=1+M/cQPdinsHbsS3ReG/eGwi9/ ReUm5bedO3hK206pCGqDpEkqc511QuPJT3JyypdqC5/Edx2VVdTTEYOht0nf3jbqERkmhif9hHqyw HwWNDtKt516jtVFOH1cJeNvWqclwTtXrr7HyVjfydiCFGyj9VqzuD+XCJtjHMdjbP0zs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pdC3D-007cjC-2w; Fri, 17 Mar 2023 16:31:27 +0100 Date: Fri, 17 Mar 2023 16:31:27 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Christian Marangi , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v4 04/14] net: phy: Add a binding for PHY LEDs Message-ID: <2c2d7c4a-bd35-4454-aa58-3106334806f2@lunn.ch> References: <20230317023125.486-1-ansuelsmth@gmail.com> <20230317023125.486-5-ansuelsmth@gmail.com> <20230317084519.12d3587a@dellmb> <6cf03603-2a8e-4c08-a61b-aef164a0f5d9@lunn.ch> <20230317152903.5103f2c4@dellmb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317152903.5103f2c4@dellmb> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, and this would solve the problem for a user who wants to change > the behaviour of a LED for a given PHY. But a user who wants to list > all available LEDs by listing /sys/class/leds can also retrieve a nice > list of names that make sense, if the documented format is followed. Please make a concrete proposal. Also, keep in mind, ethernet device names change at runtime, and are not unique. Function also changes at run time, which is in fact the whole purpose of this collection of patchsets. Andrew