Date:   Fri, 17 Mar 2023 17:18:30 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 12/16] can: m_can: Use the workqueue as queue
Message-ID: <ZBSS1tqgHzYp3pBH@corigine.com>
References: <20230315110546.2518305-1-msp@baylibre.com>
 <20230315110546.2518305-13-msp@baylibre.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315110546.2518305-13-msp@baylibre.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4D8S5eSOovsJZQUUyPPrvw4anAd0/orUsNVCfzagXPQLVnS0Tl3Z8AWygQRf?=
 =?us-ascii?Q?hGSkcKKZarfCS8el/28vj270KSVLyciywu1ObBJYwOTyfSngGl9ZFFZwS9k+?=
 =?us-ascii?Q?bBfJ6zHbIFopFZ7fyM10Q9V7QSl3DqrFoDan6hoaql0CpBB8B6kZsPpd86HF?=
 =?us-ascii?Q?/w0Woiv/lL1izxe0+7qeJDUSsHkQw3dwJFisnhJYzTSbpLUUBksKn23vIHpZ?=
 =?us-ascii?Q?ojP+JU+rP57uhK+Rwu/YVua8HZHtU1vcSbOrBp5UUO/asO/6v0jhuDwsMij7?=
 =?us-ascii?Q?GnKXFKmAAhEMa7upsrMc6vF+m3PtmeVuOEUxn9yCEWYQ7GMjvjvl53CmkdqM?=
 =?us-ascii?Q?/KWFFjVBwf494wofJFEGv3ATLk432oQ1sNV/wzR2MTOloDCLv+9y0HiZk1J+?=
 =?us-ascii?Q?XY00K0lbzdziUxD8kCYFaf32S/YK0DADECZSrYJIKA9Mo6AylTHGg/5FOSh4?=
 =?us-ascii?Q?uhFm3mRoU6z1Xz27Emk47JkjxGbv5vcGet7+rinAVy1gZ5dXsYAQfX96rIxO?=
 =?us-ascii?Q?49xZAQPRz/80V+lh2b11CTGBvgd9EWhfWNqgZ4vDFIwo4iNPyvL3qqsbSL8N?=
 =?us-ascii?Q?j2X/hNYEqrWxvKwdG4suIYRbW5mAONCsf9AhEpYQCfdKqwE/VaUBO9yggj+l?=
 =?us-ascii?Q?Rkdiyiv3N2luZw0ueA7LBzfvfkujmXnvFHz7OO1TLeU0yYC2P8Tt9f85LDG8?=
 =?us-ascii?Q?WPirQkU4jpWWlyX8Snbd8WMqwLl6T/uFll1rx8386IDRQkJPme7Ctz3UX0zX?=
 =?us-ascii?Q?bfwMYv3+bLIOGSY3d4OMpCycetGxx5l2IHMzOndDDTxftt845PXF6pEjwMB+?=
 =?us-ascii?Q?nhvpS3aG6UTFrJC81ELL24olju/h1Gr3pkR6ZSzySk6SOH/JtTwuur/styZy?=
 =?us-ascii?Q?FY/ir5aOfY2T1VQ9b5wtGV7P5IrA6u9h1SWWhEMMoW4OaesZtoyqdjGJ2tVh?=
 =?us-ascii?Q?EmHhLuwSvjReBOAlk8YSOkeMVjZ8FNoZFno6PLUxyiOwL5uTm8PJ2lN8f3Su?=
 =?us-ascii?Q?3rvQcC262OkkwZ7c2DQoDFYdy/bzP4mBNtBXTPptifMdTIyyg4D65k4Rhj3Y?=
 =?us-ascii?Q?maGTKc+Ra74vsIab8b5CIl3N6bvtzttMJ2OCEWFypKbuFoubt4e0WhLp3zoB?=
 =?us-ascii?Q?/1T9Nu61nE2Vp9A7M9NGrQaumsGvfYSfRpk5z6kYnAPJghvYiAqNs3xpJabc?=
 =?us-ascii?Q?9jkJrKrrSn+r1gtCeodFTmDg/64+ltU83e7lN7/1ZB3rVjXBGrrokvEZ02Ph?=
 =?us-ascii?Q?6FiD8n5LljQYZ6qxYiMqZ+MadO7wbHscZmiyBYn/dE2jtvnoVb8j8h02FSms?=
 =?us-ascii?Q?oaK7M3wZUkIHZVG2T4RarFwCtOYznAqWXCBDWkeR6tUhf2vo+tP0g3XZqkk8?=
 =?us-ascii?Q?qRGVuKrjzyRn0DEpddZMc12Lw+94hrAXiyY5Hts9G7+Pzgn/8rDFSqBm/oYR?=
 =?us-ascii?Q?EiT+peFU2yHMmcqX1cc1NggBI6PxIlEVvjtnhy9vIhY00HtxvLwo59VG0wR/?=
 =?us-ascii?Q?5J/58ictLEk/6rtfv6lvJL12VaIz2TAlsusMW6l0J55KdZlDQCjlWsxZzUoi?=
 =?us-ascii?Q?hz6fNPGMNwBdZNODghUsTrtZQFqbf5zbyTYAhqMuKyOnaJr/kZ70PLeECcfg?=
 =?us-ascii?Q?iPuo/XDFb52byZCE+/angyq1m9LWvqYUKmF3OJMoux+aUdOlFuG19wWvtYFA?=
 =?us-ascii?Q?S/PvJw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0982e470-4b16-425b-ef0c-08db270343dd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 16:18:38.1622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ot6oMyxD7enTMTPES2YAg6ZF5rvsYqT0SOf5qtXa4Z1b61o27bDeFVY85TmV6xUzJX5DgVtxQ4OU6ElxDjzxGm3+P6sfPmsp537Sr4n+7/U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR13MB5884
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 15, 2023 at 12:05:42PM +0100, Markus Schneider-Pargmann wrote:
> The current implementation uses the workqueue for peripheral chips to
> submit work. Only a single work item is queued and used at any time.
> 
> To be able to keep more than one transmit in flight at a time, prepare
> the workqueue to support multiple transmits at the same time.
> 
> Each work item now has a separate storage for a skb and a pointer to
> cdev. This assures that each workitem can be processed individually.
> 
> The workqueue is replaced by an ordered workqueue which makes sure that
> only a single worker processes the items queued on the workqueue. Also
> items are ordered by the order they were enqueued. This removes most of
> the concurrency the workqueue normally offers. It is not necessary for
> this driver.
> 
> The cleanup functions have to be adopted a bit to handle this new
> mechanism.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>