Date:   Fri, 17 Mar 2023 17:28:35 +0100
From:   Francois Romieu <romieu@fr.zoreil.com>
To:     David Yang <mmyangfl@gmail.com>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: hisi-festa: Add support for HiSilicon Festa
 PHYs
Message-ID: <20230317162835.GA81256@electric-eye.fr.zoreil.com>
References: <20230317143042.291260-1-mmyangfl@gmail.com>
 <d5ec2ec2-65a0-6ad3-a0a3-cad57d7f6616@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d5ec2ec2-65a0-6ad3-a0a3-cad57d7f6616@gmail.com>
Precedence: bulk

Heiner Kallweit <hkallweit1@gmail.com> :
> On 17.03.2023 15:30, David Yang wrote:
[...]
> > diff --git a/drivers/net/phy/hisi-festa.c b/drivers/net/phy/hisi-festa.c
> > new file mode 100644
> > index 000000000..ab54ed3ca
> > --- /dev/null
> > +++ b/drivers/net/phy/hisi-festa.c
[...]
> > +static int hisi_festa_patch_fw(struct phy_device *phydev)

This function can fail...

[...]
> > +static int hisi_festa_config_init(struct phy_device *phydev)
> > +{
> > +	hisi_festa_patch_fw(phydev);
> > +	/* ok, use programmed firmware */
> > +	return 0;

... but nobody cares.

This lack of consistency may also be fixed once Heiner's remarks are
answered.

-- 
Ueimor