MIME-Version: 1.0
References: <20230303041411.3161780-1-srinivas.pandruvada@linux.intel.com>
In-Reply-To: <20230303041411.3161780-1-srinivas.pandruvada@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 17 Mar 2023 18:38:11 +0100
Message-ID: <CAJZ5v0g6b0=daCgNnH6sh1WJfkQYUOnCUj1QSxPERnP8Sz=tOQ@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Enable HWP IO boost for all servers
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc:     rafael@kernel.org, lenb@kernel.org, viresh.kumar@linaro.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Mar 3, 2023 at 5:14 AM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> The HWP IO boost results in slight improvements for IO performance on
> both Ice Lake and Sapphire Rapid servers.
>
> Currently there is a CPU model check for Skylake desktop and server along
> with the ACPI PM profile for performance and enterprise servers to enable
> IO boost.
>
> Remove the CPU model check, so that all current server models enable HWP
> IO boost by default.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index cb4beec27555..8edbc0856892 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2384,12 +2384,6 @@ static const struct x86_cpu_id intel_pstate_cpu_ee_disable_ids[] = {
>         {}
>  };
>
> -static const struct x86_cpu_id intel_pstate_hwp_boost_ids[] = {
> -       X86_MATCH(SKYLAKE_X,            core_funcs),
> -       X86_MATCH(SKYLAKE,              core_funcs),
> -       {}
> -};
> -
>  static int intel_pstate_init_cpu(unsigned int cpunum)
>  {
>         struct cpudata *cpu;
> @@ -2408,12 +2402,9 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
>                 cpu->epp_default = -EINVAL;
>
>                 if (hwp_active) {
> -                       const struct x86_cpu_id *id;
> -
>                         intel_pstate_hwp_enable(cpu);
>
> -                       id = x86_match_cpu(intel_pstate_hwp_boost_ids);
> -                       if (id && intel_pstate_acpi_pm_profile_server())
> +                       if (intel_pstate_acpi_pm_profile_server())
>                                 hwp_boost = true;
>                 }
>         } else if (hwp_active) {
> --

Applied as 6.4 material, thanks!