Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760522AbXIRQgE (ORCPT ); Tue, 18 Sep 2007 12:36:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759516AbXIRQfu (ORCPT ); Tue, 18 Sep 2007 12:35:50 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:57133 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759537AbXIRQfs (ORCPT ); Tue, 18 Sep 2007 12:35:48 -0400 Subject: Re: [PATCH] JBD slab cleanups From: Mingming Cao Reply-To: cmm@us.ibm.com To: Christoph Hellwig Cc: Badari Pulavarty , Christoph Lameter , linux-fsdevel , ext4 development , lkml In-Reply-To: <20070918090407.GA671@infradead.org> References: <20070902152801.GA19962@infradead.org> <20070903134043.GB28962@infradead.org> <20070903193308.GA7771@infradead.org> <1189796027.3841.6.camel@localhost.localdomain> <1190057391.3845.22.camel@localhost.localdomain> <1190066466.31220.5.camel@dyn9047017100.beaverton.ibm.com> <1190069851.6725.6.camel@localhost.localdomain> <20070918090407.GA671@infradead.org> Content-Type: text/plain Organization: IBM Linux Technology Center Date: Tue, 18 Sep 2007 09:35:47 -0700 Message-Id: <1190133347.3819.6.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0 (2.8.0-33.el5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 23 On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > Here is the incremental small cleanup patch. > > > > Remove kamlloc usages in jbd/jbd2 and consistently use jbd_kmalloc/jbd2_malloc. > > Shouldn't we kill jbd_kmalloc instead? > It seems useful to me to keep jbd_kmalloc/jbd_free. They are central places to handle memory (de)allocation(