Message-ID: <ef0ff486-afed-5b3b-34af-0b8a7c5ff5b3@intel.com>
Date:   Fri, 17 Mar 2023 10:49:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.8.0
Subject: Re: [PATCH] selftests/resctrl: Use correct exit code when tests fail
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <eranian@google.com>
References: <20230309145757.2280518-1-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230309145757.2280518-1-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlpuVmx0QTdwTm5GUllsalo0UGprZ0dsZk1VQkh6Y0ZGSXIvcXF2bUNPdHla?=
 =?utf-8?B?bms1aFRJOGR0b0ZlYkw5ejkrR3NsWGQwaUpkWFdYSlNLbkpMRVJ2T0I4MTIw?=
 =?utf-8?B?UE9VOElVekJNT2Y1WUtqNEQ4QjRXUzNKOXh0YVp3R1orV0s5Y2UxaDFOMnNt?=
 =?utf-8?B?UnNaaEN4ZGxvT2Q2cENJQ2xSdk1xUHdzTUxCb3pVcmpRYisxUkNFVnFvV0hU?=
 =?utf-8?B?bGxUVEhYNTkwVzBaSm11dU9qYXJRYzFNOTcrMWZ2NDV1TFdZVkhCcTlKK2Rh?=
 =?utf-8?B?clc2UkpJZEdrZWFXNUpFMzk4MWhXMlZpMlZ2TUUrZFBjcUdrTVRWeUhqMVN5?=
 =?utf-8?B?ekRtLzZ0L0ZUdFNoOUc3UFM2S3QrVkpyMCtINGk5bXNzVmcvWmtid2h3aFRK?=
 =?utf-8?B?MitEUE4yaXJodjlrcEVUWG1LMlNkOXJ1RDdjQk5pMFV3Wm00WXI2emxkZ1Rl?=
 =?utf-8?B?cFkzQUR3TjBVaVRSdVErVkZhRHFaTXo5OFNLSlhtSGJqcVlTVEpOZWxwMFJy?=
 =?utf-8?B?SW5NREw2SCtwcFB6SHorQmNMSWJSV2J1Y3Qydi8vdUo3eTdaUms4cHBoY3Zo?=
 =?utf-8?B?TlozVFFlRURYeVA3UzNSaHNsamMyVjBRYjE2bVBpS29pSDhuM0xPU1Z2N3Bz?=
 =?utf-8?B?Wm9KOW51WlFjakJ5MEE0a2JGcTlIM1F6M3BNMW04eTU4UmxmYzRPakt3anUr?=
 =?utf-8?B?OVdudUdZaDV0czVUZXYyam5BNGo2VWZzZkdHSWUyOVBnTzUyS1VxU3Z0TStm?=
 =?utf-8?B?UVB6eUZpUDk3UDR1TjZwQzlYZXpLYjZRaHMvUW14K0hOUEd1L3hWUnk4OVN1?=
 =?utf-8?B?Vjdoeit4Vm5wZmhhWXg1VnRaQVkzc2VFTTJiOGxjcVJSbDJvdU03SDFzQ2E2?=
 =?utf-8?B?OTJkS2pVcWt5NVl1K3dCU2pkVDBzRXIwNkpnckZ0dW9tTWlGNmYyR01YdU9K?=
 =?utf-8?B?MjlHMk5GTjBDNkc5eklycTNaVU4yV3ZnTXhPT3ZGVjdqYXA2Zk9JQjcvN3Nr?=
 =?utf-8?B?bStXWitZdkhMcTlhaHB2QmVpWnZYS3F4ZTNlMUlaZzBFU3dNUUZITzJMaUht?=
 =?utf-8?B?T2tHbVdlU0FNcEc0TXc4OTJsbnRGK0g4Ri9DdHZ1aUhPZjBWTUN2U1RxUDJD?=
 =?utf-8?B?OGo4NmJleUVLcjg3YWxpUjJ1b3RPSGVjQlJQQVZuT3VjZGdITC9rTHJmaXBq?=
 =?utf-8?B?U3QvY1drYll3ZE9CRHhHZ0lsdUFUT0d6TW1VVTdObFBxV2RPOU9SOUFGTWNl?=
 =?utf-8?B?dmlRZ1huOUdiakhhdW02ZS9RSFNxMGhxaWF2UVkwZ0xJclBkVlRjU1phTXM5?=
 =?utf-8?B?bWxOVjJwNjA2TTF1aWE1Ykp6RGRNRTlBR3F2bWJYVWV0RHFOSk5qSEJjUlZK?=
 =?utf-8?B?VTYxdFNHS0xVZ3ZhUmo1elo5d3g2ZzIxUlNpRVhZbXJFVDRBVEhTUEZjdE45?=
 =?utf-8?B?Z1BFMTl6ckpCaFZDMDdyOWNVTEE3RjBYV241Zy91RytjYk00cktseStGSVdY?=
 =?utf-8?B?TFRoUkhhSGtVZUxIbk91L2JPT3F2TkxUelNWdGhtb1RQMXpTbHVJeEpJMUdU?=
 =?utf-8?B?YVJpV29uWEhoVkovRElHNndabk9BODhhdlBkc0JnU05kL2gxaE1mTkttcUwz?=
 =?utf-8?B?YjJmTVptYUM3RTVsZVRDRzBYQ0dwYU1MeFNuUlo4NlpBNEEvd1NWajZTcDRF?=
 =?utf-8?B?MVcwUG1ZTGdqUVRna3V3Y0cxVkdTU0dBb3lUUzR6V3AwUzd6ZGpKSVdrSGV3?=
 =?utf-8?B?V1hSd0t3TkpNWmYva1Vjc2JiZzRuRm5nODU0Y3hLUmM4OVNLQ0h6T2t6N3N6?=
 =?utf-8?B?VU1SWi8rUG42dWtabVlSTnNiK1ZlNUFBdGdhZXdjQWRXMnc1cXZSYlhHZUEy?=
 =?utf-8?B?Y3ZJNjBjUVp3am42S3F0eTIwMUVwZDloanZ1bTNieHdsdFpGTnFrK25uSnk0?=
 =?utf-8?B?eU5WemN6b3B4S3p2bEsrd09IVlBsTmI1ZnR1NHNMWXl3SEFBOEg3SXJhWWFZ?=
 =?utf-8?B?YTdLWWExeGxoWUpzSU80a2FUNUpyQksvOVdoaHBSK3kxbW5mU0VtT3Z5Y0F1?=
 =?utf-8?B?aGYxUUh5WGdVZG16cnovYmJNRDhaLzArR0JJdnR6dS8vejNLYkJnKzlmQ3NZ?=
 =?utf-8?B?KzJjWXo2K3V0ZXFUMVJQUjJEWEhrWDBnK3NQeGZ2NFByNXF1RHdaQmUwZG5P?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec97b7dc-abea-4a3b-8ed7-08db271004e7
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 17:49:56.0957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V+axNYpMUgIDuKzZg4QDeWfdMlKoI/3CLd6Ff04syh3dW0Q8lpvBhgKVirClWnTkNduHeV+kNu6BJ/xb2U+c2Nu+Xe4BuAkGyX6SLdqkXfY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7493
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 3/9/2023 6:57 AM, Peter Newman wrote:
> Use ksft_finished() after running tests so that resctrl_tests doesn't
> return exit code 0 when tests fail.
> 
> Consequently, report the MBA and MBM tests as skipped when running on
> non-Intel hardware, otherwise resctrl_tests will exit with a failure
> code.
> 
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette