Date:   Fri, 17 Mar 2023 19:24:31 +0100
From:   Piotr Raczynski <piotr.raczynski@intel.com>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@collabora.com>
Subject: Re: [PATCHv1 1/2] net: ethernet: stmmac: dwmac-rk: fix optional
 clock handling
Message-ID: <ZBSwX+eBsE02A3Xz@nimitz>
References: <20230317174243.61500-1-sebastian.reichel@collabora.com>
 <20230317174243.61500-2-sebastian.reichel@collabora.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230317174243.61500-2-sebastian.reichel@collabora.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?csd7YXli84CZ/Q++fisy45rkyLYpV5GzhfKKBwh0RLNjxkIYdpBXMURf3qGe?=
 =?us-ascii?Q?VKketyACGbb0P5yMfBsWof5XNY4SyTFSfnMb1hpiSxaKdyyPOSf0+oa1rNSN?=
 =?us-ascii?Q?dF/GDEeEZ8g5PuD/MaKPLlEb8V7GlAGMyJOUJwYon9HEg+i9pWwPUl4Fy2sB?=
 =?us-ascii?Q?DQMNmassz3DvxIsvBC+rwYwvBnN57Ys5o+vwYoUSJv5k2XGs6X8iJlxA/mO5?=
 =?us-ascii?Q?/oxHapJibtjlQ8I/9yd9mLv0y/JkCfnKkAo5k7oahu1/gsUl1vU+tUIER5Ha?=
 =?us-ascii?Q?ElRDFShQYktug0JQhUM/R+vCTj8W6AszMOdsGKpSvfcxCOXNLDY+GoSxAMd9?=
 =?us-ascii?Q?31zajgWnwPo2gMle9yvuE7TR69YqDuI6apP7GnKIP7r5jQRy6pu+61WaqNc1?=
 =?us-ascii?Q?5D8Sd1DR/zqzh7JaabHs42yTdC/MWZDQPj4auzfJ7J168eWnsV1e5WREu5kV?=
 =?us-ascii?Q?0KdunWsisb5uUUP7r6HVFAD9YvqTFsA5TNhIDeeob5eGHAB/AVrnFhgSWtaq?=
 =?us-ascii?Q?ZPxMDQSBSPgmqugMFaxO8Sgqp2pIcbrGitc7jokhKLpnzPlAZUwblysv30LK?=
 =?us-ascii?Q?+jWii6X89cF2lYvRzY51uVkfoktsfXFK2GpIkWHxYLe+IJcpkzAP5w9elC6H?=
 =?us-ascii?Q?uIP/+CHMGdspr2LQ0V21FwFyxwE6rwnY9yx//a9MDs1NjlJWmMElYtt9gX34?=
 =?us-ascii?Q?1skgK/6k0Ic1L7EUeZwA7lYS1gP8pAIb1HNhfsDTcZJNeNB7jzvWL2AUPq6m?=
 =?us-ascii?Q?h7yWREwm23FxR91hi7hEISjW5aM5WNs9yAyROzV1UKH+YkAwy5jLNOE7Q+v+?=
 =?us-ascii?Q?FUEWSYJvWl+chQ1aJPbPSus3XCPZi8+DqREep2iuUjKPuMlk0RltRnHbXVP5?=
 =?us-ascii?Q?9u5upfCTsY0Tc+flU2JOoPy2ANkDnSoh84KxDUihXD2pxaRWY7pdRerZlmQz?=
 =?us-ascii?Q?y00uST4eNLUs4DRq0EsYWIoOBsGnV50WcjRW7cCLdnj4Xijw+xpqeMlzkBmg?=
 =?us-ascii?Q?Q4F1ivdMtE3/69GOk6ZtEyCM5jV5atw1eIwq9b8kIE4eg9I/1YFdj4UsEgAU?=
 =?us-ascii?Q?DZ5wlsAdHo0sd44YTb8eZQV8RnaKSH1vMPP2S+n9MP0wVvkYXP+dSZUajMow?=
 =?us-ascii?Q?7zBcIka++Y9fAmYInghNwXdHew4at/fXsKfzn1z13ACXJ6LwBebw8vX/oVsS?=
 =?us-ascii?Q?XoDSZdHfRZQ2cdMH0bxBE0YDt7V5+wFB62nHHJovOJkjNnaegLgk6BQWYCBp?=
 =?us-ascii?Q?MXe4diFXWPdc/Wpyu7c68Hmd6Gxm2H6JwxNqXAgae2yh753Wr4/1ZF6gIOLn?=
 =?us-ascii?Q?b0pdIQuHekwQasaXYHV6qT4qRu+QJLz2uSqwX1BUdXLp7CGTGTLb0Z3Zzwva?=
 =?us-ascii?Q?j1t3sOzT4J3I6snsYhKboN0Pb0RT6Wt9JxEyzB3iCCqKEOPHBf5VnhaVWfi6?=
 =?us-ascii?Q?sZRufkH6ZugD4cBdktIy0MRy0flvbudmcyZ2a20sg18WAZ8IxSI24MNvdrfm?=
 =?us-ascii?Q?peAS6lMtAmqKMEBfdi/OVChdD15n3yJO8pFcPPZmESHAQvLt7+ter1ZaRx6o?=
 =?us-ascii?Q?xDLwpo6276qToLoVbeuGheY092eGBpiQvezakViLeXRoo12rAXo6D/xUpK2m?=
 =?us-ascii?Q?ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50aa8736-77ba-4d97-ff9e-08db2714da8a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 18:24:32.5240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bcGvPLdIkLI6yvkvmwwTZgnIAVlvRjMXQv/SIT7m0qi2drovI+ByDOgVugepIwX7MouI8CR2f98GNOEtAiHbEOfufWVk38ZQot9whbK0Mfc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7657
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 17, 2023 at 06:42:42PM +0100, Sebastian Reichel wrote:
> Right now any clock errors are printed and otherwise ignored.
> This has multiple disadvantages:
> 
> 1. it prints errors for clocks that do not exist (e.g. rk3588
>    reports errors for "mac_clk_rx", "mac_clk_tx" and "clk_mac_speed")
> 
> 2. it does not handle errors like -EPROBE_DEFER correctly
> 
> This series fixes it by switching to devm_clk_get_optional(),
> so that missing clocks are not considered an error and then
> passing on any other errors using dev_err_probe().
> 

Fixes tag would help here.
Piotr
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  .../net/ethernet/stmicro/stmmac/dwmac-rk.c    | 47 ++++++++++---------
>  1 file changed, 24 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> index 4b8fd11563e4..126812cd17e6 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> @@ -1479,49 +1479,50 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat)
>  
>  	bsp_priv->clk_enabled = false;
>  
> -	bsp_priv->mac_clk_rx = devm_clk_get(dev, "mac_clk_rx");
> +	bsp_priv->mac_clk_rx = devm_clk_get_optional(dev, "mac_clk_rx");
>  	if (IS_ERR(bsp_priv->mac_clk_rx))
> -		dev_err(dev, "cannot get clock %s\n",
> -			"mac_clk_rx");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->mac_clk_rx),
> +				"cannot get clock %s\n", "mac_clk_rx");
>  
> -	bsp_priv->mac_clk_tx = devm_clk_get(dev, "mac_clk_tx");
> +	bsp_priv->mac_clk_tx = devm_clk_get_optional(dev, "mac_clk_tx");
>  	if (IS_ERR(bsp_priv->mac_clk_tx))
> -		dev_err(dev, "cannot get clock %s\n",
> -			"mac_clk_tx");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->mac_clk_tx),
> +				"cannot get clock %s\n", "mac_clk_tx");
>  
> -	bsp_priv->aclk_mac = devm_clk_get(dev, "aclk_mac");
> +	bsp_priv->aclk_mac = devm_clk_get_optional(dev, "aclk_mac");
>  	if (IS_ERR(bsp_priv->aclk_mac))
> -		dev_err(dev, "cannot get clock %s\n",
> -			"aclk_mac");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->aclk_mac),
> +				"cannot get clock %s\n", "aclk_mac");
>  
> -	bsp_priv->pclk_mac = devm_clk_get(dev, "pclk_mac");
> +	bsp_priv->pclk_mac = devm_clk_get_optional(dev, "pclk_mac");
>  	if (IS_ERR(bsp_priv->pclk_mac))
> -		dev_err(dev, "cannot get clock %s\n",
> -			"pclk_mac");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->pclk_mac),
> +				"cannot get clock %s\n", "pclk_mac");
>  
> -	bsp_priv->clk_mac = devm_clk_get(dev, "stmmaceth");
> +	bsp_priv->clk_mac = devm_clk_get_optional(dev, "stmmaceth");
>  	if (IS_ERR(bsp_priv->clk_mac))
> -		dev_err(dev, "cannot get clock %s\n",
> -			"stmmaceth");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->clk_mac),
> +				"cannot get clock %s\n", "stmmaceth");
>  
>  	if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) {
> -		bsp_priv->clk_mac_ref = devm_clk_get(dev, "clk_mac_ref");
> +		bsp_priv->clk_mac_ref = devm_clk_get_optional(dev, "clk_mac_ref");
>  		if (IS_ERR(bsp_priv->clk_mac_ref))
> -			dev_err(dev, "cannot get clock %s\n",
> -				"clk_mac_ref");
> +			return dev_err_probe(dev, PTR_ERR(bsp_priv->clk_mac_ref),
> +					"cannot get clock %s\n", "clk_mac_ref");
>  
>  		if (!bsp_priv->clock_input) {
>  			bsp_priv->clk_mac_refout =
> -				devm_clk_get(dev, "clk_mac_refout");
> +				devm_clk_get_optional(dev, "clk_mac_refout");
>  			if (IS_ERR(bsp_priv->clk_mac_refout))
> -				dev_err(dev, "cannot get clock %s\n",
> -					"clk_mac_refout");
> +				return dev_err_probe(dev, PTR_ERR(bsp_priv->clk_mac_refout),
> +						"cannot get clock %s\n", "clk_mac_refout");
>  		}
>  	}
>  
> -	bsp_priv->clk_mac_speed = devm_clk_get(dev, "clk_mac_speed");
> +	bsp_priv->clk_mac_speed = devm_clk_get_optional(dev, "clk_mac_speed");
>  	if (IS_ERR(bsp_priv->clk_mac_speed))
> -		dev_err(dev, "cannot get clock %s\n", "clk_mac_speed");
> +		return dev_err_probe(dev, PTR_ERR(bsp_priv->clk_mac_speed),
> +				"cannot get clock %s\n", "clk_mac_speed");
>  
>  	if (bsp_priv->clock_input) {
>  		dev_info(dev, "clock input from PHY\n");
> -- 
> 2.39.2
>