MIME-Version: 1.0
References: <20230317123314.145121-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20230317123314.145121-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <TYCPR01MB10588B29A18ABE00374AD07A3B7BD9@TYCPR01MB10588.jpnprd01.prod.outlook.com>
In-Reply-To: <TYCPR01MB10588B29A18ABE00374AD07A3B7BD9@TYCPR01MB10588.jpnprd01.prod.outlook.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 17 Mar 2023 18:31:15 +0000
Message-ID: <CA+V-a8sOib64rA3YRkHa3X-SiSpnn70QJK6DDqg7pX05X2phFA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: renesas: rzg2l-smarc: Enable CRU, CSI support
To:     Chris Paterson <Chris.Paterson2@renesas.com>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Chris,

Thank you for the review.

On Fri, Mar 17, 2023 at 6:03=E2=80=AFPM Chris Paterson
<Chris.Paterson2@renesas.com> wrote:
>
> Hello Prabhakar,
>
> > From: Prabhakar <prabhakar.csengg@gmail.com>
> > Sent: 17 March 2023 12:33
> >
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Enable CRU, CSI on RZ/G2L SMARC EVK and tie the CSI to OV5645 sensor
> > using Device Tree overlay. rz-smarc-cru-csi-ov5645.dtsi is created so
> > that RZ/G2L alike EVKs can make use of it.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > setenv bootfile kernel_fdt.itb
> > tftpboot ${bootfile}
> > bootm ${fileaddr}#rzg2l-smarc#ov5645
> >
> > v1->v2
> > * New patch
> > ---
> >  arch/arm64/boot/dts/renesas/Makefile          |  1 +
> >  .../r9a07g044l2-smarc-cru-csi-ov5645.dtso     | 18 ++++
> >  .../dts/renesas/rz-smarc-cru-csi-ov5645.dtsi  | 87 +++++++++++++++++++
> >  3 files changed, 106 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-
> > csi-ov5645.dtso
> >  create mode 100644 arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-
> > ov5645.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/renesas/Makefile
> > b/arch/arm64/boot/dts/renesas/Makefile
> > index 23b10c03091c..a553d99175cb 100644
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -79,6 +79,7 @@ dtb-$(CONFIG_ARCH_R9A07G043) +=3D r9a07g043u11-
> > smarc.dtb
> >
> >  dtb-$(CONFIG_ARCH_R9A07G044) +=3D r9a07g044c2-smarc.dtb
> >  dtb-$(CONFIG_ARCH_R9A07G044) +=3D r9a07g044l2-smarc.dtb
> > +dtb-$(CONFIG_ARCH_R9A07G044) +=3D r9a07g044l2-smarc-cru-csi-
> > ov5645.dtbo
> >
> >  dtb-$(CONFIG_ARCH_R9A07G054) +=3D r9a07g054l2-smarc.dtb
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-
> > ov5645.dtso b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-
> > ov5645.dtso
> > new file mode 100644
> > index 000000000000..40cece1491bb
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-ov5645.dtso
> > @@ -0,0 +1,18 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree overlay for the RZ/G2L SMARC EVK with OV5645 camera
> > + * connected to CSI and CRU enabled.
> > + *
> > + * Copyright (C) 2023 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#define OV5645_PARENT_I2C i2c0
> > +#include "rz-smarc-cru-csi-ov5645.dtsi"
> > +
> > +&ov5645 {
> > +     enable-gpios =3D <&pinctrl RZG2L_GPIO(2, 0) GPIO_ACTIVE_HIGH>;
> > +     reset-gpios =3D <&pinctrl RZG2L_GPIO(40, 2) GPIO_ACTIVE_LOW>;
> > +};
> > diff --git a/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
> > b/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
> > new file mode 100644
> > index 000000000000..95286bf2066e
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/rz-smarc-cru-csi-ov5645.dtsi
> > @@ -0,0 +1,87 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Common Device Tree for the RZ/G2L SMARC EVK (and alike EVKs) with
> > + * OV5645 camera connected to CSI and CRU enabled.
> > + *
> > + * Copyright (C) 2023 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
The above two lines are not required here.

> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
>
> Are either of these includes used in this file?
> Or should they move to the overlay?
>
Good catch, yes they need to be moved into the overlay file instead.

Cheers,
Prabhakar