Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760344AbXIRQov (ORCPT ); Tue, 18 Sep 2007 12:44:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757515AbXIRQon (ORCPT ); Tue, 18 Sep 2007 12:44:43 -0400 Received: from pat.uio.no ([129.240.10.15]:50488 "EHLO pat.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756703AbXIRQom (ORCPT ); Tue, 18 Sep 2007 12:44:42 -0400 Subject: Re: Credentials test patch From: Trond Myklebust To: David Howells Cc: viro@ftp.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <11807.1190133197@redhat.com> References: <1577.1189713412@redhat.com> <11807.1190133197@redhat.com> Content-Type: text/plain Date: Tue, 18 Sep 2007 12:44:17 -0400 Message-Id: <1190133857.6656.20.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit X-UiO-Resend: resent X-UiO-ClamAV-Virus: No X-UiO-Spam-info: not spam, SpamAssassin (score=-0.1, required=12.0, autolearn=disabled, AWL=-0.083) X-UiO-Scanned: EB1A18E88A99CEB66445C27AC30636219ECB7C81 X-UiO-SPAM-Test: remote_host: 129.240.10.9 spam_score: 0 maxlevel 200 minaction 2 bait 0 mail/h: 620 total 3954174 max/h 8345 blacklist 0 greylist 0 ratelimit 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 32 On Tue, 2007-09-18 at 17:33 +0100, David Howells wrote: > Hi Al, Christoph, > > Here's a new version of my credentials patch. It's still very basic, with > only Ext3, (V)FAT, NFS, AFS, SELinux and keyrings compiled in on an x86_64 > arch kernel. The patched kernel compiles, links and runs. > > I've made the following major changes to the patch: > > (1) System calls that might want to use the credentials call > update_current_cred() before calling into the VFS or whatever. This > allows the keyring pointers in the cred struct to be updated. > > (2) I've got rid of current_cred(), __current_cred() and the accessors for > current's fsuid, fsgid and group list. Instead you just use > current->cred->whatever. You don't need RCU to read the current threads > credentials as only you are permitted to change them. > > David > --- What about the process' capabilities? Shouldn't they also be part of a credential? Cheers Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/