Message-ID: <5e6d1cc8-82b0-b854-e244-73ed00997e40@oracle.com>
Date:   Fri, 17 Mar 2023 13:42:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH v19 7/7] x86/crash: optimize cpu changes
Content-Language: en-US
To:     Sourabh Jain <sourabhjain@linux.ibm.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20230306162228.8277-1-eric.devolder@oracle.com>
 <20230306162228.8277-8-eric.devolder@oracle.com>
 <53343c55-c59f-fee7-22f5-94de15a1d18c@linux.ibm.com>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <53343c55-c59f-fee7-22f5-94de15a1d18c@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHZSNzZuQ3dtcjBIU0hobm5PSU9NbzlKc3V4bEt4dDcyRklXT09SKzZ6Y2kz?=
 =?utf-8?B?YjdzeXRDencwZWw3eGdXZGZ1M2lDUHA2cGhPSStDNnJPY093WTNHcUg0NGx1?=
 =?utf-8?B?SThob1psbFVxY1cyR05GNmE1TmZQdmRKaVBTQ2Z4TWM1ZFdwemlJenZMUVR5?=
 =?utf-8?B?QWZHSnlIMWlsYUJQZHZqSkkvLzNaNnlPV0p6dno2OW1adTAreUROOFJHbURu?=
 =?utf-8?B?eTFlb1NOUFhZVXl3UVI5Wi9jYlVPaWI5NzQzcXl4ZkM3ejhGNExxV2orU2NI?=
 =?utf-8?B?NlBSZUVuenE3SmorMUZacGpiVHREM2NkVU95TGlTZDlaUEo1enBMMmhsMm1m?=
 =?utf-8?B?RlZsUThFT0Nza3hWWEpUYnZBb0E3WURNWnd5MWZvUGZ5SU0zTlcyMmxmc0Er?=
 =?utf-8?B?N2h5dTEvdktEemI0UHZLTlZVdzM4V2FXZ0ZpNDlQZTRaTTNOTXR0cVI4SHA4?=
 =?utf-8?B?ZXhFRklqQkpkeW95N2RUKzNFaFNJeXk4M0ZjNHVjNWNZUmh5bUJBSDg1VzVW?=
 =?utf-8?B?Mm5jdnh2c0xYNFR0aVhqdEVOU2pSdCtzRXY5UWpGTmUzcGl3M0hTWnBpT3BL?=
 =?utf-8?B?S1BzR1dCc2dZWFIvM3JpTjNPblkrR3lINkppMzlGdHU3YWRyTUg3UU9NTDQw?=
 =?utf-8?B?UHpvb0Z3eHBURHlXT0FFSW1qZStVOHhmNXBWaXgrekRpZDNvSytOdkptV01v?=
 =?utf-8?B?L1pLOGVrRUtuWStzSVVFZkV1OHlDbGludGJIK1lWa1JVN2dvRlkzVC9HU2ls?=
 =?utf-8?B?ZmZWTzRzeWhDczRHNUdYLytFYS9kTEZFZVljZWlLcFZ2RGptU1VGTHpZZUhX?=
 =?utf-8?B?b0RxZG0yazVtcTA1NUpsTzFSdE5RTG5QajRjMVpwTW9LdHIwSjdaeVpYMmVU?=
 =?utf-8?B?elBnbnRlQ2VVUVAxWEx3ZjFSOGtwZml4bjhYQjVQeGh5SlJmdThIdWE2SGZv?=
 =?utf-8?B?eVAwS0tUTmFlSHFSNWROMlNnZG9mQTYxZ1hzV05DVGhTTWs4NjdaRkZmTDhL?=
 =?utf-8?B?SkFFVkxoZnFTWHJFOFRneHZUTDBqNE9xZGxvTlQvMC9FMW9zOHFZbVhyRlNV?=
 =?utf-8?B?K1l1S051aldLWVg5RFZ2WXpHM3JCRVI1NU5hVFBMSVlyVkZSckc0STJuOXdm?=
 =?utf-8?B?QnJTYm1iMXp2cWFFcUkzMnN5SHYzTDdnRVBPd0x4OUU1KzZqMUJVQ0hEQ0t3?=
 =?utf-8?B?SnZPSXBwUVk2R0ZXVnJhQ2E2NzNQTDlOSHo2VGtMeGVLanA5Qzh5WTlYblcz?=
 =?utf-8?B?NjZHdGV2T0VzR1JaRDJGYUswdHNnZFFHV0pvQW5LT1JEcmdKTGNLeVluQkoz?=
 =?utf-8?B?TjRad0tpZmtrMHRtdUVnWlZZNCtXZ3Y3U2ZUeEM3RVcrK3h3K1NtcXZPRFhE?=
 =?utf-8?B?L1oxVjlDRUFDRTlkU1RIejNwYVE0MXN6RmZYaHUvdk9XZFVNTnh1QlhMQitn?=
 =?utf-8?B?YlJLNlhtb3BnS2dvNGxURXRNT0k5eFRvY2RiTDVadmtXWVRRekNHdjZtbVly?=
 =?utf-8?B?NHZ0UXc4em9YNE5oU051WlRTc2V5VXNlblozWUo2VGVUNEJhR2pMZ1Q0VzNT?=
 =?utf-8?B?S3lraDJtamhHY1Y2dy9XZTBpT05lc0NwYTJxc0RvV3BxRlpJekIwZ2tjNXRC?=
 =?utf-8?B?QVkxZlErWW5pdVdxT09VazhQLzZodDJTNkpxNE5Yem5CTFVWNXRWakRYYW5x?=
 =?utf-8?B?bDZPN04yWGhyQXFlSms5K0J6Y2p4SmtUVDJsa2c5WG5qNG5aSEoyWllTNXpX?=
 =?utf-8?B?NHBvUnZHQWZ6dmFVNHAzK2NWZFVzWkUzY3A3VHBTUEJGZmgyNFJDWXlIOE11?=
 =?utf-8?B?UWdvenJzZm43emZJczJNUHl1QUhwb29GV0QxejlwLzhvT0dvT0pMdnROUUd5?=
 =?utf-8?B?QlNZNFdlQm9CRVJ5azV5WTdLMHQ3L21MZ0lEMlR0SGl4TXIxT1RHZTdTeHR6?=
 =?utf-8?B?N05kbWFSWTZsaXp0QURiVnVxRXNiV3oyeVpXV2c4KzYwa2xjVFBCOTlwZHBW?=
 =?utf-8?B?d0RrdCsySGgxYk1GRnBiOTNpYUpHcjEyRVE1SldOQWJvUmtLcFpZcDl1NURZ?=
 =?utf-8?B?Y3VlV0l3QUxlcXdBL1IwcWNyN1lJTmphTXlOUW1BRmlZdTc0c2dhaUhDbkdQ?=
 =?utf-8?B?NzB4VlpRSi9ML045eWw4YUR3Ni9RL1NoU0w4UWtZejVxUWRxNTU2S2t3RWZx?=
 =?utf-8?Q?DEF3Boys2SP8IoexLYO1Fwk=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?TTNQYUZKa1dUc21SM2tSNlFkbjUrdEw1bHBMY1Vrc3pPcnZSbmFLWXk1QVUy?=
 =?utf-8?B?R1RMaElDYi94V05FSnRBVm5yMytWelRzWjF2YlZ0Q05DdCtPQytSa3p5dE5E?=
 =?utf-8?B?eFpWbkt3L3M4ZEorL1ptRlYwa2luRk5qRm1pVERibjBRbkN1RnFCUVU1VEJw?=
 =?utf-8?B?WGlDMjBDamRpSXZCaEltT25KZ1hXdzhla0FOV0JUb3VlYWpOZEo1QkRqRmVN?=
 =?utf-8?B?S2U2MWtMM0FaYytZQkNSVERTL2xBTmkzYSt6ODRZMUtNczYrbzYwai9kbVFh?=
 =?utf-8?B?UFJMSWRWdkt4T3VFTVlBUHN0QStDZzNtd2k0VXJTT3NXMkR3YjhkSlVkWjVQ?=
 =?utf-8?B?T1liNDlBV3p6WjhORWxuTm1YZlFGeDk5aXpPMUVidkZFaWlwbTdmYnl0K2I0?=
 =?utf-8?B?cnNFTzBweS90U0xvaUovUUhKTkJYY0c4SXN5QWppQTdnZTE5a0czU2t1SUZV?=
 =?utf-8?B?QVJ3d3dNOVI1YUlaZHg5UUNvVmVKV0FWdVQyTjdQWGRUTzUrajd5UXZOQ0hK?=
 =?utf-8?B?Y1VBOGlkVW8ydjliaHdYei9ObzVzMWQ2YzRlR0o5aWd5SlptZUx0UEtTUE15?=
 =?utf-8?B?Sng2WW9OUzVFa0VlZTFpemg1N2REQk1TWHNnUWNVT3BwK2plYlYyQ3AzK1Yy?=
 =?utf-8?B?SDVGTDlkTFJNVWFLdTZ6cmNaTUU2TzdvYnJCckFtbGpQVVlzZy9xNlQrQVVn?=
 =?utf-8?B?b1JHZ2FOWmpsS2RjR1dmS2NnTXcrWW8vV1JPa2lhaDIyY3RvOFlIcmlBdEl6?=
 =?utf-8?B?VUczR0Z2U1NhK1JQNXIyVG53SmoxNUxDeWtlUnlYWkxUemFMdnBPdVRWME9m?=
 =?utf-8?B?bEVKcTdTY09LVS95eCtpbzhqOVZpT0g0VmI1WUFOcWtOVzlmdmdKdWdVRldq?=
 =?utf-8?B?cFNrZlUrY2ttQzA2QnNvM2pueTNJMTZiVlRKTEo2YUZXSXY1aUJOejJ0Z1hY?=
 =?utf-8?B?SndDZDNlUmZsa09XdnhzaTM5UWhsclVSQ3RFZ0tnWmtQUE5yUXBHb05EOFFy?=
 =?utf-8?B?NC9XeGVabUI5R1BEZnJVYSs1YnFyNkZMOGdrSTk4cUlvdW80UXROY2tUb1hx?=
 =?utf-8?B?TzFUYlo5V2QvaVlvQ1RKMjk3dXROZ1JPY2pmamRhZTE5RUx6UTZIb25OeTVG?=
 =?utf-8?B?WTRWRjg1azllTHpTa09lTXU1Q2NwWGJNYTJUYmJaNGQyb2lSeG5oenc5ZmlG?=
 =?utf-8?B?emFnanFvbXZuYTFYalkxN3pUT3JkaVBVRGJ0akNwUjFsY0JFUE5NWEw0dFR3?=
 =?utf-8?B?b2k1bjJ2c2NZSHF4citwN0NvQWt6UUdsQWhrZlNoYytKazkydXNlOWJHZEd0?=
 =?utf-8?B?SXhLQk1lb3FPQUluelV3KzFNY2NJamtJYk4zZjBWT0E4cFZrV3M4ckgwK20v?=
 =?utf-8?B?d0VaOWpFWkUxZ3pDUzBQblg1ZFJ2cXlCTnFWdXJCQ2k3VVBmSjNkZWJxS1ZG?=
 =?utf-8?B?d1dFaGJIVmtjS0REN2lLV0dRV0RHdFdRQ2M4RlZvY2VYN1lIV2k3Y2FZYkxF?=
 =?utf-8?B?N2xVQVRMdXZ2bURXWCtrMUo0Snk3RUkwZjJrcmhjdHdFQ2ozOHB1VmV2T3J3?=
 =?utf-8?Q?615QTaYxSIxDEzxz/z13URPos=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9133f29-1667-4fe0-a483-08db27175ba6
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 18:42:28.3591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E/hH3EeH1j+qx6s5/wRd7BQj2I+mWZ2rs0UTHURxLuYzI5S7EMRE1A0OwpfErDra4cjQe8k0A97TLSwwnZwJgPU1jmatlPBbEwul5CBz3C4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6141
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-17_14,2023-03-16_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 bulkscore=0
 adultscore=0 phishscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303170128
X-Proofpoint-GUID: FDMkk4x_VLXJTgsHTtIswOq5pBIyn0uh
X-Proofpoint-ORIG-GUID: FDMkk4x_VLXJTgsHTtIswOq5pBIyn0uh
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/7/23 03:00, Sourabh Jain wrote:
> 
> On 06/03/23 21:52, Eric DeVolder wrote:
>> This patch is dependent upon the patch 'crash: change
>> crash_prepare_elf64_headers() to for_each_possible_cpu()'. With that
>> patch, crash_prepare_elf64_headers() writes out an ELF cpu PT_NOTE
>> for all possible cpus, thus further cpu changes to the elfcorehdr
>> are not needed.
>>
>> This change works for kexec_file_load() and kexec_load() syscalls.
>> For kexec_file_load(), crash_prepare_elf64_headers() is utilized
>> directly and thus all ELF cpu PT_NOTEs are in the elfcorehdr already.
>> This is the kimage->file_mode term.
>> For kexec_load() syscall, one cpu or memory change will cause the
>> elfcorehdr to be updated via crash_prepare_elf64_headers() and at
>> that point all ELF cpu PT_NOTEs are in the elfcorehdr. This is the
>> kimage->elfcorehdr_updated term.
>>
>> This code is intentionally *NOT* hoisted into
>> crash_handle_hotplug_event() as it would prevent the arch-specific
>> handler from running for cpu changes. This would break PPC, for
>> example, which needs to update other information besides the
>> elfcorehdr, on cpu changes.
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> ---
>>   arch/x86/kernel/crash.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
>> index c9aaec9de775..82ea2b1bdc61 100644
>> --- a/arch/x86/kernel/crash.c
>> +++ b/arch/x86/kernel/crash.c
>> @@ -471,6 +471,16 @@ void arch_crash_handle_hotplug_event(struct kimage *image)
>>       unsigned long mem, memsz;
>>       unsigned long elfsz = 0;
>> +    /* As crash_prepare_elf64_headers() has already described all
>> +     * possible cpus, there is no need to update the elfcorehdr
>> +     * for additional cpu changes. This works for both kexec_load()
>> +     * and kexec_file_load() syscalls.
>> +     */
>> +    if ((image->file_mode || image->elfcorehdr_updated) &&
>> +        ((image->hp_action == KEXEC_CRASH_HP_ADD_CPU) ||
>> +        (image->hp_action == KEXEC_CRASH_HP_REMOVE_CPU)))
>> +        return;
> 
> I like the idea of having elfcorehdr_updated to track elfcoredhr segment updates.
> It handles the possible CPU thing for kexec_load syscall nicely.
> 
> Thanks for incorporating the possible CPU change.
> 
> The patch series looks good to me.
> Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>
> 
> - Sourabh Jain
> 
Thanks for the RB! Look for v20 very soon.
eric