Message-ID: <06cc8339e30eb38175e04058b69b41ca.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230317141622.1926573-4-quic_mohs@quicinc.com>
References: <20230317141622.1926573-1-quic_mohs@quicinc.com> <20230317141622.1926573-4-quic_mohs@quicinc.com>
Subject: Re: [PATCH v9 3/4] clk: qcom: lpassaudiocc-sc7280: Add required gdsc power domain clks in lpass_cc_sc7280_desc strcuture
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Mohammad Rafi Shaik <quic_mohs@quicinc.com>
To:     Mohammad Rafi Shaik <quic_mohs@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, broonie@kernel.org,
        konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com,
        quic_plai@quicinc.com, quic_visr@quicinc.com, robh+dt@kernel.org,
        swboyd@chromium.org
Date:   Fri, 17 Mar 2023 11:43:22 -0700
User-Agent: alot/0.10
Precedence: bulk

Just remove strcuture from the subject.

Quoting Mohammad Rafi Shaik (2023-03-17 07:16:21)
> Add the gdsc's in lpass_cc_sc7280_desc strcuture,

s/strcuture/struct/

> When qcom,adsp-pil-mode is enabled, gdsc's required to solve

Just 'GDSCs', because gdsc isn't owning anything.

> dependencies in lpass_audiocc probe.

I think you're saying that we need to register the GDSCs when
qcom,adsp-pil-mode is set in the qcom,sc7280-lpassaoncc node. Otherwise,
we don't get any GDSCs provided by that node when we should always be
providing them.

>=20
> Fixes: 4ab43d171181 ("clk: qcom: Add lpass clock controller driver for SC=
7280")

If the above is right, then this fixes tag is wrong. It should really be=20

Fixes: 0cbcfbe50cbf ("clk: qcom: lpass: Handle the regmap overlap of lpassc=
c and lpass_aon")

right?