Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7274C74A5B for ; Fri, 17 Mar 2023 19:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjCQTPE (ORCPT ); Fri, 17 Mar 2023 15:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbjCQTPC (ORCPT ); Fri, 17 Mar 2023 15:15:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F08EDCF54 for ; Fri, 17 Mar 2023 12:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679080427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ztGk+FDLapVOGmVmFaxYJiKEGt8g1pDCbQl/HqGei0o=; b=GKrYeD4TSeVGfLLHQ+BFagnKB9bQ731Aj+V3sJZnrrCeHg6Sr/nb+FyB2TdW1g0fUm6bNV j2ef5X3kJakljc8I99ShGUF58YRO9tjxgBnTu33veyD7mQvQbzy2GIYBwP1/HjYK7smWv5 3FU6+lx11yJ6J2irYprV6kiPMlTeeWA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-ADoCsd02M4GpbiJ3wp3jrw-1; Fri, 17 Mar 2023 15:13:46 -0400 X-MC-Unique: ADoCsd02M4GpbiJ3wp3jrw-1 Received: by mail-qt1-f198.google.com with SMTP id l2-20020ac87242000000b003bfecc6d046so3019119qtp.17 for ; Fri, 17 Mar 2023 12:13:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679080425; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ztGk+FDLapVOGmVmFaxYJiKEGt8g1pDCbQl/HqGei0o=; b=gTJGX95HXY+JCgXTDpp11AdNdsABcD9QXy4aJIcjk3T0ItF6TvdDwlcTmhd7kh7IJu NByP+0ZAWwNWri4F1QNSQRmtPhsEcroFHzlt84Jm6C9JshdFEvSZkcX5LVE5csJdccz/ xJKYeobnIWK1mkhWbYarJy8yULfBFn3GRE2uFT+eimz0HxPN6/n5l8g7dc6UHuc1z2K9 7OsB624204r550gWiLhmjjG+GAcGP9gwlJcj5RLhqrHjfBqTdWuKpmEK2ySixyBRQ92o G76YehmOwrTKKfuV8w04lzc4CCN6QdV+MH244iwj2vzm2Y/6m/df9TqAc3qlvx9wNQYr cjTQ== X-Gm-Message-State: AO0yUKVirDY8lcCJtXl8jDeCTYLSbu5K3c95vb/Hj+N2oB+q1ybogina eUeqrnSqu2lChDRjrRofjpli8AKlD/fjfTca97x/fnVqB5XnNNc14MEaidf31ERRxLTzTYwOeIM Fv6Te9bXwgb3jhUMRSf860gbYqfD/K91u X-Received: by 2002:ac8:7d0c:0:b0:3d7:b045:d39 with SMTP id g12-20020ac87d0c000000b003d7b0450d39mr12113669qtb.62.1679080425620; Fri, 17 Mar 2023 12:13:45 -0700 (PDT) X-Google-Smtp-Source: AK7set9jusCj+LruNqU0NMMLlDwg/wMopjnFU5EEIhYBjZu9tyVtWiiTtf7DPciJ3H1xhigYUlMWBQ== X-Received: by 2002:ac8:7d0c:0:b0:3d7:b045:d39 with SMTP id g12-20020ac87d0c000000b003d7b0450d39mr12113637qtb.62.1679080425373; Fri, 17 Mar 2023 12:13:45 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m17-20020ac84451000000b003c03b33e6f5sm1698622qtn.90.2023.03.17.12.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 12:13:45 -0700 (PDT) From: Tom Rix To: pavel@ucw.cz, lee@kernel.org, quic_fenglinw@quicinc.com Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static Date: Fri, 17 Mar 2023 15:13:41 -0400 Message-Id: <20230317191341.1670660-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smatch reports drivers/leds/flash/leds-qcom-flash.c:103:18: warning: symbol 'mvflash_3ch_regs' was not declared. Should it be static? drivers/leds/flash/leds-qcom-flash.c:115:18: warning: symbol 'mvflash_4ch_regs' was not declared. Should it be static? These variables are only used in leds-qcom-flash.c, so it should be static. Signed-off-by: Tom Rix --- drivers/leds/flash/leds-qcom-flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c index 406ed8761c78..90a24fa25a49 100644 --- a/drivers/leds/flash/leds-qcom-flash.c +++ b/drivers/leds/flash/leds-qcom-flash.c @@ -100,7 +100,7 @@ enum { REG_MAX_COUNT, }; -struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { +static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x08, 0, 7), /* status1 */ REG_FIELD(0x09, 0, 7), /* status2 */ REG_FIELD(0x0a, 0, 7), /* status3 */ @@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x4c, 0, 2), /* chan_en */ }; -struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = { +static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x06, 0, 7), /* status1 */ REG_FIELD(0x07, 0, 6), /* status2 */ REG_FIELD(0x09, 0, 7), /* status3 */ -- 2.27.0