Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA53C7618A for ; Fri, 17 Mar 2023 19:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbjCQTSw (ORCPT ); Fri, 17 Mar 2023 15:18:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbjCQTSu (ORCPT ); Fri, 17 Mar 2023 15:18:50 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F6564FCE3 for ; Fri, 17 Mar 2023 12:18:44 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id l9so3278712iln.1 for ; Fri, 17 Mar 2023 12:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679080723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JNyqPnjPM6N9FSs6YBQxZ2x4/vS8WMo8VSoqSexsTZk=; b=BHx3Zy1PVjKo0fBmpJ6/8Z+06pjd45FyUK9csS3AxNrD19etcpUppie58ByAzXPKKf zo5y4bRQZGPQI4pPcWZND85bOuIqREQS3V0X5hsEurdwsco1EbKG731fdoYekmsamDyx Eho9WTRU0Obv4A2Q/jxJE+BKYAjAXoWQgRoCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679080723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JNyqPnjPM6N9FSs6YBQxZ2x4/vS8WMo8VSoqSexsTZk=; b=YKDyUTePmQ8d/xEsM7zACtz9lRTNrBtvEbyEhbVYbcLPcGq428UtsXmQ6zONJTMOOY rjTsdslthGv1LI2TggIZXo13M32jgQr5IwXKwmZOh+fiYurBeUVJTMSYAUwMD8IxARQz GFtV+ldA3GAJEx2639nZh+NFqKbXzskY5mrLr7dMAtqLAqVN1W9HH3aljqYFRv6v4hIo PzHX7q2WD3p7Pkzka60oL2G5pFcGzoQN7Jj8P5GAxyq0GA0Y3Hc2huJ9bmSm7YwszSos fHoSyMiSDpb7ivgnZ8rTsivKtyuWaySBuYFv6ZLArt6b598IN0XJyMcWeOCgqKmMCGfV mpSw== X-Gm-Message-State: AO0yUKW6FAUV9YWenKRrnj0vEOG1AyReA0zi+/Y7U20xhxAyeIAiU2jz 88EX4VyG0xarm9FclBnPS2sO4Q== X-Google-Smtp-Source: AK7set9chDGhcsD/yWOUfEXjdOD46c7r6BRZzFv5h9gUYsgKbDj51dORwteGVrWLT/AX/I9Yax6quw== X-Received: by 2002:a92:6b06:0:b0:316:e6e4:570b with SMTP id g6-20020a926b06000000b00316e6e4570bmr308718ilc.11.1679080723406; Fri, 17 Mar 2023 12:18:43 -0700 (PDT) Received: from markhas1.roam.corp.google.com (174-16-151-48.hlrn.qwest.net. [174.16.151.48]) by smtp.gmail.com with ESMTPSA id g8-20020a056e02130800b003230c7d6a3csm805813ilr.67.2023.03.17.12.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 12:18:43 -0700 (PDT) From: Mark Hasemeyer To: jsd@semihalf.com Cc: andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, rrangel@chromium.org, upstream@semihalf.com, wsa@kernel.org, dabros@google.com Subject: [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver Date: Fri, 17 Mar 2023 13:18:34 -0600 Message-Id: <20230317191834.186690-1-markhas@chromium.org> X-Mailer: git-send-email 2.40.0.rc2.332.ga46443480c-goog In-Reply-To: <20220916131854.687371-3-jsd@semihalf.com> References: <20220916131854.687371-3-jsd@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - /* Status field in command-response buffer is updated by PSP */ - status = READ_ONCE(req->hdr.status); + if (req) { + /* Status field in command-response buffer is updated by PSP */ + status = READ_ONCE(req->hdr.status); + } else { + status = psp_smn_read(PSP_MBOX_CMD_OFFSET, &status); + status &= ~PSP_MBOX_FIELDS_READY; + } The value of the mbox cmd register is getting clobbered by the return value from psp_smn_read. This can cause bus arbitration to fail as the driver will think it can grab the bus when it's actually in use by the PSP.