MIME-Version: 1.0
References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-20-lee@kernel.org>
In-Reply-To: <20230317081718.2650744-20-lee@kernel.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 17 Mar 2023 16:28:35 -0400
Message-ID: <CADnq5_NhOpGd0rG_TVFFfZsk9aFy6Lu+nJ87TdTKAubkXpomXw@mail.gmail.com>
Subject: Re: [PATCH 19/37] drm/amd/pm/swsmu/smu11/vangogh_ppt: Provide a
 couple of missing parameter descriptions
To:     Lee Jones <lee@kernel.org>
Cc:     dri-devel@lists.freedesktop.org,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, Li Ma <li.ma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Evan Quan <evan.quan@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Mar 17, 2023 at 4:23=E2=80=AFAM Lee Jones <lee@kernel.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2381: warning=
: Function parameter or member 'residency' not described in 'vangogh_get_gf=
xoff_residency'
>  drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:2399: warning=
: Function parameter or member 'entrycount' not described in 'vangogh_get_g=
fxoff_entrycount'
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Li Ma <li.ma@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/g=
pu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 4590374251f3b..7433dcaa16e04 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -2389,6 +2389,7 @@ static u32 vangogh_set_gfxoff_residency(struct smu_=
context *smu, bool start)
>   * vangogh_get_gfxoff_residency
>   *
>   * @smu: amdgpu_device pointer
> + * @residency: placeholder for return value
>   *
>   * This function will be used to get gfxoff residency.
>   *
> @@ -2407,6 +2408,7 @@ static u32 vangogh_get_gfxoff_residency(struct smu_=
context *smu, uint32_t *resid
>   * vangogh_get_gfxoff_entrycount - get gfxoff entry count
>   *
>   * @smu: amdgpu_device pointer
> + * @entrycount: placeholder for return value
>   *
>   * This function will be used to get gfxoff entry count
>   *
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>