Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7D2C74A5B for ; Fri, 17 Mar 2023 20:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbjCQU60 (ORCPT ); Fri, 17 Mar 2023 16:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbjCQU6T (ORCPT ); Fri, 17 Mar 2023 16:58:19 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA7A2399D6 for ; Fri, 17 Mar 2023 13:58:16 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-54184571389so116381257b3.4 for ; Fri, 17 Mar 2023 13:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679086696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=78yALmTsSciSeto27pgZIDoTUCcCZg0Xi7D0VKEquOI=; b=ReNqhlEAqD/sjcsPCojeM9w+k8jN3tbhjOvqFb5lB6b1itAJPunkb/lHyjF8e2zKyT JDo7lBArgVDBe0QdACN1oz12hmgq1mcaaUzJ4pX6igZKfxBSsbueysICZR/nxsoSeLsA fW4NL4S7AAmQIppB1LVJeo0iFltJzFmISdTpePZCIZ11udmbpU+XWOkvLaItCnrEkg4Z aTvXk7Lcfan9TvvbJWh7rPgUQb+TkyC7tDJGoX56xfEqSsDHiVzT0IO97mCFgLOjsSQt Y29K+xdi48dUhkt7rp1yj+yvJ/BL+7dUci2Po0wG2FDdQttm7+3Vlx02uUlpYCt0YDf6 Btnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679086696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=78yALmTsSciSeto27pgZIDoTUCcCZg0Xi7D0VKEquOI=; b=YiG7l4FBCLLIxgegS9SorB80c9wf0EnUC3kCM5vWEEp5rqTVvS4JDNlOKVdRo76ev9 iiYBQiuGwjBDin2q/bA9wlTyKIr3aBOJ569niSM1tGkZXbnh++9VPGcDs+yySe2ebVK0 R292mSWJhdFsXhwMg5KwiSPLSnTvtJO3L8WOV2Fo1/3y0NvQEoMURP16ZilWeyRCSahg PmU1F/Xg8IjDSa2TZVaUXazyMle0/yoPAbKm0G0uO8zDkp6VEchFty2MJV+IH4q8r+Ob LcQuUKX9E+qZ13KD5cfqxrW+qii0483P0g8jHhHfP6hR2n1gdjaFZw6tjgr0CxqFgxLs 2qFw== X-Gm-Message-State: AO0yUKUqgB/WzZ63I+35BCnIrGWbM1VLK3Pww0lSnf+yA3jaWsPSXRAa JUfPNEMTYAneHzI5Qk6CSrz4VrxJteby4D1xKks94kEqC623a3/I X-Google-Smtp-Source: AK7set/ZRWZmr4fK9BRzq5dNAUC2K47cgi7Bwlzsv/gVUp7p6JUstQoJ4CPHuimwv8Pv/cAkKKJ7oBLmS6UNDDVaUFQ= X-Received: by 2002:a81:c645:0:b0:53d:2772:65d with SMTP id q5-20020a81c645000000b0053d2772065dmr5177050ywj.9.1679086695996; Fri, 17 Mar 2023 13:58:15 -0700 (PDT) MIME-Version: 1.0 References: <1679070482-8391-1-git-send-email-quic_mojha@quicinc.com> <1679070482-8391-3-git-send-email-quic_mojha@quicinc.com> In-Reply-To: <1679070482-8391-3-git-send-email-quic_mojha@quicinc.com> From: Linus Walleij Date: Fri, 17 Mar 2023 21:58:04 +0100 Message-ID: Subject: Re: [PATCH v3 2/5] pinctrl: qcom: Use qcom_scm_io_update_field() To: Mukesh Ojha Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2023 at 5:28=E2=80=AFPM Mukesh Ojha wrote: > Use qcom_scm_io_update_field() exported function introduced > in last commit. > > Signed-off-by: Mukesh Ojha Fine by me, but I want you to first consider switching the custom register accessors to regmap. Yours, Linus Walleij