Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C00C6FD1D for ; Fri, 17 Mar 2023 22:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjCQWVb (ORCPT ); Fri, 17 Mar 2023 18:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbjCQWV3 (ORCPT ); Fri, 17 Mar 2023 18:21:29 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8729C8C5AA; Fri, 17 Mar 2023 15:21:26 -0700 (PDT) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8DE4E40003; Fri, 17 Mar 2023 22:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1679091684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1H0b+8pt3zecfZdT4Lt4hoL0pnvHKD6pkdBtwNxvW4=; b=hJ5LBiF1mKl2oulAqe7KSjjKGLbCZw1yF7Sc+jPyNHe5He6DEIw3OKO36ROWMv3xJfcjfo yQCThlu4bNCKzClbHV/hgDnTHhyrKFLaS+hHB+J323GaZC5MRzwfVPIXuRUSswx+m95XT8 DKzTeZfrJ3u7mRBsHqEsh3Oz2NlZwYVCVhTu+SGSEkkmi8grjOKaNp5eMWNoBUWwAUj9GP FZNLslGB024APPJcabeY2gUrfszNDkes8eD4Mgu6Ni9UN+U5gKRZJ4d6lEJ+qb7U0LxBD2 Uno1kxl1rBW4gEM7nwQw8AEyiymx/Hkcw6k4AwIzeS2jVPBtEYa/oIl/bLQsDA== Date: Fri, 17 Mar 2023 23:21:22 +0100 From: Alexandre Belloni To: Alessandro Zummo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring Cc: devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence Message-ID: <167909163830.117471.962092693437106290.b4-ty@bootlin.com> References: <20230310144736.1547041-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310144736.1547041-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Mar 2023 08:47:36 -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > [...] Applied, thanks! [1/1] rtc: sun6i: Use of_property_present() for testing DT property presence commit: 4d9890ac9d43d4dfd011110ab96633caa6fa829c Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com