MIME-Version: 1.0
References: <20230315195405.2051559-1-ssreevani@meta.com> <20230317225259.GA28462@maniforge>
In-Reply-To: <20230317225259.GA28462@maniforge>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 17 Mar 2023 16:19:52 -0700
Message-ID: <CAEf4BzaZ95Gv3Dkke+1gv1nRG41sroMaFb8Lqv93G7LAL7XBCA@mail.gmail.com>
Subject: Re: [PATCH V4 bpf-next] BPF, docs: libbpf Overview Document
To:     David Vernet <void@manifault.com>
Cc:     Sreevani Sreejith <ssreevani@meta.com>, bpf@vger.kernel.org,
        psreep@gmail.com, andrii@kernel.org, mykolal@meta.com,
        Linux-kernel@vger.kernel.org, bagasdotme@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 17, 2023 at 3:53=E2=80=AFPM David Vernet <void@manifault.com> w=
rote:
>
> On Wed, Mar 15, 2023 at 12:54:05PM -0700, Sreevani Sreejith wrote:
> > From: Sreevani <ssreevani@meta.com>
> >
> > This patch documents overview of libbpf, including its features for
> > developing BPF programs.
> >
> > Signed-off-by: Sreevani <ssreevani@meta.com>
>
> Looks great, thanks Sreevani.
>
> Acked-by: David Vernet <void@manifault.com>
>

Applied suggestions and switched to consistent "=3D=3D=3D=3D=3D" over/under=
 top
level header in both files. Applied to bpf-next, thanks!

> > ---
> > Changelog:
> >
> > v3 =3D https://lore.kernel.org/all/20230310180928.2462527-1-ssreevani@m=
eta.com/
> > v3 -> v4:
> >    * Update BTF types link
> >    * Update patch summary
> >    * Indent code options line
> >    * Update "See also" wording
> >
> >  Documentation/bpf/libbpf/index.rst           |  27 ++-
> >  Documentation/bpf/libbpf/libbpf_overview.rst | 228 +++++++++++++++++++
> >  2 files changed, 246 insertions(+), 9 deletions(-)
> >  create mode 100644 Documentation/bpf/libbpf/libbpf_overview.rst
> >
> > diff --git a/Documentation/bpf/libbpf/index.rst b/Documentation/bpf/lib=
bpf/index.rst
> > index f9b3b252e28f..3ac8c06fb8f4 100644
> > --- a/Documentation/bpf/libbpf/index.rst
> > +++ b/Documentation/bpf/libbpf/index.rst
> > @@ -2,23 +2,32 @@
> >
> >  .. _libbpf:
> >
> > +######
> >  libbpf
> > -=3D=3D=3D=3D=3D=3D
> > +######
> > +
> > +If you are looking to develop BPF applications using the libbpf librar=
y, this
> > +directory contains important documentation that you should read.
> > +
> > +To get started, it is recommended to begin with the :doc:`libbpf Overv=
iew
> > +<libbpf_overview>` document, which provides a high-level understanding=
 of the
> > +libbpf APIs and their usage. This will give you a solid foundation to =
start
> > +exploring and utilizing the various features of libbpf to develop your=
 BPF
> > +applications.
> >
> >  .. toctree::
> >     :maxdepth: 1
> >
> > +   libbpf_overview
> >     API Documentation <https://libbpf.readthedocs.io/en/latest/api.html=
>
> >     program_types
> >     libbpf_naming_convention
> >     libbpf_build
> >

[...]