Date:   Sat, 18 Mar 2023 08:56:45 +0530
From:   Bhaskar Chowdhury <unixbhaskar@gmail.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "nicolas@fjasle.eu" <nicolas@fjasle.eu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] Kbuild: Elevate sha1sum to sha256sum for atomic headers
 check
Message-ID: <ZBUvddx7PkTZHj4Y@Gentoo>
Mail-Followup-To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        David Laight <David.Laight@ACULAB.COM>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "nicolas@fjasle.eu" <nicolas@fjasle.eu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
References: <20230315130518.4496-1-unixbhaskar@gmail.com>
 <0bbdd88ca0cb465a85d7b90ebacb5e83@AcuMS.aculab.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="n9V0ZVZceJnPTOYA"
Content-Disposition: inline
In-Reply-To: <0bbdd88ca0cb465a85d7b90ebacb5e83@AcuMS.aculab.com>
Precedence: bulk


--n9V0ZVZceJnPTOYA
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

On 08:58 Fri 17 Mar 2023, David Laight wrote:
>From: Bhaskar Chowdhury
>> Sent: 15 March 2023 13:05
>>
>> Thought it would be a good idea to use a elevated mechanism i.e sha256sum
>
>How can this change possibly work.
>It is just a list of definitions read by another makefile.
>You've changed the name of a definition without changing where it is used.
>Also if the code is looking for a change, you'd need to change
>what it is compared against.

Gotcha. Thanks for the heads-up , David. I missed it.

>In any case no one is worried about malicious attempts to change
>things without being noticed, even sha1 is OTT.
>
>        David
>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  Kbuild | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/Kbuild b/Kbuild
>> index 464b34a08f51..b74040346d76 100644
>> --- a/Kbuild
>> +++ b/Kbuild
>> @@ -45,14 +45,14 @@ missing-syscalls: scripts/checksyscalls.sh $(offsets-file)
>>
>>  # Check the manual modification of atomic headers
>>
>> -quiet_cmd_check_sha1 = CHKSHA1 $<
>> -      cmd_check_sha1 = \
>> -     if ! command -v sha1sum >/dev/null; then \
>> -             echo "warning: cannot check the header due to sha1sum missing"; \
>> +quiet_cmd_check_sha256 = CHKSHA256 $<
>> +      cmd_check_sha256 = \
>> +     if ! command -v sha256sum >/dev/null; then \
>> +             echo "warning: cannot check the header due to sha256sum missing"; \
>>               exit 0; \
>>       fi; \
>>       if [ "$$(sed -n '$$s:// ::p' $<)" != \
>> -          "$$(sed '$$d' $< | sha1sum | sed 's/ .*//')" ]; then \
>> +          "$$(sed '$$d' $< | sha256sum | sed 's/ .*//')" ]; then \
>>               echo "error: $< has been modified." >&2; \
>>               exit 1; \
>>       fi; \
>> --
>> 2.39.2
>
>-
>Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
>Registration No: 1397386 (Wales)
--
Thanks,
Bhaskar

"Here's looking at you kid"-- Casablanca
https://about.me/unixbhaskar

--n9V0ZVZceJnPTOYA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmQVL3UACgkQsjqdtxFL
KRUCngf+PRAc7rGZQ7BkqHCHphzw5U9Tk+UrlbX+sv2yFbLG4tdYHazBbIcZNJSz
PIxZN68OVY4K2WExYlZuUi+8GSy4xlF9nLoxMOLv9oCMHOaiGueGnzgQBjPmixet
PKY4DKkw9qc2BDd7KsVaZQtsjfvjugnrvSYPqvyDPWFJnxRvF+/vY55xunVDPcQX
NZ0xVMI/9vWhM9+ttKgO9SGjauNdhOQrNNgr5CLbXiMKkReT4ddsMy4d89HlJYbd
pB0AOa1vclSW+4iWUgcyjj8qpzTHK84pRR03CqqdrmQgmzxiGH5O2BLXxxXpjPOT
OONDb8Z1Ks65i5g+UXfMYwzhjxfzmw==
=95ci
-----END PGP SIGNATURE-----

--n9V0ZVZceJnPTOYA--