Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DACC74A5B for ; Sat, 18 Mar 2023 07:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjCRG45 (ORCPT ); Sat, 18 Mar 2023 02:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjCRG4z (ORCPT ); Sat, 18 Mar 2023 02:56:55 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D94039B91 for ; Fri, 17 Mar 2023 23:56:53 -0700 (PDT) Received: from uu22.. ([10.12.190.56]) (user=dddddd@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 32I6tJ9i012306-32I6tJ9j012306 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 18 Mar 2023 14:55:20 +0800 From: huyinhao To: joel@jms.id.au Cc: linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, huyinhao , Dongliang Mu Subject: [PATCH v2] drivers: soc: fix dead code in aspeed_lpc_snoop_config_irq Date: Sat, 18 Mar 2023 14:55:09 +0800 Message-Id: <20230318065509.51019-1-dddddd@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dddddd@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From the comment of platform_get_irq, it only returns non-zero IRQ number and negative error number, other than zero. Fix this if condition when platform_get_irq returns a negative error number. Signed-off-by: huyinhao Reviewed-by: Dongliang Mu --- v1->v2: Change "Signed-off-by" to "Reviewed-by" and change the email of "From" to "Signed-off-by" drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index eceeaf8dfbeb..c4a03b3a5cf8 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) - return -ENODEV; + if (lpc_snoop->irq < 0) + return lpc_snoop->irq; rc = devm_request_irq(dev, lpc_snoop->irq, aspeed_lpc_snoop_irq, IRQF_SHARED, -- 2.34.1