Date:   Sat, 18 Mar 2023 10:03:44 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Sean Anderson <seanga2@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init
Message-ID: <ZBV+cK8YAXI15tsL@corigine.com>
References: <20230314003613.3874089-1-seanga2@gmail.com>
 <20230314003613.3874089-8-seanga2@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230314003613.3874089-8-seanga2@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7y4ftflrdXHkveTGHGDQnBTF+7rZqousWEug+QfULY3mjOR20Qqh9OQmQYvz?=
 =?us-ascii?Q?uDnV6svm4y1sX5BkPSC3+kCCd843KkFODcOScpUh7oKZ6aXdoMxfkBmAyd2W?=
 =?us-ascii?Q?wHyXCw0fgJtn2nhKHW1kPFvbtVgfFAF3epTelsfQYfFVGpXEXFMjjlJV5u8I?=
 =?us-ascii?Q?CpEkbSoD4n5Wvj8ykOV0QcVE+F/ZUX33pq3FgXHKilr94RRLURvV06HuAvhx?=
 =?us-ascii?Q?OX4Q1fok+Jbj1FCHW5lXCAKo1mG9jlwbmwjyJJxcyU4U8MN7TR7dzXmoxWVO?=
 =?us-ascii?Q?hEs5jwT8LwHlLUA/yrnwpCkxpKBXkEnMOrQQAVYB9IccK+eJJOEj3wWotpH0?=
 =?us-ascii?Q?WDRgOd9u0nTQOX781rWvjZ53rBnS2EvvmV4SNldkNJ4xmdnoS7ZAOE/6u89v?=
 =?us-ascii?Q?14JBlf2xwU2R2NTpdjzLifo7FuVqsTxijTwvhx+h8ATPeYgIphD1wZzSXmMM?=
 =?us-ascii?Q?owzkLVm7Zuk42dlZ23NRbGLBXweIXwFGZViJEyN1/ek+qi6fjTp8YTQoBFhE?=
 =?us-ascii?Q?jyMAQnC0NOK/bbfWlYuhQjq2IUAbi0tu1NI0QDGchHGAO+TKPAWmeCZXK9o/?=
 =?us-ascii?Q?bp28KMcaXA0FONBwAbd4ecR+Vszh5kXKWjNoQ3aokXUPyWXOZglZL/LSQ4Zr?=
 =?us-ascii?Q?zzTdyAnUfJWCEujuWS6N6StrQRiNTVWGTr1Ngb6LfkIbwGLKyu/IX2TQ6bVK?=
 =?us-ascii?Q?47XlY7oMoNi80fymiAqsMEUfwpU3DhVD/lazmThxepCn2VABL2ioBnuGKizD?=
 =?us-ascii?Q?H0vC/yhnkNdJ8Mae57P3c0YC9/20PGT9dAcouDO+Jq/0w2fG5gaMRRKkRnWV?=
 =?us-ascii?Q?bF6CtZYGazpaIFGPzmTrj7X6120k1t4/i3r7FNE5wt8t/6ueoiu4C7EV/xu4?=
 =?us-ascii?Q?WCKPFj9eEjpNDJBTKLdWSqvhhdVqMLPni/OR0Uu7CvlB73JNTcWOVOC3o86d?=
 =?us-ascii?Q?YG1hlV5u4ZGijeieUlYIJ6deWPktCgiN3Dyb5T4yCZkxbqavdguevp8SOELd?=
 =?us-ascii?Q?sxKMJvTBrbK+1tvFQ/XTh7ewWTl8e+9FLsXNf+mNiPxOM8H1lS1SIccFr5Vf?=
 =?us-ascii?Q?FwR+D/U5q+rLmpULmMMNbmciS2ZNM1xO/vuWppDbZE2a8MpEgwzF5FonQgpJ?=
 =?us-ascii?Q?AsqrGGpQ/fVhkTwC9kfxtSmnWV0E0eBw7Snd3z7OqoHle6IyIklWR0d0Tl12?=
 =?us-ascii?Q?O4N011qNO9CLezsMJ3qfaMNW1qM5CeXedr1xqnE7rCoKxysoiid9J5vd5tyW?=
 =?us-ascii?Q?EqCZ0/ai7qQjHls2wz9tiWPrO7eaQqPrimxjW0A9uLIKKx/SULArlA9sk1eZ?=
 =?us-ascii?Q?o/BOu7NhjaThSL1Vs4/lcs/CUS3ZpPoHGapDVfVTEDGzM+1y5hv6q+2bXQ0e?=
 =?us-ascii?Q?BQmzmaVpt2F+K4CDi+OKQ0IdKTEyp8CdCTIczeZ7aIHQqYPLUb2AVCnGB4Oo?=
 =?us-ascii?Q?AIajYZIm7fPl63NKhPXAgYw6FFCWAidIdk8xydk1NG+2UFvu8jgaxH+3FKly?=
 =?us-ascii?Q?lW1uHE1IqfiVntOP9k06hyZ74VtqJD5fwQARh0bJCZIcfj7vYf1oVXOi8INQ?=
 =?us-ascii?Q?KCNezWAWHLWIuw9YAUR/wfSiMftPq34P1TtGxxV138N/eOiNGMnS3bsUoIVF?=
 =?us-ascii?Q?b+UY0xwrVlcjf98HBxYlh210c9MuS20+ZkutHRc/Pgfr/RhQzEB2eiBHQYEn?=
 =?us-ascii?Q?50DMDg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c83cf7df-3690-4a54-3bba-08db278fb0cc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2023 09:03:50.4444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cMIm42XBbCzAlKn867IRrTy2r8hv2yGkout3YlKog1HKVw0XcIqzseUXpQIvmVID79zsTf7DB2Z7LvzvaAc5m6mkMONfWOzC58B9eOpP7ZQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4985
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 13, 2023 at 08:36:11PM -0400, Sean Anderson wrote:
> Clean up some oddities suggested during review.
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
> 
> (no changes since v2)
> 
> Changes in v2:
> - New
> 
>  drivers/net/ethernet/sun/sunhme.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index c2737f26afbe..1f27e99abf17 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -2348,9 +2348,7 @@ static int find_eth_addr_in_vpd(void __iomem *rom_base, int len, int index, unsi
>  		p += 6;
>  
>  		if (index == 0) {
> -			int i;
> -
> -			for (i = 0; i < 6; i++)
> +			for (int i = 0; i < 6; i++)
>  				dev_addr[i] = readb(p + i);
>  			return 1;
>  		}
> @@ -2362,9 +2360,10 @@ static int find_eth_addr_in_vpd(void __iomem *rom_base, int len, int index, unsi
>  static void __maybe_unused get_hme_mac_nonsparc(struct pci_dev *pdev,
>  						unsigned char *dev_addr)
>  {
> +	void __iomem *p;
>  	size_t size;
> -	void __iomem *p = pci_map_rom(pdev, &size);
>  
> +	p = pci_map_rom(pdev, &size);
>  	if (p) {
>  		int index = 0;
>  		int found;
> @@ -2386,7 +2385,7 @@ static void __maybe_unused get_hme_mac_nonsparc(struct pci_dev *pdev,
>  	dev_addr[2] = 0x20;
>  	get_random_bytes(&dev_addr[3], 3);
>  }
> -#endif /* !(CONFIG_SPARC) */
> +#endif

Hi Sean,

I think this problem was added by patch 6/9,
so perhaps best to squash it into that patch.

Actually, I'd squash all these changes into 6/9.
But I don't feel strongly about it.

So in any case,

Reviewed-by: Simon Horman <simon.horman@corigine.com>

I will pause my review here (again!) because I need to go to a football match.