Date:   Sat, 18 Mar 2023 09:27:56 -0400
From:   William Breathitt Gray <wbg@kernel.org>
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        jic23@kernel.org, lars@metafoo.de, stable@vger.kernel.org
Subject: Re: [PATCH 6.1,6.2,6.3 v3 1/6] counter: 104-quad-8: Fix race
 condition between FLAG and CNTR reads
Message-ID: <ZBW8XN71fYwJe6rW@ishi>
References: <20230312231554.134858-1-william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="+wDaARczjHaj/9wJ"
Content-Disposition: inline
In-Reply-To: <20230312231554.134858-1-william.gray@linaro.org>
Precedence: bulk


--+wDaARczjHaj/9wJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 12, 2023 at 07:15:49PM -0400, William Breathitt Gray wrote:
> The Counter (CNTR) register is 24 bits wide, but we can have an
> effective 25-bit count value by setting bit 24 to the XOR of the Borrow
> flag and Carry flag. The flags can be read from the FLAG register, but a
> race condition exists: the Borrow flag and Carry flag are instantaneous
> and could change by the time the count value is read from the CNTR
> register.
>=20
> Since the race condition could result in an incorrect 25-bit count
> value, remove support for 25-bit count values from this driver;
> hard-coded maximum count values are replaced by a LS7267_CNTR_MAX define
> for consistency and clarity.
>=20
> Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-=
QUAD-8")
> Cc: <stable@vger.kernel.org> # 6.1.x
> Cc: <stable@vger.kernel.org> # 6.2.x
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>

Applied to counter-fixes.

William Breathitt Gray

--+wDaARczjHaj/9wJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBW8XAAKCRC1SFbKvhIj
K3KAAP9w7bhPNGq7bLugVAL4kGTJV/4p+qiDV2F5A/IX3elolgD8DG1UjgHl24Fc
AMX6rxI+muLu7Rag/fABBAakHSLxyAM=
=ZPSs
-----END PGP SIGNATURE-----

--+wDaARczjHaj/9wJ--