Message-ID: <02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de>
Date:   Sat, 18 Mar 2023 06:49:41 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA
Content-Language: en-US
To:     Cai Huoqing <cai.huoqing@linux.dev>, fancer.lancer@gmail.com
Cc:     Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-pci@vger.kernel.org
References: <20230315012840.6986-1-cai.huoqing@linux.dev>
 <20230315012840.6986-4-cai.huoqing@linux.dev>
From:   Lars-Peter Clausen <lars@metafoo.de>
In-Reply-To: <20230315012840.6986-4-cai.huoqing@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/14/23 18:28, Cai Huoqing wrote:
> Add support for HDMA NATIVE, as long the IP design has set
>
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> new file mode 100644
> index 000000000000..0a6032aa1a33
> --- /dev/null
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> @@ -0,0 +1,130 @@
>
> +struct dw_hdma_v0_ch_regs {
> [...]
> +	u32 msi_msgdata;			/* 0x00a8 */
> +	u32 padding_2[21];			/* 0x00ac..0x00e8 */
The comment here is wrong. This goes all the way to 0x00fc.
> +} __packed;
> +