Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761962AbXIRSGl (ORCPT ); Tue, 18 Sep 2007 14:06:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760449AbXIRSGb (ORCPT ); Tue, 18 Sep 2007 14:06:31 -0400 Received: from gir.skynet.ie ([193.1.99.77]:46517 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756275AbXIRSGa (ORCPT ); Tue, 18 Sep 2007 14:06:30 -0400 Date: Tue, 18 Sep 2007 19:05:25 +0100 To: Miles Lane Cc: Andrew Morton , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.23-rc6-mm1 Message-ID: <20070918180525.GD1804@skynet.ie> References: <20070918011841.2381bd93.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 42 On (18/09/07 13:20), Miles Lane didst pronounce: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `acpi_ac_remove': > ac.c:(.text+0x3eeec): undefined reference to `power_supply_unregister' > drivers/built-in.o: In function `acpi_ac_add': > ac.c:(.text+0x3f10b): undefined reference to `power_supply_register' > make: *** [.tmp_vmlinux1] Error 1 > Hi Miles, The problem appears to be that ACPI_AC is compiled in but POWER_SUPPLY is a module. You could workaround it by making them both modules but I believe the root cause may be a dependency problem. I've included a patch below that when you apply and run make oldconfig should allow you to build your kernel. ACPI folks, is this a fix? If so, there may be other dependency issues that allow a compiled-in feature to depend on a module. Signed-off-by: Mel Gorman --- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.23-rc6-mm1-015_fix_ia64_kgdb/drivers/acpi/Kconfig linux-2.6.23-rc6-mm1-020_fix_acpi/drivers/acpi/Kconfig --- linux-2.6.23-rc6-mm1-015_fix_ia64_kgdb/drivers/acpi/Kconfig 2007-09-11 03:50:29.000000000 +0100 +++ linux-2.6.23-rc6-mm1-020_fix_acpi/drivers/acpi/Kconfig 2007-09-18 19:03:32.000000000 +0100 @@ -88,7 +88,7 @@ config ACPI_PROC_EVENT config ACPI_AC tristate "AC Adapter" - depends on X86 + depends on X86 && POWER_SUPPLY default y help This driver adds support for the AC Adapter object, which indicates - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/