From:   Yangtao Li <frank.li@vivo.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()
Date:   Sat, 18 Mar 2023 22:44:04 +0800
Message-Id: <20230318144412.75046-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Xx0csyT05QBAYQlt94arwS/NSxUH5JWAXjIhQ+e80HhoQ3waqf3Y8qLH8NZL?=
 =?us-ascii?Q?MQTXbWXprOIR+7QaPrDXN4Qnv1b+aLO7h4+pu8qjhxuc2f4uKM9Dx5Uo40ZU?=
 =?us-ascii?Q?GtvTPVMxi+RGkFYYd4vbutYT30jSuaatyA7tnx2POuTfpUfARL564QOSjpso?=
 =?us-ascii?Q?O2gTBQcRM+8qwcEtYbx0QRJeI4NXVPV3XAI84H5B+qvOUDrKGmsOxdti+Npu?=
 =?us-ascii?Q?urya0Dx7TtzvsqO7sFKPmZLgFS9S/5rev9RJpOG6dNdlVStqhyJohXFItZfx?=
 =?us-ascii?Q?7sEsFVpzfwjtvr3bBTjbzR+4mhjyuG/3YZNHeZOZK3DwKLqYvNyUZgZ5lz97?=
 =?us-ascii?Q?flIlCUVGYiM5RY992lNUJAYY0sv0ADWu/pIZGZ0vCfRPeRfbH8KuwGFgJZt4?=
 =?us-ascii?Q?JEtL9GiSsPGN+VlWjjvfUH14SpOGoTMXxe0XZxOEwXJMUfsZKWYWEXmGfdA/?=
 =?us-ascii?Q?KgxCvE75wGJ2a4ofRcvn8S3AELmdfHBUXUUz76NuGuYYb6kNBGZPwnGh7e7n?=
 =?us-ascii?Q?hH7f/3hR+t6oghecDTGErULFdVfE0DlgDjGgoeE9E/dyK6bjJ/Jr6ppW9NsT?=
 =?us-ascii?Q?BREcl9oFA7TnFhYWiUcYeK8Vurb+c/0TnZgZMA40+XTrn08TH0iJ0uXNiOcz?=
 =?us-ascii?Q?KTtsoorIr3ppogzDanpyWx0LHKBmUzNOOzL2oBiYp2PHd+ShqH0BevGK3wr/?=
 =?us-ascii?Q?gofvunUl9anvzmMZt0p/4LIuLugmTqUNaVo64ShiVJWHNDnORFXiVFMMriaL?=
 =?us-ascii?Q?0MHVeAB8efLuaRhlk9gIjtKh1MHT7o4pjIcIb8FidGQ77TaT0+CF0vercLZV?=
 =?us-ascii?Q?yeHWSHpfr5avW5tK+QrmkOeya+kdsx91AcRwVIP+cul9fC4q4wyNIWF2U7dL?=
 =?us-ascii?Q?FUW3g1/imY2ADV00E8Lv79yMYfm5qtebNfkXAkp0Vcxx8Q4wEVuBkk/BjhZf?=
 =?us-ascii?Q?l3lZNu0CMOCAfMuGUZj/YSYzpE1yq7Wu3Lg6JwPH7uJqDJkPaubJ+zPXbK62?=
 =?us-ascii?Q?0xUVJg6F92jzsdTr7cIJqC9vG3NRMowIS0aCNN0zPdNoDfmzIAu5Hbv3nv4U?=
 =?us-ascii?Q?WlQvDZOZ6qIlOea0PhZP6evvtEbNhXaLZXXiL3f0re5JyLrngn6vUAkhr9qs?=
 =?us-ascii?Q?+X4oBbLBG5CgIHpJxwKmqmockAKgBIKtjPX+WmylqVznp0rIKIKaapIZF3Bp?=
 =?us-ascii?Q?2P7GzY7o9d/GTreMDOh1KY/ss1PHws5j/bVhGuucZsUcOimH2q4Zx1dTSXSI?=
 =?us-ascii?Q?FPibyJZzLG4zb4eTRPA6KA2OZAvCM4/h9RTz+r+D0ERipLvjtRBtqquSuMSU?=
 =?us-ascii?Q?RL+I5y3Er6GotiFYY+i655gAp164FMJymLXZfp5T3+jGgm1I0eGYKq3qRIUw?=
 =?us-ascii?Q?lB0emT+qn3uSpNfGEfkMKsXUrrrISPYrj0TzTX2e5LnCJ1AAI+Y0wk7V7pEY?=
 =?us-ascii?Q?xJELCNtCFxvNSszjkMUXnYpkxXBj9hoGoXfE2MPwRmRA1xze/IZ2D14Wrkxe?=
 =?us-ascii?Q?UuzPnnKuGJOyC9LqzHl5oIy3Xp3lefRzxzveSvkU2+OrdAOa6ForL26RBAKH?=
 =?us-ascii?Q?XsPimgBMUp9BkxENo77bVbvD0SB9oKPR7Incb6pw?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8c128b2-e4f6-4ff1-a026-08db27bf4af5
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2023 14:44:35.5573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N62YFwcwJejKkuKHP2912b4WJVCmJ/iYNHlrEfjcYS9AsWCfIhm0aZt/inQoPvCxmRx2ZtARoMApq2VFMLV2bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5283
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/thermal/thermal_hwmon.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index c59db17dddd6..ae87401b1a1d 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -271,11 +271,15 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device
 
 	ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr),
 			   GFP_KERNEL);
-	if (!ptr)
+	if (!ptr) {
+		dev_err(dev, "Failed to allocate device resource data\n");
 		return -ENOMEM;
+	}
 
 	ret = thermal_add_hwmon_sysfs(tz);
 	if (ret) {
+		dev_err(dev, "Failed to add hwmon sysfs attributes\n");
+
 		devres_free(ptr);
 		return ret;
 	}
-- 
2.35.1